MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice ( #30957 )
...
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice
* Update phan baseline
* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
MDW
f89245b354
Qual: Fix some CommonIncoterm/DocGenerator/People typings ( #30940 )
...
* Fix extraparams property typing
* Fix argument typing
* Fix 'status' argument type in calls to dolGetButtonTitle
* Fix argument2 for price to 1 (was 2)
* Fix deliveryreceipt argument
* Fix PHPDoc dol_sort_array
* Fix range for int argument
* Fix arg type for str_pad and add some PHPDoc
* Fix natsort value for dol_sort_array
* Fix arguments on calls to dol_sort_array
* Reduce phpstan exceptions
* Qual: Add type hints for Stripe objects
# Qual: Add type hints for Stripe objects
Suggest the more specific implementation of the StripObject.
* Typing, initialisation
* Qual: Fix undeclared variables
* Update phan baseline
* Update baseline
* Qual: Add type hints for Stripe objects
# Qual: Add type hints for Stripe objects
Suggest the more specific implementation of the StripObject.
* Add PHPDoc for host class properties
* Ignore false positive (phan) for deprecated property
* Improve typing
* Update baseline
2024-09-13 03:09:23 +02:00
MDW
0efe669e4b
Fix: 🛟 getrights must return a value ( #30904 )
...
# Fix:getrights must return a value
The phan notice is all about the function not returning a value
while it is said to return a value.
Added the missing 'return'
2024-09-10 00:57:02 +02:00
Laurent Destailleur
f5c57e1608
deprecate method getrights that is conflict with getRights() of
...
CommonObject.
2024-09-07 18:03:43 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan ( #30860 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-06 13:44:29 +02:00
Laurent Destailleur
14d5b4bcc3
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-02 12:14:51 +02:00
Laurent Destailleur
ef84ba2a13
Debug v20
2024-09-02 10:21:24 +02:00
Laurent Destailleur
2e2ab9d84d
Fix missing test on permissions
2024-09-01 13:48:58 +02:00
Laurent Destailleur
e3c9f1db7c
Standardize name of var for permission check
2024-09-01 13:02:28 +02:00
Laurent Destailleur
4c0e978d42
Fix phan
2024-09-01 12:46:17 +02:00
Laurent Destailleur
827c3daa03
Fix test on permissions
2024-08-31 19:15:14 +02:00
Laurent Destailleur
c30d706ab6
Add more phpunit tests
2024-08-31 18:11:16 +02:00
Laurent Destailleur
f126e015a3
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-31 12:25:43 +02:00
Laurent Destailleur
ff79295e2c
Debug v20
2024-08-31 12:24:49 +02:00
William Mead
ca8bbc614a
NEW user list country filter ( #30770 )
...
* Added user country sql
* Added search user country to list
* Added contributor details
2024-08-27 03:06:08 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
HENRY Florian
d551f200f2
new: when initHook() and restrictedArea() exists always execute first initHook() ( #30703 )
2024-08-20 23:32:43 +02:00
Laurent Destailleur
fdb209ca41
Add a check to allow setPassword from apis
2024-08-17 16:41:30 +02:00
Laurent Destailleur
52c8b669c9
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 16:20:17 +02:00
Laurent Destailleur
c481be58f7
Clean code
2024-08-17 16:20:06 +02:00
Jon Bendtsen
5c6594b4ce
NEW API call to re-generate a users password. ( #30590 )
...
* NEW API call to re-generate a users password.
* fixing job:pre-commit that gave an error saying it was missing here
* adding the variable
* trying to load global user variable based on this comment https://github.com/Dolibarr/dolibarr/pull/30589#issuecomment-2276631147
* first attempt didnt work, but I found that global $conf at the top of the function
* adjust http error code to 500
* removing some comments and pre commit fix
* making send password a bool + using ->useraccount as pr. @eldy request
* lower case false
* Update api_users.class.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-17 16:19:55 +02:00
Florent Poinsaut
c7f8a8c06d
FIX #30520 Creator user data displayed in the form after an error in the user creation form ( #30521 )
2024-08-15 17:24:42 +02:00
Florent Poinsaut
4d3b83e625
FIX #30523 An user with only user->rights->user->self->password can't update it's password ( #30524 )
2024-08-15 17:10:57 +02:00
Florent Poinsaut
0008496974
FIX #30523 An user with only user->rights->user->self->password can't update it's password ( #30524 )
2024-08-15 17:10:27 +02:00
Laurent Destailleur
b1a83a6e58
Debug look and feel v21
2024-08-14 18:40:33 +02:00
MDW
be0f28245c
Qual: Fix phan notices wrt main.inc.php, menus ( #30633 )
...
* Qual: Fix phan notices wrt main.inc.php, menus
# Qual: Fix phan notices wrt main.inc.php, menus
This fixes phan notices stemming from main.inc.php and the menu classes.
* Qual: Fix phpstan notice that dol_authmode always set
# Qual: Fix phpstan notice that dol_authmode always set
dol_authmode is always set because it is now initialised.
2024-08-14 14:05:56 +02:00
Laurent Destailleur
ed73dc6471
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-13 11:59:53 +02:00
Laurent Destailleur
db93af6c77
Debug v20
2024-08-13 11:07:04 +02:00
Laurent Destailleur
f11bed462a
Fix label list
2024-08-13 05:05:54 +02:00
Laurent Destailleur
79f1cc95bb
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/core/lib/company.lib.php
2024-08-13 04:47:12 +02:00
Laurent Destailleur
fe21cc3605
Debug v20
2024-08-13 04:37:19 +02:00
Laurent Destailleur
5c36a834d1
Debug v20 - Fix sql distinct
2024-08-13 04:12:09 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 03:05:02 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
MDW
e3d3bad080
Fix: 🛟 Fix getrights usage & Update the documentation to suggest to use loadRights ( #30543 )
...
* Qual: Update the documentation to suggest to use loadRights
# Qual: Update the documentation to suggest to use loadRights
Given the pending issues, update the documention regarding getrights to
point to loadRights.
* Fix: call loadRights on User (not getRights)
2024-08-04 18:47:22 +02:00
Laurent Destailleur
823e53803d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-03 15:45:33 +02:00
Laurent Destailleur
6558c69ac7
Doc
2024-08-02 11:17:14 +02:00
Laurent Destailleur
5727dadfdd
Fix condition to get permission
2024-08-02 10:55:53 +02:00
Laurent Destailleur
f002fb4ed1
Use the non deprecated function loadRights instead of getrights
2024-08-02 10:36:43 +02:00
Laurent Destailleur
46cde6431a
NEW Can use a specific profile to send email for password forgotten
2024-08-01 11:36:21 +02:00
Laurent Destailleur
292080ca14
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-30 12:28:15 +02:00
Laurent Destailleur
4223c6241c
Fix tooltip
2024-07-30 11:52:40 +02:00
Lucas Marcouiller
a4908abc8a
New Main checkbox left column to manage this conf for each users ( #30439 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-26 05:01:26 +02:00
Laurent Destailleur
6d0e16c7b2
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-21 14:46:09 +02:00
Laurent Destailleur
6ac589b0a9
NEW Introduce value 'password' formode of sanitization in GETPOST.
2024-07-21 14:44:14 +02:00
MaximilienR-easya
66d8bc4f01
NEW Module to setup OpenID Connect module ( #30317 )
...
* import openid connect custom module phase 1
* indent fix
* fix ci
* Fix ci
* Fix
* add missing lang file
* lang file
* Multiple fix: callback url overwriten by a js.php from a module, admin page path fix, add a field to set MAIN_AUTHENTICATION_OIDC_LOGIN_CLAIM
* windows-ci friendly modification
* windows-ci friendly modification
* comment
* Fix precommit
* Fix precommit
* Fix precommit
* Fix precommit
* Update lang file and conditions
* Update functions_openid_connect.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-21 02:12:03 +02:00
Frédéric FRANCE
fbbdf7fb3e
fix cti ( #30323 )
2024-07-09 19:29:35 +02:00
Frédéric FRANCE
29f223fd3c
fix checkFunctionArgumentTypes ( #30249 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Christophe Battarel
3faf45e6e5
FIX missing include ( #30242 )
...
Co-authored-by: Christophe Battarel <christophe@altairis.fr>
2024-07-03 01:56:19 +02:00
