Commit Graph

137550 Commits

Author SHA1 Message Date
John BOTELLA
8bfbbf7971
extend drop down behavior to all drop down (#30933)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-16 01:52:33 +02:00
MDW
9a9e851494
Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
MDW
fa8078c03d
Qual: 🛟 Fix typing (#30961)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages
2024-09-16 01:46:37 +02:00
MDW
320f0590d2
Qual: More specific phpstan exceptions (#30967)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: More specific phpstan exceptions

# Qual: More specific phpstan exceptions

Avoid ignoring new types of code errors
2024-09-16 01:46:20 +02:00
Laurent Destailleur
22ae541e3b Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 00:08:33 +02:00
Laurent Destailleur
283bd723ec Debug v20 - Fix filter on extrafields for select from table 2024-09-15 23:51:03 +02:00
Laurent Destailleur
beee24d24d Doc 2024-09-15 23:02:56 +02:00
Laurent Destailleur
2593561ab6 Fix label of menu 2024-09-15 18:21:36 +02:00
Laurent Destailleur
10065e413b center 2024-09-15 13:28:37 +02:00
Laurent Destailleur
f6ae913056 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-15 13:18:28 +02:00
Laurent Destailleur
411e0eac86 Fix placeholder 2024-09-15 13:03:04 +02:00
Laurent Destailleur
490deb8ef6 Debug v20 token on reconcile 2024-09-15 12:52:27 +02:00
Laurent Destailleur
90c3b342f2 Debug v20 token on reconcile 2024-09-15 12:51:13 +02:00
Laurent Destailleur
2ad1c61976 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-15 12:33:25 +02:00
Laurent Destailleur
3612113e1c css 2024-09-15 12:32:27 +02:00
Laurent Destailleur
3ee51d5311 Add test on domain .entreprises 2024-09-15 11:24:34 +02:00
Laurent Destailleur
26ba862540 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 02:45:04 +02:00
Laurent Destailleur
c462a572ee Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-14 02:44:26 +02:00
Laurent Destailleur
086ba6215e Add token 2024-09-14 02:43:27 +02:00
Laurent Destailleur
2cb8eeee77 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 01:37:10 +02:00
Laurent Destailleur
3025f7ba25 NEW Add getImageFromHtmlContent() method 2024-09-14 01:36:31 +02:00
Laurent Destailleur
b66f7be923 Debug v20 - Fix td balance 2024-09-13 18:51:25 +02:00
Laurent Destailleur
057fcdfaef Fix: In v20, all global caches must use $conf->cache['nameofcache']
instead of a global variable.
2024-09-13 18:44:23 +02:00
William Mead
e644f05f98
Qual clean use of CommonSignedObject trait (#30927)
* Cleaned & refactored code to make full use of CommonSignedObject trait

* Fixed Phan warning

* Revert "Fixed Phan warning"

This reverts commit b79b362733.

* Try @static tag

* Cleaned code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:45:05 +02:00
Florent Poinsaut
b4bcb243c0
FIX #30950 Bad ref in supplier invoice created by Rest API from an invoice template (#30951) 2024-09-13 17:42:09 +02:00
Frédéric FRANCE
2a6bbf88df
fix phpstan (#30944)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-13 17:40:03 +02:00
Josep Lluís
fa62be55d9
Update pdf_vinci.modules.php (#30946)
The date_approve field doesn't exist and has been replaced by date_start_planned
2024-09-13 17:39:39 +02:00
John BOTELLA
308178d5bc
QUAL : Ergo btn and fix (#30947)
* Clean sql

* Doc

* Fix ergo feedback and accessibility button

* Add hsl color var to allow css use user color with variants

* Add hsl color var to allow css use user color with variants

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:30:41 +02:00
Laurent Destailleur
3a4e2c2bcf Debug v20 - Fix sql 2024-09-13 16:36:11 +02:00
Laurent Destailleur
3ff6015b40 Comments 2024-09-13 16:28:23 +02:00
Laurent Destailleur
da5d4f0f67 Debug v20 2024-09-13 15:58:26 +02:00
Laurent Destailleur
c6050e2a1e Add column to track when an event reminder was sent 2024-09-13 15:55:26 +02:00
Laurent Destailleur
62427cf8a2 Fix sql error 2024-09-13 14:49:50 +02:00
Laurent Destailleur
10cc3327ab Fix sql error 2024-09-13 14:49:28 +02:00
Laurent Destailleur
04ebf52bd0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-13 11:13:51 +02:00
Laurent Destailleur
4a303a61d1 More robust test on missing permission for CTI 2024-09-13 11:13:38 +02:00
Laurent Destailleur
75d62b5f0a Fix check on permissions 2024-09-13 04:47:07 +02:00
MDW
58217355b5
Qual: Add type hints for Stripe objects (#30930)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline
2024-09-13 04:14:00 +02:00
William Mead
80ce987ac8
NEW fichinter list disable details option (#30884)
* Added FICHINTER_DISABLE_DETAILS_ON_LIST option

* Updated changelog

* Refactored option
2024-09-13 04:09:18 +02:00
Laurent Destailleur
857405bea6 Doc 2024-09-13 03:47:30 +02:00
Frédéric FRANCE
ef0a3329a1
fix phpstan (#30914)
* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:11:43 +02:00
William Mead
3922b855da
Fixed intervention online signature position (#30926)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:11:10 +02:00
William Mead
72aec91064
NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
MDW
f89245b354
Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
fea4b3e00f Clean sql 2024-09-13 03:03:32 +02:00
William Mead
93b93e8c3f
Qual intervention deprecated warnings (#30935)
* Fixed passing null

* Fixed deprecated $date

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 02:52:27 +02:00
Laurent Destailleur
ee9a5b05d0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 22:06:27 +02:00
Laurent Destailleur
1f33c81038 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 22:06:18 +02:00
William Mead
7600157b5a
Qual isolate ExpeditionLigne class to separate file (#30877)
* Moved expedition line class to separate file. Removed unnecessary requires.

* Updated PHPDoc

* Fixed PHPDoc

* Fixed PHPDoc

* Fixed undeclared variable

* Fixed type

* Fixed PHPDoc

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-12 22:04:35 +02:00