Commit Graph

11288 Commits

Author SHA1 Message Date
MDW
9a9e851494
Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
MDW
320f0590d2
Qual: More specific phpstan exceptions (#30967)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: More specific phpstan exceptions

# Qual: More specific phpstan exceptions

Avoid ignoring new types of code errors
2024-09-16 01:46:20 +02:00
Laurent Destailleur
26ba862540 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 02:45:04 +02:00
Laurent Destailleur
c462a572ee Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-14 02:44:26 +02:00
Laurent Destailleur
2cb8eeee77 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-14 01:37:10 +02:00
Laurent Destailleur
3025f7ba25 NEW Add getImageFromHtmlContent() method 2024-09-14 01:36:31 +02:00
Laurent Destailleur
057fcdfaef Fix: In v20, all global caches must use $conf->cache['nameofcache']
instead of a global variable.
2024-09-13 18:44:23 +02:00
John BOTELLA
308178d5bc
QUAL : Ergo btn and fix (#30947)
* Clean sql

* Doc

* Fix ergo feedback and accessibility button

* Add hsl color var to allow css use user color with variants

* Add hsl color var to allow css use user color with variants

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 17:30:41 +02:00
Laurent Destailleur
857405bea6 Doc 2024-09-13 03:47:30 +02:00
William Mead
72aec91064
NEW shipment signed status update (#30928)
* Added event message

* Added CommonSignedObject trait. Updated LibStatut method. Removed unnecessary properties.

* Added SHIPPING_MODIFY notification

* Refactored to use setSignedStatus method

* Updated PHPDoc. Removed unnecessary properties. Added contributor details.

* Added signed status to shipping list

* Added signed status to fetch method

* Fixed type

* Added signed status to notification message

* Updated EN localization

* Fixed static property

* Added event message localization

* Updated EN localization

* Updated PHPDoc

* Added signed status for use in tooltip

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:09:53 +02:00
MDW
f89245b354
Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
Laurent Destailleur
cc63d3f8f5 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 21:50:57 +02:00
Laurent Destailleur
bf697f83eb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-09-12 21:50:31 +02:00
Mohamed DAOUD
797ec9a709
fix-seo-meta-tags-sanitization (#30924)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-12 21:35:38 +02:00
John BOTELLA
aaa65ddf6b
Fix v20 php8 patch001 (#30932)
* Fix PHP 8 notices, warninngs, fatal

* precommit
2024-09-12 21:10:01 +02:00
Laurent Destailleur
b1ee18864f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 01:43:43 +02:00
Laurent Destailleur
cbf3cbfa1f Better debug log 2024-09-12 01:33:58 +02:00
Laurent Destailleur
2bd701a87f Debug v20 2024-09-11 16:46:16 +02:00
Laurent Destailleur
b851ad1d84 Doc 2024-09-10 14:58:44 +02:00
Laurent Destailleur
62f7e219d1 Debug css v20 2024-09-10 10:55:47 +02:00
MDW
506454b10a
Qual: Resolve ~200 phan notices/~100 phpstan notices (#30879)
* bookkeeping\card.php, productaccount

* Fix bookkeeping/listbyaccount

* Typing for accountancycategory

* Fix typing accountancyimport

* Typing accountingaccount

* Typing api_accountancy

* bookkeeping typing

* Fix typing lettering

* Typing for accountancy/customer/list

* Typing accountancy/journal/bankjournal

* typing accountancy/journal/variousjournal

* Typing accountancy/supplier/list

* Initialisations in accountancy/journal/expensereportsjournal

* Initialisations in accountancy/journal/purchasesjournal

* Initialisations in accountancy/journal/sellsjournal

* Update baseline
2024-09-10 02:11:53 +02:00
Laurent Destailleur
b8aa7e2511 Fix option restricthtmlallowlinkscript of GETPOST 2024-09-09 15:56:47 +02:00
Laurent Destailleur
e003c6a516 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 02:20:15 +02:00
Laurent Destailleur
43f42d08ad Fix warning 2024-09-06 14:01:55 +02:00
Laurent Destailleur
bcc9ad42d4 Doc 2024-09-06 13:49:15 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Laurent Destailleur
c972f44dc2 Debug v20 - Fix mandatory fields 2024-09-06 02:59:21 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
bee59df23c Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-05 15:02:30 +02:00
Laurent Destailleur
d862b40f3d Fix warning 2024-09-05 14:25:14 +02:00
Laurent Destailleur
1b16ae87e4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-05 12:40:15 +02:00
Laurent Destailleur
2ccfe2e2c0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-05 10:17:12 +02:00
Mohamed DAOUD
e45bf5c487
fix extname for getimagepublicurlofobject (#30830)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-05 10:03:20 +02:00
Laurent Destailleur
4f48a08d1b Protect param extName 2024-09-05 10:03:00 +02:00
Mohamed DAOUD
7200d244c2
dynamically set seo meta tags (#30826)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-04 23:14:25 +02:00
Laurent Destailleur
6e19d09a66 More info to help debug 2024-09-04 16:52:39 +02:00
Laurent Destailleur
c8e2b537c6 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-30 16:44:24 +02:00
Laurent Destailleur
2a2ff8dd79 Debug v20 2024-08-30 15:06:19 +02:00
Frédéric FRANCE
77c88e9750
add hooke in print_social_networks (#30797)
add hooke in print_social_networks
2024-08-29 17:25:54 +02:00
MDW
c496e84916
Qual: Fix phan issues related to getNextValue() notices (#30747)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix some phan typing related to getNextValue()

# Qual: Fix some phan typing related to getNextValue()

This fixes a few typings in relation to getNextValue().

* Update phan baseline

* PHPDoc: set arguments as nullable (+update array types)

* Improve PHPDoc

* Force toselect type to int[]

* Enable all phan notices on actions_massactions.inc.php

* Test was wrong, can not count when it's not an array

* Update baseline

* Remove ignore for notice that no longer exists

* Update baseline

* Fix format argument

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-29 15:01:42 +02:00
Laurent Destailleur
8ab740a95f Export inventory 2024-08-29 10:46:10 +02:00
MaximilienR-easya
89a1e74df3
Force usage of another authentication when there is only openid_connect since he doesn't work for api, ws, and cdav login (#30777) 2024-08-29 09:20:02 +02:00
Laurent Destailleur
5a0ec754d8 Fix regression __ID__ lost into backtopage urls 2024-08-28 23:49:53 +02:00
Laurent Destailleur
3392ddf42e Fix spellcheck 2024-08-27 22:24:32 +02:00
Laurent Destailleur
e7cfa4ddcc Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 07:26:26 +02:00
Laurent Destailleur
c03617d5b7 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-08-27 04:46:30 +02:00
Laurent Destailleur
93e8d2baba FIX #30762 2024-08-27 03:30:24 +02:00
Laurent Destailleur
ce7f038a90 Fix mime for xz 2024-08-26 22:11:16 +02:00
Laurent Destailleur
0feb44cd9e Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-26 21:09:21 +02:00