Commit Graph

9247 Commits

Author SHA1 Message Date
MDW
9a9e851494
Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
Laurent Destailleur
3bf7bab967 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 02:21:46 +02:00
Laurent Destailleur
a52963020d Doc 2024-09-12 02:21:14 +02:00
Laurent Destailleur
b1ee18864f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 01:43:43 +02:00
Laurent Destailleur
0d62dc8ecd Give an help to allow to fix charset regression. 2024-09-12 01:41:30 +02:00
Laurent Destailleur
90dcb105f0 Fix option INVOICE_DISABLE_REPLACEMENT 2024-09-11 15:56:04 +02:00
William Mead
fb6677010d
NEW contract signed status update (#30779)
* Moved signed status constants to array dictionary

* Added getLibSignedStatus & getSignedStatusLocalisedArray methods

* Updated fetch & create methods for signed_status

* Added signed status to status badge

* Updated signed_status module builder field

* Added object context signed status for action trigger

* Added signed status to contract list

* Fixed signed status for contract list

* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.

* Fixed old contract without signed status

* Added contract modify notification

* Added contract signed status update

* Updated EN localizations

* Fixed contract notification administration

* Fixed notification message

* Fixed contract status badge

* Fixed langs

* Fixed langs key

* Fixed duplicate localization
2024-09-10 03:04:49 +02:00
Laurent Destailleur
613c25b5ff Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-10 02:02:16 +02:00
Laurent Destailleur
ba60cabb39 Allow only version string 2024-09-09 23:14:42 +02:00
Laurent Destailleur
ffeef2f058 Doc 2024-09-09 23:10:34 +02:00
Laurent Destailleur
8889642fa4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 04:16:29 +02:00
Laurent Destailleur
359cd1473f Fix trans 2024-09-09 04:16:02 +02:00
Laurent Destailleur
74330f0a14 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-08 22:16:01 +02:00
Laurent Destailleur
c7ccca10ed Fix warning 2024-09-07 19:39:10 +02:00
Laurent Destailleur
8fcaffbd72 Fix help tooltip for email setup 2024-09-07 19:15:58 +02:00
Laurent Destailleur
6167f8c039 Fix doc 2024-09-07 15:24:53 +02:00
Laurent Destailleur
a5fcf7e0e4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 14:22:19 +02:00
Laurent Destailleur
db5bfa7b7c Fix loop to show SPF was not complete 2024-09-07 14:21:40 +02:00
Laurent Destailleur
e003c6a516 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 02:20:15 +02:00
Laurent Destailleur
cbdf4d3559 Fix upload of module zip files 2024-09-07 02:13:53 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
1b16ae87e4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-05 12:40:15 +02:00
Laurent Destailleur
37922f464f Fix phan 2024-09-04 19:44:01 +02:00
Laurent Destailleur
ed81c3f875 Fix info on smartphone 2024-09-04 11:20:06 +02:00
Laurent Destailleur
c8d6281b3e Revert "Fix showing SPF record"
This reverts commit 7ec3b30b70.
2024-09-04 11:16:52 +02:00
Laurent Destailleur
8114d3e9a8 Revert "Fix showing SPF record"
This reverts commit 7b07758a83.
2024-09-04 11:16:25 +02:00
Laurent Destailleur
7ec3b30b70 Fix showing SPF record 2024-09-04 11:13:37 +02:00
Laurent Destailleur
7b07758a83 Fix showing SPF record 2024-09-04 11:12:51 +02:00
Laurent Destailleur
d97c3a9f45 Look and feel v21 2024-09-03 11:19:01 +02:00
Laurent Destailleur
38612e3cf7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-03 01:58:02 +02:00
Laurent Destailleur
306def7aab Debug v20 look and feel v20 2024-09-02 22:46:14 +02:00
Laurent Destailleur
544020c32c Debug v20 2024-09-02 22:39:42 +02:00
Laurent Destailleur
82c10d081b Debug v21 2024-09-02 18:13:40 +02:00
Laurent Destailleur
d30317e132 Debug v21 2024-09-02 18:13:04 +02:00
MDW
c496e84916
Qual: Fix phan issues related to getNextValue() notices (#30747)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix some phan typing related to getNextValue()

# Qual: Fix some phan typing related to getNextValue()

This fixes a few typings in relation to getNextValue().

* Update phan baseline

* PHPDoc: set arguments as nullable (+update array types)

* Improve PHPDoc

* Force toselect type to int[]

* Enable all phan notices on actions_massactions.inc.php

* Test was wrong, can not count when it's not an array

* Update baseline

* Remove ignore for notice that no longer exists

* Update baseline

* Fix format argument

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-29 15:01:42 +02:00
hansemschnokeloch
8ae78a33ff
Fix 30695 (#30697) 2024-08-27 06:51:12 +02:00
MDW
56e0bba970
Qual: Disable global CommonObject $obj type (phan) (#30750)
* Qual: Disable global CommonObject $obj type (phan)

# Qual: Disable global CommonObject $obj type (phan)

This removes the global typing hint for $obj from the phan configuration

* Fix issues with undeclared $obj

* Fix issues with undeclared $obj

* Fix issues with undeclared $obj
2024-08-27 04:57:04 +02:00
MDW
f5c7ca1769
Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence (#30754)
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php

* Qual: PHPDoc for import/export array types

* Qual: Add PHPDoc types to import.class.php

* Fix PhanPluginUnknownObjectMethodCall in stats.class.php

* Add methods expected on ModeleImport child classes

* Force imapemail type for phan

* Qual: Update phan baseline

* Qual: Fix Undefined/Undeclared phan notices in module_help

* Update baseline
2024-08-27 04:51:41 +02:00
Laurent Destailleur
7dfc3c8b35 Fix space 2024-08-27 01:05:32 +02:00
Laurent Destailleur
ebca595b7d Fix: disable spellcheck on input url 2024-08-26 15:33:48 +02:00
Laurent Destailleur
3a80cf4033 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-24 14:26:09 +02:00
Laurent Destailleur
f307d28c12 Fix some warnings 2024-08-24 14:25:51 +02:00
lamrani abdelwadoud
5695131529
New Updating fediverse for edit infos and other params (#30654)
* Update fediverse for edit infos

* Fix error phpStan

* Fix phpStan errors
2024-08-24 13:42:05 +02:00
Laurent Destailleur
5797a0db3f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-22 02:54:55 +02:00
Laurent Destailleur
2f8c0f119a Fix test on securiy page 2024-08-20 15:05:06 +02:00
Laurent Destailleur
69bc79b9a9 Fix test on securiy page 2024-08-20 15:02:33 +02:00
Laurent Destailleur
10d0aafef6 Fix br 2024-08-20 14:32:25 +02:00
Laurent Destailleur
23c91578f0 NEW Add pîcto on list of notification email templates 2024-08-20 11:02:47 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00