From 4e0139854566d1a8495f269c213b62185377cb4e Mon Sep 17 00:00:00 2001 From: Andy Miller Date: Mon, 6 Nov 2023 16:50:27 +0000 Subject: [PATCH] Added debugger output when routes conflict --- system/src/Grav/Common/Page/Pages.php | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/system/src/Grav/Common/Page/Pages.php b/system/src/Grav/Common/Page/Pages.php index e39e3ab60..2eecf0c22 100644 --- a/system/src/Grav/Common/Page/Pages.php +++ b/system/src/Grav/Common/Page/Pages.php @@ -2013,17 +2013,26 @@ class Pages // add regular route if ($route) { + if (isset($this->routes[$route]) && $this->routes[$route] !== $page_path) { + $this->grav['debugger']->addMessage("Route '{$route}' already exists: {$this->routes[$route]}, overwriting with {$page_path}"); + } $this->routes[$route] = $page_path; } // add raw route - if ($raw_route && $raw_route !== $route) { + if ($raw_route) { + if (isset($this->routes[$raw_route]) && $this->routes[$route] !== $page_path) { + $this->grav['debugger']->addMessage("Raw Route '{$raw_route}' already exists: {$this->routes[$raw_route]}, overwriting with {$page_path}"); + } $this->routes[$raw_route] = $page_path; } // add canonical route $route_canonical = $page->routeCanonical(); - if ($route_canonical && $route !== $route_canonical) { + if ($route_canonical) { + if (isset($this->routes[$route_canonical]) && $this->routes[$route_canonical] !== $page_path) { + $this->grav['debugger']->addMessage("Canonical Route '{$route_canonical}' already exists: {$this->routes[$route_canonical]}, overwriting with {$page_path}"); + } $this->routes[$route_canonical] = $page_path; } @@ -2031,6 +2040,9 @@ class Pages $route_aliases = $page->routeAliases(); if ($route_aliases) { foreach ($route_aliases as $alias) { + if (isset($this->routes[$alias]) && $this->routes[$alias] !== $page_path) { + $this->grav['debugger']->addMessage("Alias Route '{$alias}' already exists: {$this->routes[$alias]}, overwriting with {$page_path}"); + } $this->routes[$alias] = $page_path; } }