Commit Graph

349 Commits

Author SHA1 Message Date
MDW
9b146f3fe1
Fix restler stub ApiMethodInfo typing 2024-03-20 04:10:11 +01:00
MDW
a69dcc9c5a
Qual: Enable PhanTypeMismatchArgumentSuperType 2024-03-20 04:09:19 +01:00
MDW
390d164f82
Qual: Ignore PhanTypeMismatchArgumentNullableInternal 2024-03-20 04:09:18 +01:00
MDW
6413341c96
Qual: Enable PhanTypeMismatchArgumentInternal 2024-03-20 04:09:17 +01:00
MDW
a094ad38fc
Fix spelling (using beta codespell)
# Fix spelling (using beta codespell

New spelling fixes - ignoring thirdparty which should be either third-party
or third party.
2024-03-20 00:35:01 +01:00
MDW
04d7142463
Disable HTML plugin (detects HTML in PHP files)
# Disable HTML plugin (detects HTML in PHP files)

These messages are not really useful for dolibarr.
2024-03-19 18:09:19 +01:00
MDW
c0e8e053b8
Fix port arg to count by adding typing information 2024-03-19 02:59:09 +01:00
MDW
cd3ea72f96
Qual: Disable global variable suggestion for $website 2024-03-19 02:44:07 +01:00
MDW
3c968477cb
Change type of global $website to string 2024-03-19 02:44:04 +01:00
MDW
921431dbdc
Qual: Enable PhanTypeSuspiciousStringExpression 2024-03-19 02:44:03 +01:00
Laurent Destailleur
29a858aa68
Merge pull request #28924 from mdeweerd/fix/whitespace
Fix trailing whitespace + format code + minor spelling + enable checks
2024-03-19 02:14:13 +01:00
Frédéric FRANCE
65fcc53519
Merge branch 'develop' into phpstanphpstan 2024-03-18 23:47:59 +01:00
Frédéric France
eb8014c001 Merge remote-tracking branch 'upstream/develop' into phpstanphpstan 2024-03-18 17:50:42 +01:00
Frédéric FRANCE
a9cabe6fe4
Update codespell-dict.txt 2024-03-18 16:39:49 +01:00
MDW
d2568a0878
Qual: Enable PhanUndeclaredVariableAssignOp 2024-03-18 13:12:53 +01:00
Frédéric France
21d0cc9470 Merge remote-tracking branch 'upstream/develop' into phpstanphpstan 2024-03-17 22:05:01 +01:00
Frédéric France
09a953d18f fix phpstan 2024-03-17 22:04:10 +01:00
MDW
686facd74d
Fix PhanPluginWhitespaceTrailing + format code + minor spelling 2024-03-17 21:35:08 +01:00
MDW
aa6c20bf0d
Qual: Enable PhanPluginWhitespaceTrailing 2024-03-17 21:35:07 +01:00
Laurent Destailleur
bb0e18deae
Merge pull request #28922 from mdeweerd/fix/printf
Fix & enable Phan printf checks
2024-03-17 21:08:26 +01:00
MDW
7a4f5ec4f8
Qual: Enable some low occurence notifications 2024-03-17 20:12:27 +01:00
MDW
aa5aa2bf26
Add one more index to the theme_datacolor 2024-03-17 19:49:10 +01:00
MDW
d73886281c
Qual: Set typing for global 2024-03-17 18:56:44 +01:00
MDW
81d5f30466
Qual: Enable PhanPluginPrintfIncompatibleArgumentType 2024-03-17 18:56:43 +01:00
MDW
4232713e96
Qual: enable PhanPluginPrintfVariableFormatString 2024-03-17 18:21:35 +01:00
Laurent Destailleur
91c5868020
Merge pull request #28909 from mdeweerd/fix/PhanPluginUnknownClosureReturnType
Fix & enable PhanPluginUnknownClosureReturnType
2024-03-17 03:03:35 +01:00
MDW
551eaa115c
Fix & enable PhanPluginUnknownClosureReturnType
# Fix & enable PhanPluginUnknownClosureReturnType

Fix last PhanPluginUnknownClosureReturnType & enable the notice as
all are fixed
2024-03-17 00:10:18 +01:00
MDW
ef6eea3ed2
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-17 00:03:20 +01:00
Laurent Destailleur
7930226c0b
Merge branch 'develop' into qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions 2024-03-16 21:37:43 +01:00
MDW
2460518608
Add exception with latest codespell 2024-03-16 18:13:13 +01:00
MDW
c146f708e3
Qual: Add dolibarrr to dict 2024-03-16 18:06:22 +01:00
Laurent Destailleur
75fae0f27d
Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
MDW
cb55fb0864
Remove PhanTypeMismatchPropertyProbablyReal exceptions in baseline 2024-03-16 14:56:55 +01:00
MDW
ee97747eb6
Qual: Update phan baseline with issue we're not fixing now 2024-03-16 13:52:53 +01:00
MDW
725e419a46
Qual: Enable PhanTypeMismatchReturn 2024-03-16 13:52:19 +01:00
MDW
7b53202f74
Qual: Enable detection of use of DeprecatedFunctions 2024-03-16 13:27:52 +01:00
Laurent Destailleur
a247b474d7
Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence
Fix some phan notifications with low occurrence
2024-03-16 11:48:10 +01:00
MDW
8a83388905
Qual: Enable several phan notifications 2024-03-16 00:00:25 +01:00
MDW
375e4d7ccf
Qual: Enable PhanTypeMismatchArgumentInternalReal 2024-03-15 23:41:17 +01:00
Laurent Destailleur
372c8445fd
Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
0ee6fd6bad
Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
b658beab99
Merge pull request #28872 from mdeweerd/fix/PhanTypeMismatchReturnProbablyReal
Fix & enable PhanTypeMismatchReturnProbablyReal
2024-03-15 15:24:31 +01:00
Laurent Destailleur
1a722fa436
Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
MDW
1af4e90027
Qual: enable PhanTypeMismatchDefault 2024-03-15 14:53:07 +01:00
MDW
c7ad91cfc0
Qual: Enable PhanTypeMismatchReturnProbablyReal 2024-03-15 14:20:58 +01:00
Laurent Destailleur
066565938c
Merge pull request #28812 from mdeweerd/fix/PhanTypeSuspiciousEcho
Fix & enable PhanTypeSuspiciousEcho
2024-03-15 11:02:33 +01:00
Laurent Destailleur
11c77c410b
Merge pull request #28864 from mdeweerd/fix/PhanUndeclaredTypeReturnType
Fix & enable PhanUndeclaredTypeReturnType
2024-03-15 11:01:11 +01:00
MDW
651b5a22eb
Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
ec6786ece3
Detect PhanTypeMismatchPropertyProbablyReal 2024-03-15 10:12:52 +01:00
MDW
3384a0b847
Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00