MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
2009c6f09a
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-31 17:30:32 +02:00
Laurent Destailleur
ee6779dbcf
Clean code
2024-08-31 15:08:17 +02:00
Laurent Destailleur
a59e933d59
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-22 14:47:00 +02:00
Laurent Destailleur
e631ce7475
Fix sanitizing dol_openinpopup
2024-08-22 14:46:10 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 03:05:02 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
8a4f550d64
Debug v20
2024-07-09 17:33:27 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
409bccb4f0
fix phan api_workstations.class.php ( #30169 )
...
* fix api_workstations.class.php
* Update api_workstations.class.php
* Update api_workstations.class.php
* Update api_workstations.class.php
* Update html.formwebsite.class.php
2024-06-27 16:39:15 +02:00
Christian Humpel
64f53fcc67
New: Add REST Api functionality for workstations ( #30154 )
2024-06-26 17:05:42 +02:00
atm-lena
6bb90034ff
llxHeader - BodyCss - webhook/webservice/workstation ( #29953 )
...
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr>
2024-06-09 11:49:02 +02:00
Frédéric FRANCE
1ff0e8a821
fix an old error ( #29850 )
...
* fix an old error
* fix OdfException is never thrown in the try block
* fix OdfException is never thrown in the try block
* fix Undefined array key "name"
* fix missing translation
* fix missing translation
* fix Undefined variable $lineid
* fix warnings
* fix upload dir
* fix phpcs
2024-06-08 16:59:40 +02:00
Laurent Destailleur
46b0bcefb7
Doc
2024-05-23 22:28:37 +02:00
Laurent Destailleur
66f4562300
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905
FIX Missing $param in hook call for list
2024-05-23 14:41:56 +02:00
Laurent Destailleur
629ccf9681
Merge branch 'FIX_Entity_on_workstation' of
...
github.com:ATM-Consulting/dolibarr into
ATM-Consulting-FIX_Entity_on_workstation
2024-05-23 13:02:07 +02:00
Adrien Raze
e5b5092549
FIX : Entities were not managed on workstation
2024-05-23 12:05:32 +02:00
Laurent Destailleur
458ffdb23e
css
2024-05-09 18:15:57 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
e3daa23949
Look and feel v20
2024-04-30 09:45:28 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Laurent Destailleur
7b0177a84d
Move to getDolGlobalString
2024-03-22 00:37:56 +01:00
MDW
c9d897ee35
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:52 +01:00
MDW
aeefca7e7e
Fix $arrayfields typing lost by dol_sort_array() by forcing the type
2024-03-20 23:29:48 +01:00
Frédéric France
dcc01e58e2
fix phpstan in workstation class
2024-03-20 08:46:16 +01:00
Frédéric France
a58eb10cea
fix phpstan in workstation class
2024-03-20 08:41:27 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
Laurent Destailleur
e994d6650f
Fix regression in GETPOST limit
2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1
Code simpler
2024-03-15 20:29:21 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
460d43cfbe
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:55:49 +01:00
Laurent Destailleur
74b8162d22
Merge pull request #28700 from mdeweerd/urlencode/fixuptype
...
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
...
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')
Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
b3aaa6c4e7
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:40:43 +01:00
MDW
23ac94ac49
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:40:41 +01:00
MDW
6551b752d6
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:40:39 +01:00
MDW
7d84a5ecf3
Fix: Ensure string type for urlencode()
2024-03-09 16:57:03 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
MDW
3d0a85608b
Qual: Fix and enable alias deprecation detection ( #28716 )
...
* Qual: Ignore some false positives for deprecated functions
# Qual: Ignore some false positives for deprecated functions
The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that
* Qual: Enable detection and fixing of internal deprecations
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Update codespell lines ignore list after format
# Qual: Update codespell lines ignore list after forma
Done using latest library, so also adds some exceptions that are needed
in the future;
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:34:18 +01:00
Laurent Destailleur
7866ee472b
QUAL Clean code around dol_eval use
2024-03-06 17:07:24 +01:00
Laurent Destailleur
c544efec7f
QUAL: Remove use of customurl filter. Must use the USF syntax.
2024-03-05 03:51:36 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int ( #28577 )
...
* all initAsSpecimen return int
* all initAsSpecimen return int
* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
04c560faa4
Fix warning
2024-03-01 01:52:40 +01:00
