MDW
11ed394b4b
Qual: Fix phan notices (supplier_proposal)
2025-02-18 14:16:49 +01:00
Laurent Destailleur (aka Eldy)
d01274ef4c
Fix phan
2025-02-07 11:28:13 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
...
# Qual: Fix getKanban phpdoc
Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur
940e42c1e4
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-01-27 01:30:34 +01:00
vmaury
cf0c04c6ee
Fix 31370 Pb with external account
2025-01-13 11:58:16 +01:00
Laurent Destailleur (aka Eldy)
b024b95948
Fix typo
2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7
FIX CVE-2024-55227 and CVE-2024-55228 CSRF when
...
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
2025-01-09 19:35:01 +01:00
Laurent Destailleur
6e9bbe42bb
Add code to make easier to test PDF generation with n lines of product
2024-11-21 19:40:52 +01:00
Lucas Marcouiller
1637319d24
fix php warning supplier proposal class ( #31872 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-11-16 00:08:41 +01:00
Laurent Destailleur
d0c14c6414
Prepare code for #24386
2024-11-07 03:45:28 +01:00
MDW
e7539f2e19
Qual: Fix notices in .lib.php files ( #31672 )
...
* Qual: Fix notices in .lib.php files
* Update wrapper.php
* Update availabilities_card.php
* Update index.php
* Update document.controller.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
MDW
67e9eaff46
Qual: Fix phan/phpstan notices in class files (part 2) ( #31523 )
...
* Qual: Fix phan notices in class files (part 2)
* Qual: Fix phan notices doleditor...events.class
* Qual: Fix phan notices defaultvalues...formprojet.class
* Qual: Fix notices formsetup...formwebsite.class
* Qual: Fix phan notices in class files (part 2)
* Qual: Fix phan notices doleditor...events.class
* Qual: Fix phan notices defaultvalues...formprojet.class
* Qual: Fix notices formsetup...formwebsite.class
2024-10-26 18:24:40 +02:00
Frédéric FRANCE
0b1d243a7a
add translations count ( #31398 )
2024-10-15 15:39:29 +02:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Laurent Destailleur
bf697f83eb
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-09-12 21:50:31 +02:00
MDW
76eaf8bd8d
Qual: Fix phan notices in classes related to class using getNextValue. ( #30925 )
...
* FIX 🛟 phan
* getToolTip() can take null for $coc
* Fix uninitialized vars & arg types
* PHPDoc typing, argument fixes
* PHPDoc typing, argument fixes for AdherentType
* PHPDoc typing, argument fixes for AdherentStats
* Update baseline to enable adherent notices
* Fix PHPDoc typing in api_members
* Minor bug fixes, typing
* PHPDoc api_subscriptions
* PHPDoc Societe
* Ignore empty foreach notice
* Add initialiser
* Categorie is string, old int mode is deprecated
* Fix missing initialisations
* Fix missing initialisations adherents/note
* Fix typing (cast), initialisation of var
* Fix initialisations
* Fix argument types
* Improve array PHPDoc type
* PHPDoc array type
* PHPDoc: Improve typing
* Correct argument type to getNomUrl
* Improve typing for timespent
* Fix typing for getNextValue args
* Improve typing
* Fix typing hints contrat/card
* Update baseline
* Fix typing
* Fix extraparams property typing
* Fix argument typing
* Qual: Correct covariant type
* Impove typing for timespent
* Remove exclusion no longer matched (level 6)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
John BOTELLA
3380115908
Fix v20 php8 patch002 ( #30931 )
...
* Fix PHP 8 notices, warninngs, fatal
* precommit
* fix php 8 errors
* use this db
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-12 21:11:45 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
Laurent Destailleur
b3b21d56b6
Fix doxygen
2024-08-07 02:49:38 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Frédéric FRANCE
c6d44671f5
clean date phpdoc ( #30221 )
2024-07-01 12:55:16 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Benjamin Falière
833780b84e
NEW(Supplier): Add classe_element_line property for supplier related classes ( #30060 )
...
* NEW(CommandeFournisseur): add proporty CommandeFournisseur:class_element_line
* Fix typo
* NEW(supplier): Add classe_element line property for supplier classes
---------
Co-authored-by: Benjamin Falière <benjamin.faliere@altairis.fr>
2024-06-19 19:51:25 +02:00
Mathieu Moulin
abcb1dad4b
Define CommonObject relation in CommonObjectLine classes ( #29956 )
2024-06-10 16:08:39 +02:00
Frédéric FRANCE
741e75ee47
add phpdoc ( #29832 )
...
* add phpdoc
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* add phpdoc
* fix phan
* fix phan
2024-06-04 14:46:54 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Frédéric France
5b1af95864
fix phpstan
2024-03-28 20:16:32 +01:00
MDW
911a2c05ad
Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate
2024-03-23 02:06:56 +01:00
MDW
15f38d472e
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:49 +01:00
Laurent Destailleur
b4a23a48f9
Update supplier_proposal.class.php
2024-03-20 12:41:11 +01:00
MDW
3327953f1a
Fix arg type to preg_match(),strlen() with cast + FIXME
2024-03-20 04:10:02 +01:00
MDW
c5479f4520
Fix: Update typing for qty as float
2024-03-19 20:37:38 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int ( #28577 )
...
* all initAsSpecimen return int
* all initAsSpecimen return int
* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Frédéric FRANCE
92103e2029
fix phpstan ( #28399 )
...
Property CommonObject::$fk_project (int) does not accept string.
2024-02-25 10:00:39 +01:00
MDW
8655d5a86b
QUAL Use phan to help detect new issues ( #27706 )
...
* Qual: Add phan flow
- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.
* Add directives to ignore false phan notices
* Qual: Add typing hints for extrafields TPL files
# Qual: Add typing hints for extrafields TPL files
Add typing hints for phan on view files
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:14:29 +01:00
Laurent Destailleur
1d6cbe1fda
Fix GETPOST use should be avoid in classes
2024-02-02 23:46:12 +01:00
Frédéric France
03e29c6960
fix param
2024-01-20 09:22:38 +01:00
Frédéric France
b3bcdeafe5
rename method
2024-01-18 18:55:53 +01:00
Frédéric FRANCE
d027f1b012
fix phpstan
2024-01-15 22:14:17 +01:00
Laurent Destailleur
40f4ef9285
Close #27496
2024-01-14 12:10:09 +01:00
MDW
342ab85195
Qual: Spelling htdocs/[q-z]* ( #27447 )
...
# Qual: Fix spelling htdocs/[q-z]*
Probably fixes a bug:
- htdocs/webservices/server_thirdparty.php
No other occurence of adress found.
-'adress'=>->adress,- +'address'=>->address,+
2024-01-12 17:18:52 +01:00
Laurent Destailleur
910a541c60
Clean code
2024-01-09 13:08:22 +01:00
Laurent Destailleur
4501872f17
Clean code with rector 2
2024-01-05 04:33:58 +01:00
Laurent Destailleur
7f5df80efd
Debug v19
2023-12-19 11:51:48 +01:00
Frédéric FRANCE
61b79fda17
avoid phpstan error with phpdoc
2023-12-06 15:46:39 +01:00
Laurent Destailleur
619155f65e
Fix with php-cs-fixer
2023-12-04 13:53:48 +01:00
Frédéric FRANCE
53c8a3acf8
clean phpdoc for phpstan ( #26905 )
2023-12-01 19:51:32 +01:00
