Laurent Destailleur
046166f483
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-14 21:38:12 +02:00
Laurent Destailleur
f4a76e5b73
Fix translation file header
2024-10-14 16:44:10 +02:00
MDW
f70c945931
Qual: Fix phan/stan notices ( #31271 )
...
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall
Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
Mohamed DAOUD
5cb2e23dcf
Enhance AJAX Functionality in Module Builder ( #31211 )
...
* add ajax page for modulebuilder
* Update myobject.php
* fix phan
* add phan suppress
* Fix phan case sensitive
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 20:51:08 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
MDW
0da4d51003
Qual: Fix multiple phan notifications ( #31151 )
...
* Qual: Fix notifications multiple files
# Qual: Fix notifications multiple files
Fixes to files with UnknownObject notices, fixing other
notices in these files as well
* Improve boxes typing
* Qual: Extend accepted types to reduce notices
* Fix type for GET/POST arguments of GETPOST* calls
2024-09-28 12:09:35 +02:00
Laurent Destailleur
b32225283d
Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop
2024-09-25 22:32:36 +02:00
Laurent Destailleur
e8c45ace3b
Clean code
2024-09-25 19:30:37 +02:00
Laurent Destailleur
6f30d2f187
Missing param
2024-09-25 14:04:24 +02:00
Laurent Destailleur
ae6e35cc84
Look and feel v21 enhancement on smartphone
2024-09-25 02:35:56 +02:00
Laurent Destailleur
fe193baaed
FIX Warning visible when it should not
2024-09-24 13:24:29 +02:00
Laurent Destailleur
950d749198
FIX Warning visible when it should not
2024-09-24 13:11:52 +02:00
Laurent Destailleur
8f54f06e12
FIX #31076 Bad position of hooks
2024-09-23 02:26:19 +02:00
Laurent Destailleur
053f799ef2
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-23 02:25:10 +02:00
Laurent Destailleur
74ad35dcac
FIX #31076 Bad position of hooks
2024-09-23 02:24:43 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan ( #31075 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
Laurent Destailleur
f00a07e564
FIX Translation of widget label into combo
2024-09-19 13:29:07 +02:00
Frédéric FRANCE
797bfb27e0
fix phpstan ( #30881 )
...
* fix phpstan
* fix phpstan
2024-09-09 02:28:35 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan ( #30860 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
bc21b973ca
Debug v20
2024-08-31 11:45:42 +02:00
Laurent Destailleur
a59e933d59
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-22 14:47:00 +02:00
Laurent Destailleur
e631ce7475
Fix sanitizing dol_openinpopup
2024-08-22 14:46:10 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
HENRY Florian
d551f200f2
new: when initHook() and restrictedArea() exists always execute first initHook() ( #30703 )
2024-08-20 23:32:43 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod ( #30661 )
...
* Qual: Fix PhanUndeclaredMethod cases
* Fix PhanUndeclaredMethod cases
* Qual: Remove PhanUndeclaredMethod exceptions
* Fix spelling "disacard"
* Improve phpdoc, add abstract method to trait for typing
* Improve phpdoc typing for PHanUndeclaredMethod
* Suppress phan notices for guarded AliasNbPages calls
* Fix return value for printFile stub
* Fix getting message from Exception
* Define dummy getAllByProducts(), typing for it.
* Fix typo in comment
* Qual: Better typing for apiService (phan)
* Test that the Generic OAuth Service is provided
* Qual: Fix getSqlArrayForStats typing
* Force modTcpdfbarcode
* Correct typing hint
* Set ModelePDFAsset typehint
* Fix ModelePDFUserGroup typing hint
* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php
* Fix write_file in ModelePDFStock*
* Update printsheet.php
* Adjust typing hint for barcode generator
* Update printsheet.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
MDW
b0087aaf61
Qual: Enable phan on modulebuilder ( #30652 )
...
* Allow null for buyer, and force '' for in printObjectLine(s)
* Allow null for Contact in show_actions_done
* Qual: Enable phan on modulebuilder
# Qual: Enable phan on modulebuilder
Most files of the modulebuilder template can be checked as regular files.
It will help improve the template
* Update baseline (enable modulebuilder notices)
* Add properties that are expected to exist on modules_boxes
* Qual: Ignore false positive (phan)
* Set phpdoc type to include null on formAddObjectLine
* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)
* Fix phpcs for intracom
* Make ModeleBoxes:showBox() signature match child class's
* Fix *box::showBox() phpdoc types
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-18 18:16:08 +02:00
Oliver Lippert
0a41d5eb2c
tell about delivery objecttype tabs ( #30662 )
2024-08-18 16:18:49 +02:00
Laurent Destailleur
72b37a2369
Fix phan
2024-08-18 00:01:45 +02:00
Laurent Destailleur
7ea04ab0af
Clean code
2024-08-17 23:59:08 +02:00
Laurent Destailleur
3114d1d13e
Clean code
2024-08-17 23:46:16 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
13d61527c9
Debug module intracommreport
2024-08-17 19:18:00 +02:00
Laurent Destailleur
31112fa467
Debug module intracommreport
2024-08-17 18:55:29 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
Frédéric FRANCE
32839b138b
fix phpstan level 5 ( #30565 )
...
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
* increase level for apstat
2024-08-13 23:16:09 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
d1f1c0aa57
Clean code - Fix phpstan warning
2024-08-03 13:44:38 +02:00
Laurent Destailleur
f002fb4ed1
Use the non deprecated function loadRights instead of getrights
2024-08-02 10:36:43 +02:00
Laurent Destailleur
cbc28b0afd
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-08-01 14:02:36 +02:00
Laurent Destailleur
269a8a2fa1
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-08-01 13:36:59 +02:00
Laurent Destailleur
faac9602f8
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-08-01 13:31:51 +02:00
MDW
46eb5f83c2
Qual: Updates for phpstan notices ( #30509 )
...
* Fix int<0> typing to int<0,0> for phpstan
* Fix phpdoc for phpstan
* Fix phpdoc for phpstan
* Qual: Several phpstan notice fixes
* Fix phpdoc
* Qual: totalpaid is never null, remove null test
* improve phpdoc typing
* Also return null to statisfy phpstan
* Allow null value for $var
* object->Object to make it meaningful
* Type EvalMathStack properties
* Comment out unused private methods (phpstan)
* Changes for phpstan (return values, phpdoc, code)
* Change order of tests for phpstan
* phpdoc object to Object for correct typing
* Typing hing for phpstan
* UPdate test for phpstan
* Change phpdoc position for phpstan
* Update phpdoc for phpstan
This needs further improvement
* Change $op to $ope to fix phpstan
* Update sqlite3.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 12:59:45 +02:00
Francis Appels
dc58a90a48
Fix modulebuilder MAIN_ODT_AS_PDF ( #30496 )
2024-07-31 15:35:15 +02:00
Laurent Destailleur
871e01d955
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 14:32:55 +02:00
Laurent Destailleur
09eaf38bd1
Fix phpstan
2024-07-31 14:31:29 +02:00
Laurent Destailleur
d2bd6a03ec
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 13:21:02 +02:00
Laurent Destailleur
2f7a252244
Fix warnings
2024-07-31 13:09:10 +02:00
Laurent Destailleur
038ce032e0
Fix tooltip on numbering modules
2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543
Fix tooltip on numbering modules
2024-07-31 12:14:39 +02:00
Lucas Marcouiller
a4908abc8a
New Main checkbox left column to manage this conf for each users ( #30439 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-26 05:01:26 +02:00
Laurent Destailleur
c9b92bb32d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-07-25 18:06:37 +02:00
Thibault Fiacre
7c9e6b1fb9
FIX lang output for sales representative on PDF ( #30469 )
2024-07-25 17:56:13 +02:00
Laurent Destailleur
74cbae2579
Code comment
2024-07-25 14:28:18 +02:00
Laurent Destailleur
5513b573b0
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-24 04:06:06 +02:00
Laurent Destailleur
8a257ac93f
Fix permission to edit email template - Debug v20
2024-07-23 02:12:46 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
8a4f550d64
Debug v20
2024-07-09 17:33:27 +02:00
Frédéric FRANCE
2707475a12
fix phpstan ( #30319 )
...
* fix phpstan
* fix phpstan expects int, false given ...
* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
29f223fd3c
fix checkFunctionArgumentTypes ( #30249 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Laurent Destailleur
253fdba882
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-02 23:11:21 +02:00
Laurent Destailleur
a75d6e6ffe
Finished the groupby experimental into project list
2024-07-02 18:46:20 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
3e750c2f0b
ignore more phan lines with phpstan ( #30135 )
...
* ignore more phan lines with phpstan
* fix
2024-06-23 17:46:34 +02:00
Laurent Destailleur
6a12de58ed
Introduce length of field in fields array
2024-06-23 13:24:26 +02:00
Laurent Destailleur
c936c4b4b4
Look and feel v20
2024-06-19 02:58:06 +02:00
Laurent Destailleur
a618bf2ae6
Debug v20
2024-06-18 09:54:11 +02:00
Laurent Destailleur
83f9854423
Doc
2024-06-10 16:12:22 +02:00
Mathieu Moulin
abcb1dad4b
Define CommonObject relation in CommonObjectLine classes ( #29956 )
2024-06-10 16:08:39 +02:00
Frédéric FRANCE
74806473ab
fix cti ( #29842 )
...
* fix cti odt asset
* comment unused code in template
* phpdoc
* fix unreachable code
* fix unreachable code
* fix not falsy
2024-06-05 14:55:07 +02:00
Frédéric FRANCE
d7a88a40a2
fix cti in odt template ( #29840 )
...
* fix cti in odt template
* fix cti in odt recruitment
2024-06-04 19:29:25 +02:00
Kusco
8e8fdccec7
#29103 Fix error in export part of the builder module ( #29835 )
...
In the builder module, suggestions are offered by default.
Just remove the comments for this to work.
Except for this line:
//$this->export_sql_end[$r] =' LEFT JOIN '.MAIN_DB_PREFIX.'competence_line as tl ON tl.fk_competence = t.rowid';
A "point" is missing before the "equal":
//$this->export_sql_end[$r] .=' LEFT JOIN '.MAIN_DB_PREFIX.'competence_line as tl ON tl.fk_competence = t.rowid';
The problem is the overwriting of part of the query, if we want to couple other tables.
2024-06-04 14:49:25 +02:00
Laurent Destailleur
dc024a1f18
Debug v20
2024-05-30 14:43:16 +02:00
Laurent Destailleur
48c5d9b0bc
Debug v20
2024-05-29 12:26:04 +02:00
Laurent Destailleur
66f4562300
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905
FIX Missing $param in hook call for list
2024-05-23 14:41:56 +02:00
Laurent Destailleur
21be37d308
Work on prototype for kanban grouped by type
2024-05-20 22:53:04 +02:00
sonikf
df6312d9db
fix: path and add missing comma ( #29651 )
...
* fix: add missing comma
* fix path
2024-05-11 20:45:52 +02:00
Laurent Destailleur
458ffdb23e
css
2024-05-09 18:15:57 +02:00
Laurent Destailleur
5b4d27e661
Debug v20
2024-05-08 00:23:25 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
0b9bd5408b
Debug v20: Encapsulate the feature using leaflet/geophp into a constant
...
MAIN_USE_GEOPHP. Fix webportal module.
2024-05-03 02:39:35 +02:00
Vaadasch
5865151eb3
NEW : Add option position['find'] to DolEditor ( #29546 )
...
* Add option position['find'] to DolEditor
* Add option position['find'] to DolEditor - fix spaces
* Add option position['find'] to DolEditor - fix spaces
* Add option position['find'] to DolEditor - fix semi-colon
* Add option position['find'] to DolEditor - exemples -> examples...
* Add option position['find'] to DolEditor - reviews
* Add option position['find'] to DolEditor - empty indent
---------
Co-authored-by: Vaadasch <me@local.here>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-01 18:04:18 +02:00
Laurent Destailleur
e3daa23949
Look and feel v20
2024-04-30 09:45:28 +02:00
Laurent Destailleur
2f7e9734bd
Debug v20
2024-04-23 00:38:56 +02:00
Laurent Destailleur
1946b92da8
Debug v20
2024-04-19 16:32:56 +02:00
Laurent Destailleur
57bb4cd7e4
Debug v20
2024-04-18 02:21:42 +02:00
MDW
bec5ff4749
Fix: Enforce/use int nature of BookKeeping(Line)::$piece_num, fix hooks typings ( #29298 )
...
* Fix: Enforce/use int nature of BookKeeping(Line)::$piece_num
* Fix typing in hookmanager class
* Improve DolHooksCollector phpdoc
* Fix PhanTypePossiblyInvalidDimOffset by testing index's existence
* Ignore PhanTypePossiblyInvalidDimOffset that phan can not detect
* Allow to be null, initialise instead of unset
2024-04-09 23:21:28 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
8a5d066d90
Doc
2024-04-07 12:15:17 +02:00
Frédéric FRANCE
7cf6a0821f
fix phpdoc for ismultientitymanaged ( #29245 )
...
* fix phpdoc
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
sonikf
a9bfe73e1a
Add recurring invoice triggers in module builder template ( #29208 )
...
* Add recurring invoice triggers
* Update interface_99_modMyModule_MyModuleTriggers.class.php
* remove BILLREC_CREATE
2024-04-05 16:34:39 +02:00
Laurent Destailleur
fffe74246c
Fix all short tables must use the setup for the number of rows
2024-04-03 15:30:10 +02:00
Laurent Destailleur
f03eb260de
Nicer combo of companies for external modules
2024-04-03 13:20:26 +02:00
Laurent Destailleur
9811ef1a78
Fix phpstan
2024-04-02 14:43:05 +02:00
Laurent Destailleur
990216b13f
NEW Api parameters are sanitized by the WAF, same code than GET/POST
2024-04-02 13:07:13 +02:00
Laurent Destailleur
87348ceac3
Fix missing $max
2024-04-02 12:01:23 +02:00
Laurent Destailleur
594da940fa
Sanitize input
2024-04-02 11:57:30 +02:00
Laurent Destailleur
b58e439a17
Clean use of $_POST
2024-03-28 21:29:02 +01:00
Laurent Destailleur
f598bcbd54
Look and feel v20
2024-03-24 16:36:08 +01:00
MDW
baaa7c721e
Fix PHPdoc typing ($cols, $phpmin)
2024-03-24 14:19:09 +01:00
Laurent Destailleur
3b17fceadb
Update modMyModule.class.php
2024-03-23 19:38:35 +01:00
Florian HENRY
b4f04dbaee
new: upgrade minimum version of dolibarr for module builder
2024-03-21 20:58:59 +01:00
Laurent Destailleur
e92d6230df
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/ticket/class/ticket.class.php
htdocs/ticket/list.php
htdocs/ticket/stats/index.php
2024-03-20 02:31:33 +01:00
Laurent Destailleur
607bc16351
Fix menu postion
2024-03-19 22:05:55 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
Laurent Destailleur
f9346a8022
Fix restore declaration to avoid to many uncompatibility problems.
2024-03-18 15:15:35 +01:00
Laurent Destailleur
b72b38f5d1
Doc
2024-03-18 15:03:41 +01:00
Laurent Destailleur
72d758e054
Doc
2024-03-18 14:56:54 +01:00
Laurent Destailleur
de58435ef1
FIX: if we stop for security purpose, we must exit a non zero value.
2024-03-16 23:08:15 +01:00
Laurent Destailleur
310b74960e
Fight against ucfirst to get a className.
2024-03-16 22:26:24 +01:00
Laurent Destailleur
90172fba83
Code simpler
2024-03-16 22:00:55 +01:00
Laurent Destailleur
93882871d7
Merge pull request #28901 from mdeweerd/spelling/dolibarr_keyword
...
Qual: Add dolibarrr to dict
2024-03-16 21:35:47 +01:00
MDW
5067a8bee9
Fix Dolibarr spellings
2024-03-16 18:11:10 +01:00
Laurent Destailleur
eececbe72b
More secured parameter for $tmpobjectkey
2024-03-16 17:34:58 +01:00
Laurent Destailleur
e994d6650f
Fix regression in GETPOST limit
2024-03-16 11:41:00 +01:00
Laurent Destailleur
2b9d5b7232
Clean code
2024-03-16 11:16:32 +01:00
Laurent Destailleur
0e07611344
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
Fix for #28785 and #28889
2024-03-16 11:09:24 +01:00
Laurent Destailleur
ea2eab434c
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-03-16 11:04:54 +01:00
Laurent Destailleur
97e4346913
Fix look and feel
2024-03-16 10:45:32 +01:00
Laurent Destailleur
28269b1a0a
Clean code for #28785
2024-03-15 20:26:22 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
Laurent Destailleur
6b48e09854
Debug
2024-03-14 16:49:29 +01:00
Laurent Destailleur
45a68ba612
Better error management
2024-03-13 20:17:26 +01:00
Laurent Destailleur
9e16016125
Merge pull request #28770 from mdeweerd/typing/fields
...
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
...
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')
Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
Laurent Destailleur
c458a46862
Fix warning
2024-03-12 03:46:00 +01:00
Laurent Destailleur
b9094fc00a
Fix warning
2024-03-12 03:37:21 +01:00
MDW
26e487d69e
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:52 +01:00
Laurent Destailleur
f32bf4b3a7
Fix join -> implode
2024-03-11 12:38:21 +01:00
Laurent Destailleur
4f5c400870
Fix missing search_all
2024-03-08 19:39:33 +01:00
Laurent Destailleur
fb16af02b4
Clean code. Move member type API in good file.
2024-03-08 11:00:19 +01:00
Laurent Destailleur
f45f1f6cfd
Fix separator block for modulebuilder
2024-03-07 15:00:08 +01:00
Laurent Destailleur
f00d3ff6dd
Fix route not complete
2024-03-07 14:57:41 +01:00
Laurent Destailleur
7866ee472b
QUAL Clean code around dol_eval use
2024-03-06 17:07:24 +01:00
Frédéric FRANCE
bc2f527e41
add phpdoc ( #28639 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
2024-03-05 17:11:46 +01:00
Laurent Destailleur
c544efec7f
QUAL: Remove use of customurl filter. Must use the USF syntax.
2024-03-05 03:51:36 +01:00
Laurent Destailleur
ce010a54c7
Clean code and prepare a more powerfull phpunit check for sql forging.
2024-03-05 00:22:12 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int ( #28577 )
...
* all initAsSpecimen return int
* all initAsSpecimen return int
* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
ef224a7a45
Clean code
2024-02-29 16:48:52 +01:00
Laurent Destailleur
4d10fe3bba
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-02-29 15:48:50 +01:00
Laurent Destailleur
049eaa1820
Compact code
2024-02-27 15:33:48 +01:00
Laurent Destailleur
0a345e37a0
Fix delete not used table
2024-02-27 13:01:42 +01:00
Laurent Destailleur
637ffa837f
Clean code
2024-02-22 13:28:18 +01:00
Laurent Destailleur
5167fe2a62
Fix complete for #28349
2024-02-22 11:32:21 +01:00
Laurent Destailleur
9d48dcbd3d
Fix phpstan
2024-02-22 01:32:55 +01:00
MDW
7dce4c354d
Fix: PHPUnit Object Test template ( #28299 )
...
# Fix PHPUnit Object Test template
Fix some typing issues discovered when reusing the template.
2024-02-20 01:29:47 +01:00
