Commit Graph

539 Commits

Author SHA1 Message Date
MDW
23785393a3
Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
26e487d69e
Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:52 +01:00
Laurent Destailleur
f32bf4b3a7 Fix join -> implode 2024-03-11 12:38:21 +01:00
Laurent Destailleur
fb16af02b4 Clean code. Move member type API in good file. 2024-03-08 11:00:19 +01:00
Laurent Destailleur
f45f1f6cfd Fix separator block for modulebuilder 2024-03-07 15:00:08 +01:00
Laurent Destailleur
f00d3ff6dd Fix route not complete 2024-03-07 14:57:41 +01:00
Laurent Destailleur
c544efec7f QUAL: Remove use of customurl filter. Must use the USF syntax. 2024-03-05 03:51:36 +01:00
Laurent Destailleur
ce010a54c7 Clean code and prepare a more powerfull phpunit check for sql forging. 2024-03-05 00:22:12 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
5167fe2a62 Fix complete for #28349 2024-02-22 11:32:21 +01:00
Laurent Destailleur
9d48dcbd3d Fix phpstan 2024-02-22 01:32:55 +01:00
Laurent Destailleur
1bd04a04f5 Update doc 2024-02-17 00:15:43 +01:00
Laurent Destailleur
75cdfcbf52 Fix if reffield does not exists 2024-02-15 18:08:38 +01:00
Frédéric FRANCE
5f1c679142
fix warning (#28177)
* fix warning

* clean properties

* clean properties
2024-02-15 13:59:19 +01:00
Laurent Destailleur
cdff5d7c91 FIX external module can cumulate return of arrays 2024-02-12 20:08:05 +01:00
Laurent Destailleur
d4296c2ffd Work on website templates from external modules 2024-02-09 17:54:57 +01:00
MDW
7b54824d49
Fix #28071 - New branch to fix bad merge (#28083)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Qual: Introduce getDataToShowPhoto to prepare generic code

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix missing trans

* Fix langs

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Remove useless files in web templates

* Clean code

* Fix duplicate translation key

* Fix duplicate translation key

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix duplicate key

* Fix $object

* Debug v19

* WIP SMSing

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP EMAILINGS_SUPPORT_ALSO_SMS

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP SMSing

* Debug the "validate" feature

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Clean code

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Enhance rector to fix empty($user->rights->modulex->perm1)

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Fix template to use v19 dev rules

* Fix use v19 dev rules

* Fix phpunit

* Debug v19

* Clean code

* Use rector to convert user->rights into user->hasRight

* Clean code

* Use rector to convert user->rights into user->hasRight

* Use rector to convert user->rights into user->hasRight

* Clean code

* Fix phpcs

* add editorconfig for sql files (#27999)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* add model_pdf field in llx_ticket-ticket.sql (#27996)

* add model_pdf field in llx_ticket-ticket.sql

* Update 19.0.0-20.0.0.sql

* Update 19.0.0-20.0.0.sql

* Improve wording in README (#27994)

* fix phpstan (#27989)

* fix phpstan

* Update UserRightsToFunction.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* Qual: Fix spelling/working in datapolicy translations (#28006)

# Qual: Fix spelling/wording in datapolicy translations

Fixed some spelling and wording in datapolicy translations.

* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)

htdocs/ticket/class/ticketstats.class.php	98	Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()

* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix user with readonly perm on email template must be able to read.

* Fix doc

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Better message

* Add missing fields in merge of thirdparty

* Debug v19 selection of ticket printer per terminal

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Use constant

* NEW: Adding a recipient on emails sent, change status to sent partialy.

* fix travis (#28052)

* fix travis

* Update partnership.class.php

* fix php doc (#28047)

* fix undefined array key (#28048)

* Add region and departament for Cuba (#28046)

* Update llx_10_c_regions.sql

Add Cuba Regions (id_country=77)

* Update llx_20_c_departements.sql

Add Provinces Cuba (id country=77)

* Find the typo (#28050)

* Find the typo

* clean code

* add last_main_doc field to product (#28045)

* add las_main_doc field to product

* add field fetch

* NEW Add Categorie filter for ActionComm (#28041)

* New Add Categorie filter for ActionComm

New Add Categorie filter for ActionComm

* Fix space errors

Fix space errors

* Fix space errors 2

Fix space errors 2

* Update cunits.class.php (#28056)

FIX: error SQL when creating a Cunit

* Update codespell-lines-ignore.txt to avoid PR merge conflict

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: thibdrev <thibault.drevet@gmail.com>
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com>
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com>
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com>
2024-02-09 15:58:49 +01:00
Laurent Destailleur
eb4f53665d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	.github/workflows/pre-commit.yml
	ChangeLog
	dev/tools/codespell/codespell-lines-ignore.txt
	htdocs/comm/mailing/card.php
	htdocs/contact/card.php
	htdocs/langs/en_US/admin.lang
	htdocs/modulebuilder/template/core/modules/mailings/mailinglist_mymodule_myobject.modules.php
2024-02-07 18:30:10 +01:00
Laurent Destailleur
7c88705f14 Fix template to use v19 dev rules 2024-02-04 16:05:02 +01:00
Laurent Destailleur
4aeda8d28d Fix escapeforlike/escape 2024-02-03 15:29:40 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
Laurent Destailleur
43d8e26023 Move API HTTP code from 401 to 403 2024-01-18 16:25:47 +01:00
Laurent Destailleur
936be12f44 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-15 17:21:26 +01:00
Laurent Destailleur
23e8b48c5b Fix phpstan 2024-01-15 14:02:11 +01:00
Laurent Destailleur
3ac7706a63 Clean code 2024-01-15 11:28:25 +01:00
Francis Appels
3d82778516
Fix modulebuilder fetchAll with extrafield (#27500) 2024-01-14 18:00:48 +01:00
MDW
a04f2bf4e7
Qual: Spelling fixes that newly appeared. (#27495)
* Qual: Spelling fixes that newly appeared.

# Qual: Fix spelling erros that appeared since the bulk updates.

These issues mostly appeared since the bulk updates (a few ones were postponed
to make sure no real spelling errors were missed.)

* Update modulebuilder.lib.php

* Update pdf_standard.modules.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-14 12:26:37 +01:00
MDW
39769482b1
Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Laurent Destailleur
cb2ebb1d56 Fix phpcs 2024-01-12 20:51:10 +01:00
Laurent Destailleur
f201692001 Fix phpstan 2024-01-12 19:50:22 +01:00
MDW
591306d7b1
Qual: Spelling htdocs/[l-o]* & htdocs/pa* (#27435)
# Qual: Fix spelling htdocs/[l-o]* & htdocs/pa*

Mostly comments, some local variables changed and translations to avoid
automatic fixes.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 18:06:50 +01:00
Laurent Destailleur
618a364064 FIX #27439 but using the opposite direction. int is bette as we can evolve to add a third value in a future. 2024-01-12 17:47:54 +01:00
Laurent Destailleur
e2f49c407f Clean sql request to use exist instead of left join 2024-01-09 10:44:50 +01:00
Fabian Heinz
b78632a20e
api fixes
According to [RFC2616](https://www.rfc-editor.org/rfc/rfc2616#section-10.2), APIs should return 2xx status codes if the request was correct.
The response should be status 200 with an empty result array.
2023-12-31 14:11:05 +01:00
Laurent Destailleur
7f5df80efd Debug v19 2023-12-19 11:51:48 +01:00
Laurent Destailleur
d92c65ad91 FIX infinite loop in API call/trigger by adding a caller 2023-12-15 12:15:33 +01:00
Laurent Destailleur
c3d569968f Doc 2023-12-11 14:59:09 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
1c9429643a Fix php-cs 2023-12-04 13:46:42 +01:00
Frédéric FRANCE
53c8a3acf8
clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
aeec2101e3 Clean log 2023-11-21 12:17:10 +01:00
Florian Mortgat
73524c2f81
[modulebuilder] FIX handling of the $filter parameter in fetchAll() method (#25931)
* FIX handling of the $filter parameter for fetchAll: the previous version can result in invalid SQL

* Remove #[AllowDynamicProperties] attribute from Conf class (cf. PR #25931)

* Ensure sql-building strings are detectably sanitized to avoid PR rejection
2023-11-03 23:01:57 +01:00
Laurent Destailleur
127de7e7d8 FIX On object validation, ecm index are not updated for uploaded files 2023-11-01 16:17:54 +01:00
Laurent Destailleur
74e1ec4099 FIX On object validation, ecm index are not updated for uploaded files 2023-10-31 19:28:11 +01:00
Laurent Destailleur
197f0a19ec NEW Add more param on fetch() to prepare perf optimization 2023-10-26 21:05:37 +02:00
Laurent Destailleur
a318031034 QUAL Standardize code. Renamed ID of user properties into ->user_xxx_id 2023-10-24 11:37:29 +02:00
Laurent Destailleur
0fbffea663 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-10-17 14:49:16 +02:00
Laurent Destailleur
15e927be31 FIX Bad name for trigger in HRM module 2023-10-17 14:46:51 +02:00
Laurent Destailleur
2ae5314a23 Fix warning 2023-10-14 16:34:28 +02:00
Laurent Destailleur
92ec85df26 Debug v19 2023-10-11 14:40:02 +02:00
Laurent Destailleur
6cd7ef77fc
Merge branch 'develop' into 13.0_fix_sellist_add_order_by_option 2023-10-06 01:42:22 +02:00
Laurent Destailleur
b0cc8d7b0d
Merge branch '18.0' into 13.0_fix_sellist_add_order_by_option 2023-10-05 21:25:19 +02:00
pascal
80f060c771 fix tab indentation 2023-09-26 18:43:25 +02:00
pascal
871f896962 implementation of properties filter 2023-09-26 18:04:48 +02:00
Laurent Destailleur
d02c615f40 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-09-16 15:14:22 +02:00
Laurent Destailleur
818b1193b1 Fix escapesql 2023-09-15 16:19:05 +02:00
Laurent Destailleur
2391a5da6f FIX Filter on partnership status
FIX Kanban view
2023-09-15 15:58:43 +02:00
Laurent Destailleur
91fa48199a Fix warnings 2023-09-10 17:41:22 +02:00
Laurent Destailleur
150de687bf Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-09-05 20:13:38 +02:00
Laurent Destailleur
f43ef55b26 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
Conflicts:
	htdocs/modulebuilder/template/class/myobject.class.php
	htdocs/modulebuilder/template/core/boxes/mymodulewidget1.php
	htdocs/modulebuilder/template/core/modules/modMyModule.class.php
	htdocs/modulebuilder/template/core/modules/mymodule/doc/doc_generic_myobject_odt.modules.php
	htdocs/modulebuilder/template/core/modules/mymodule/doc/pdf_standard_myobject.modules.php
	htdocs/modulebuilder/template/myobject_agenda.php
	htdocs/modulebuilder/template/myobject_list.php
2023-09-05 19:38:45 +02:00
Florian HENRY
e56fed15c5 fix travais 2023-08-28 14:12:06 +02:00
Laurent Destailleur
5d4f53046a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-08-27 18:18:34 +02:00
Laurent Destailleur
8fa06ccfa7 Fix empty and getDolGlobal... 2023-08-27 17:11:28 +02:00
Laurent Destailleur
4b20e90329 Fix remove warnings 2023-08-21 13:59:19 +02:00
HENRY Florian
b37ca67729
Update myobject.class.php
fix https://github.com/Dolibarr/dolibarr/pull/25633#discussion_r1299167338
2023-08-19 21:49:56 +02:00
Florian HENRY
e387e009bf fix: use of getDolGlobal in module builder template 2023-08-16 11:59:14 +02:00
Florian HENRY
83ff60a131 fix: use of getDolGlobal in module builder template 2023-08-16 10:44:01 +02:00
Florian HENRY
4a453d0805 fix: use of getDolGlobal in module builder template 2023-08-16 10:40:03 +02:00
Laurent Destailleur
28620c58b8 Clean code 2023-08-11 11:42:49 +02:00
Laurent Destailleur
b43ca2a0ad Clean code 2023-08-06 13:39:32 +02:00
Laurent Destailleur
7ce9bf6b23 Clean code 2023-08-05 15:44:28 +02:00
Laurent Destailleur
d4cda09794 Debug v18 2023-07-10 02:25:33 +02:00
Laurent Destailleur
5fd7bcaae9 Debug v18 2023-06-29 12:10:31 +02:00
Laurent Destailleur
31474d80f1 Doxygen 2023-06-19 00:52:43 +02:00
Laurent Destailleur
f90483cc09 FIX #25095 2023-06-16 03:50:24 +02:00
Florian HENRY
3624e0efe3 again check php 8 review 2023-06-09 11:02:46 +02:00
Florian HENRY
ce10c68d31 getDol rather than ->global 2023-06-08 22:38:11 +02:00
Frédéric France
5a018d715d use user hasRight 2023-06-06 00:05:02 +02:00
Laurent Destailleur
66393753c4 Clean code - fix warnings 2023-05-30 13:29:57 +02:00
Laurent Destailleur
5dd3f57a1e Debug v18 2023-05-11 13:11:21 +02:00
Laurent Destailleur
be835d63ed
Merge pull request #24635 from VMR-Global-Solutions/develop
API add / fix filter on extrafields in index()
2023-04-28 20:02:09 +02:00
VMR Global Solutions
926aa6fec7
API add / fix filter on extrafields in index()
Add / change in api_xxx.class.php files the ability to filter on extrafields when missing in the public functions index()
by changing the SQL query with the pattern 
" FROM ".MAIN_DB_PREFIX"xxxx AS t LEFT JOIN ".MAIN_DB_PREFIX."xxxx_extrafields AS ef ON (ef.fk_object = t.rowid)
2023-04-28 09:31:33 +02:00
Laurent Destailleur
46e3413e8a Fix tooltips 2023-04-27 15:55:21 +02:00
Frédéric FRANCE
53d2757a8f
clean code 2023-04-27 09:54:40 +02:00
Frédéric FRANCE
7760ba86da use isModEnabled 2023-04-18 20:33:36 +02:00
Laurent Destailleur
aea1f60c67 Debug v18 2023-04-10 01:46:30 +02:00
Laurent Destailleur
a4a014cfd5 Clean libelle into label 2023-04-08 15:08:55 +02:00
Laurent Destailleur
8898a1a432 Debug ajax tooltip 2023-04-03 19:51:40 +02:00
Laurent Destailleur
1e94959042 Debug v18 2023-03-27 10:00:12 +02:00
Laurent Destailleur
152bbeb90a Securize and enhance objectonoff for external modules 2023-03-21 18:27:32 +01:00
Laurent Destailleur
a92081cf43 Debug Kanban views 2023-03-07 22:04:40 +01:00
Laurent Destailleur
8bde9ce270 Look and feel v18 2023-03-07 20:03:04 +01:00
Laurent Destailleur
dd1a9d91fc
Merge pull request #24086 from lamrani002/apiForModule
NEW comment in api_mymodule for seperate methods
2023-03-02 13:35:18 +01:00
Lamrani Abdel
0d3a4d68b2 add comment in api_mymodule for seperate methods 2023-03-01 23:20:42 +01:00
Laurent Destailleur
12bd795afc Work on Kanban view 2023-03-01 20:13:21 +01:00
Laurent Destailleur
ed5c890769 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-02-25 20:12:48 +01:00
Laurent Destailleur
cbb6ca071a Fix #yogosha15157 2023-02-25 19:51:05 +01:00
Frédéric FRANCE
c1882425db fix tooltip 2023-02-15 22:26:16 +01:00
Frédéric FRANCE
06904246f8 clean code 2023-02-05 23:40:02 +01:00