Commit Graph

1360 Commits

Author SHA1 Message Date
MDW
891e11d692
Qual: Enable and fix phan notices for scripts
# Qual: Enable and fix phan notices for scripts

phpstan is already enable on scripts, so there is no reason to not
enable phan.
This enables phan and fixes the notices at the same time
2025-02-18 16:33:41 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
# Qual: Fix getKanban phpdoc

Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-02-05 00:40:06 +01:00
Laurent Destailleur (aka Eldy)
082e6a7676 Debug v21 2024-12-10 13:57:03 +01:00
Laurent Destailleur
0403f449c8 Doc 2024-12-06 20:31:32 +01:00
Kamel Khelifa
a467a8de38 Add two globale PAYMENTBYBANKTRANSFER_CUSTOM_LOCAL_INSTRUMENT et PAYMENTBYBANKTRANSFER_CUSTOM_CATEGORY_PURPOSE for modify CORE value to a custom value in sepa file (ex: CASH) 2024-12-06 15:13:21 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Laurent Destailleur
bc83d330b6 Debug v21 2024-11-25 03:16:30 +01:00
Laurent Destailleur
6e295687a1 Debug v21 2024-11-25 02:59:11 +01:00
MDW
3685032671
Qual: Fix phan notices (#31990) 2024-11-19 00:09:38 +01:00
Laurent Destailleur
2b19f6e065 Trans 2024-11-13 14:29:03 +01:00
Frédéric FRANCE
92ef950e6d
fix phpstan (#31761)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* hide new error with phpstan 1.12.9
2024-11-10 23:47:14 +01:00
Frédéric FRANCE
15490b292f
fix phpstan and fix CI (#31739)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-11-10 11:16:23 +01:00
Laurent Destailleur
27224afa9f Debug v21 2024-11-10 02:21:50 +01:00
Laurent Destailleur
46974bdf3f Debug v21 2024-11-10 02:19:35 +01:00
Laurent Destailleur
c7d0482f8d Debug v21 2024-11-10 01:59:46 +01:00
Laurent Destailleur
6db1a73f9e Debug v21 2024-11-10 01:47:19 +01:00
Frédéric FRANCE
0d7bc505d3
add phpdoc and clean phpstan baseline (#31702)
* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline
2024-11-06 19:39:46 +01:00
Laurent Destailleur
61e3838ab3 Code comment 2024-11-05 11:08:13 +01:00
Laurent Destailleur
10a457e2cc Debug v21 2024-11-05 10:40:07 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
78e6f8ad03 Avoid duplicate info 2024-11-04 11:37:53 +01:00
Frédéric FRANCE
1e062b10c6
Update bonprelevement.class.php (#31649) 2024-10-31 18:02:29 +01:00
atm-thomasb
8a3e845b5b
New RIB selector instead of default (#30899)
* Initial commit - adding new code

* backup, selector added

* NEW: column fk_iban in sql files

* changing the place of the selector

* fix: solved conflicts

* fix: reverted some extremely minor changes

* NEW_first_version_of_form

* TEST: removing chanbges on one file

* same test

* no idea how it's working

* FIX: button is working again

* First version of task working

* FIX: code cleanup to prepare for PR

* FIX: PR preparation part 2

* Revert "FIX: PR preparation part 2"

This reverts commit d11daa6da9.

* WIP added translated error for no iban found when creating bank transfert

* QUAL: simplifying readability of sql

* FIX: renaming fk_iban to fk_societe_rib

* WIP: new simplification of sql

* NEW: xml updated correctly

* FIX: wysiwig fixes

* FIX: PR preparation

* FIX: reverted default rib for llx_user

* FIX: last changes before standard PR

* Initial commit - adding new code

* backup, selector added

* NEW: column fk_iban in sql files

* changing the place of the selector

* fix: solved conflicts

* fix: reverted some extremely minor changes

* NEW_first_version_of_form

* TEST: removing chanbges on one file

* same test

* no idea how it's working

* FIX: button is working again

* First version of task working

* FIX: code cleanup to prepare for PR

* FIX: PR preparation part 2

* Revert "FIX: PR preparation part 2"

This reverts commit d11daa6da9.

* WIP added translated error for no iban found when creating bank transfert

* QUAL: simplifying readability of sql

* FIX: renaming fk_iban to fk_societe_rib

* WIP: new simplification of sql

* NEW: xml updated correctly

* FIX: wysiwig fixes

* FIX: PR preparation

* FIX: reverted default rib for llx_user

* FIX: last changes before standard PR

* FIX: resolved conflicts

* FIX: fixed automatic check warnings

* FIX: more check warnings fixed

* Update htdocs/compta/facture/prelevement.php

Co-authored-by: Florian Mortgat <50440633+atm-florianm@users.noreply.github.com>

* FIX: Added intval checks

* FIX: added escape

* FIX: forgot one entity

* FIX: added more escape for travis

* fix: removed an error handling that caused ci/cr conflicts

* fix: bonPrelevement create error that triggered when not error but empty result

* fix: added one space

---------

Co-authored-by: Florian Mortgat <50440633+atm-florianm@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-30 23:15:33 +01:00
MDW
b91c99b18a
Qual: Fix phan/phpstan notices in class files (part 3) (#31578)
* fix phpstan in conf class (#31630)

* fix phpstan

* fix phan

* Fix merge

* Qual: Avoid notification with typing hint

* Qual: Fix notices link.class

* Qual: Fix notices link..socialneetworkmanager.class and DoliDb->DoliDB

* Qual: Fix notices for link..utils.class

* Qual: Fix notices for db classes

* Update translate.class.php

* Update translate.class.php

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-29 22:44:47 +01:00
MDW
0ac595364b
Qual: Fix phan/phpstan notices in class files (part 1) (#31501)
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
Laurent Destailleur
3bc1d35236 QUAL The property ->domiciliation and ->propio on bank accounts has been
deprecated and replaced with property ->address and ->owner_name
2024-10-24 12:38:41 +02:00
Alexandre SPANGARO
29303d0390
NEW Prelevement - Use structured payment data for Belgium (#31383) 2024-10-14 12:00:09 +02:00
MDW
d7b2f95baf
Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
MDW
2d0b1de36f
Qual: Add codespell entries to catch some css typos (#31222)
# Qual: Add codespell entries to catch some css typos

Added some codespell entries based on the observed typos in css
tags
2024-10-03 19:36:59 +02:00
Laurent Destailleur
90f49fbd83 Try more complete fix for #31117 2024-09-28 13:05:24 +02:00
Frédéric FRANCE
e8aa8303aa
fix phpstan (#31162)
* fix phpstan

* fix phpstan
2024-09-28 11:16:26 +02:00
Laurent Destailleur
fbc5dd4822 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-26 19:36:09 +02:00
Frédéric FRANCE
64e7ccf5ef
fix phpstan (#31124)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-26 15:30:49 +02:00
Laurent Destailleur
041dd55cdc Fix warnings 2024-09-26 03:25:12 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
Laurent Destailleur
6d19f16367 FIX Missing picto on user link 2024-09-24 13:24:36 +02:00
Laurent Destailleur
fe193baaed FIX Warning visible when it should not 2024-09-24 13:24:29 +02:00
Laurent Destailleur
75f3978159 FIX Missing picto on user link 2024-09-24 13:14:07 +02:00
Laurent Destailleur
950d749198 FIX Warning visible when it should not 2024-09-24 13:11:52 +02:00
Laurent Destailleur
8007e6ff86 NEW Can set date of transmission in 1 click when validating SEPA
transfer file
2024-09-17 10:29:57 +02:00
Frédéric FRANCE
97b97c6665
fix phpstan (#30912)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-10 14:58:36 +02:00
Laurent Destailleur
1c5d759816 Doc 2024-09-06 14:26:44 +02:00
atm-thomasb
63c54a06f0
NEW: added column default_rib in llx_user_rib (#30850)
* NEW: added column

* NEW: Added the TODO requested feature

* FIX: changed default value to 0 instead of 1, see PR

* NEW: Updated TODO

* Update llx_user_rib.sql

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-06 14:10:23 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
c4c55b00fd Fix permissions tests 2024-08-31 18:38:16 +02:00
MDW
a8367a6cd8
Qual: Fix getNextValue related phan notices (part2) (#30752)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712)
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00