Commit Graph

633 Commits

Author SHA1 Message Date
Laurent Destailleur
940e42c1e4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-01-27 01:30:34 +01:00
Laurent Destailleur
bd7dd2c627
Merge branch '20.0' into fix_20_wrong_value_of_socid 2025-01-20 15:23:10 +01:00
vmaury
40e22cc40e Fix 31370 Pb with external account 2025-01-11 12:31:35 +01:00
vmaury
34409e8a4d Fix 31370 Pb with external account 2025-01-11 07:33:08 +01:00
Regis Houssin
d443446838 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into
fix_20_wrong_value_of_socid
2025-01-06 13:53:22 +01:00
Laurent Destailleur (aka Eldy)
81e64ed9a4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-12-17 16:59:13 +01:00
Laurent Destailleur (aka Eldy)
55c6feef8c Fix css 2024-12-17 10:15:32 +01:00
Laurent Destailleur (aka Eldy)
b34c0beddc Debug v21 - filter import id 2024-12-16 13:45:48 +01:00
Regis Houssin
3e3f9c755d FIX Check "$search_sale" only if it's an internal user 2024-12-02 12:10:39 +01:00
Laurent Destailleur (aka Eldy)
4e6d3217bc Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-12-02 01:58:06 +01:00
Gregor Ljubic
2ad3001ccb
Update list.php (#32165)
* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-12-01 23:17:37 +01:00
Frédéric FRANCE
15490b292f
fix phpstan and fix CI (#31739)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-11-10 11:16:23 +01:00
Laurent Destailleur
31f147622a The deprecated GET parameter "&sall=" has been removed, use now the
"&search_all=".
2024-11-07 12:26:42 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
MDW
0ac595364b
Qual: Fix phan/phpstan notices in class files (part 1) (#31501)
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
Laurent Destailleur
c70973c0c8 Merge v20 2024-10-19 14:44:55 +02:00
Laurent Destailleur
59829485c6 FIX duplicate answers in list when using global search on proposals 2024-10-17 23:16:18 +02:00
MDW
0c26110636
Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Laurent Destailleur
b180beba04 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-16 12:03:13 +02:00
Laurent Destailleur
697bf01970 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-16 12:01:04 +02:00
Laurent Destailleur
b0fe6a0b1f Merge v18 2024-09-16 11:56:23 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
HENRY Florian
d551f200f2
new: when initHook() and restrictedArea() exists always execute first initHook() (#30703) 2024-08-20 23:32:43 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices (#30537)
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 03:05:02 +02:00
Alex BORDARAUD
1983c09ba4
Update list.php (#30254)
* Update list.php

Added condition to include client code in the search when the global variable SOCIETE_ADD_REF_IN_LIST is set to 1.

- Modified the SQL query to include 's.code_client' in the search conditions.
- Added check for the global variable SOCIETE_ADD_REF_IN_LIST.
- If SOCIETE_ADD_REF_IN_LIST is 1, 's.code_client' is included in the search along with 's.nom' and 's.name_alias'.
- Ensured that 's.code_client' is searched separately only when SOCIETE_ADD_REF_IN_LIST is 1 and 'search_societe' is not defined.

* Update list.php

* Update list.php

* Update list.php

Refactor: Replace conf->global->SOCIETE_ADD_REF_IN_LIST with getDolGlobalString('SOCIETE_ADD_REF_IN_LIST')

* Update list.php

Simplified SOCIETE_ADD_REF_IN_LIST retrieval

Replaced conditional retrieval with getDolGlobalInt('SOCIETE_ADD_REF_IN_LIST') to simplify code and pass tests.
2024-07-16 14:54:36 +02:00
Frédéric FRANCE
6a77028b02
fix syntax error, fix phan (#30372)
* fix syntax error

* fix phpstan
2024-07-15 20:52:09 +02:00
Laurent Destailleur
147a8bfaee Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/adherents/subscription/list.php
	htdocs/categories/viewcat.php
	htdocs/contrat/card.php
	htdocs/contrat/list.php
	htdocs/eventorganization/conferenceorbooth_list.php
	htdocs/expedition/list.php
	htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Alexandre SPANGARO
128769811c
Add css bodylist on list (#30334)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-11 00:45:05 +02:00
Laurent Destailleur
8a4f550d64 Debug v20 2024-07-09 17:33:27 +02:00
Zephyriony
4170bd410c
NEW Opacity for finished lines (#30219)
* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-01 14:17:44 +02:00
Alexandre SPANGARO
96afcaa476
Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
HENRY Florian
b155370957
fix: #29909 (#29910)
* fix: #29909

* reveiw
2024-06-08 17:04:35 +02:00
Zephyriony
6c002184c5
Research for the public note field in propals (#29703)
* Research for the public note field in propals

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-05 14:59:20 +02:00
Laurent Destailleur
832aca30dc Debug v20 2024-05-29 22:19:52 +02:00
Laurent Destailleur
66f4562300 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905 FIX Missing $param in hook call for list 2024-05-23 14:41:56 +02:00
Anthony Berton
fffa30fdc8
FIX - Search user in where propal and order (#29374)
* FIX - INNER JOIN for search user

* Search in where no joint

* FIX - Propal

* FIX

* Update list.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-28 22:16:12 +02:00
Laurent Destailleur
14afdf6b0e Fix regression on GETPOSTINT 2024-04-03 17:50:24 +02:00
Laurent Destailleur
fffe74246c Fix all short tables must use the setup for the number of rows 2024-04-03 15:30:10 +02:00
Frédéric France
7a7b1953ed
fix phpstan 2024-03-28 20:34:33 +01:00
MDW
7afeeb120d
Fix arguments to price() 2024-03-27 10:21:22 +01:00
Christophe Battarel
feaa2e5ba3 fix conflict 2024-03-19 10:55:59 +01:00
Laurent Destailleur
a6926c29c0
Merge pull request #28778 from fappels/develop_fix_delivery_note
Fix shipping is not a delivery_note (is sub module of shipping)
2024-03-12 14:53:51 +01:00
Laurent Destailleur
74b8162d22
Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
Francis Appels
7ff68a5819 Fix shipping is not a delivery_note (sub module of shipping) 2024-03-12 11:07:18 +01:00
MDW
dbfb1180ee
Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
4fa993fe8a
Fix: Ensure string type for urlencode() 2024-03-09 16:57:05 +01:00
MDW
d846044e38
Fix: $form argument to price() must be int (#28699)
* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0
2024-03-08 21:30:04 +01:00
HENRY Florian
4fcbdf15ab
fix: better inner join than comma for hook printFieldListFrom after (#28681)
* better inner jion than comme for hook after

* better inner jion than comme for hook after

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 16:49:41 +01:00