Commit Graph

686 Commits

Author SHA1 Message Date
Laurent Destailleur (aka Eldy)
c4f52d0484 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-02-04 22:51:31 +01:00
Laurent Destailleur (aka Eldy)
66dc3e810a Debug v21 2025-02-04 15:06:28 +01:00
MDW
2696c9a107
Fix ci phan/phpstan notices
# Fix ci phan/phpstan notices

Fix most notices, except undefined fk_website in SocieteAccount
as it is not clear if that is supposed to be a property there
(more specifically, that it is set).
2025-01-27 13:21:30 +01:00
Frédéric France
45042afe4b
fix phpstan branch 21 2025-01-25 09:04:43 +01:00
Laurent Destailleur (aka Eldy)
e9e7b85410 Debug v21 - pb holiday view into agenda 2025-01-24 21:20:20 +01:00
Laurent Destailleur (aka Eldy)
0932c2e492 Debug v21 2025-01-24 17:28:10 +01:00
Laurent Destailleur (aka Eldy)
8243c016e8 Debug v21 2025-01-03 19:52:56 +01:00
Laurent Destailleur (aka Eldy)
113a59a135 Debug v21 2025-01-03 19:50:38 +01:00
guthub
e071263718 try fixing phpstan 2025-01-03 14:43:30 +01:00
guthub
8ba1dcf16c disable checks on "filtert" (default does not allow bookcal from other entities)
debug/security : add check on entites for bookcals
2025-01-03 13:46:13 +01:00
VESSILLER
a0b77c7ffa Fix phpstan for color on assigned event 2024-12-30 13:41:18 +01:00
VESSILLER
7278b7f15a Fix phpstan for color on assigned event 2024-12-30 13:39:39 +01:00
Laurent Destailleur (aka Eldy)
86d41a8a23 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-12-28 18:07:00 +01:00
Florian HENRY
c4255f6a8c fix: warning in monthly agenda when user have no color and AGENDA_NO_TRANSPARENT_ON_NOT_BUSY=1 2024-12-24 12:58:46 +01:00
Florian HENRY
d4edb471a8 fix: warning in monthly agenda when user have no color and AGENDA_NO_TRANSPARENT_ON_NOT_BUSY=1 2024-12-24 11:57:59 +01:00
Laurent Destailleur (aka Eldy)
ff2aa10145 Debug v21 2024-12-18 21:35:52 +01:00
Frédéric FRANCE
01297eeb86
fix phpstan (#32188)
* fix phpstan

* fix typos

* add phpdoc

* cut long line
2024-12-01 23:15:27 +01:00
Laurent Destailleur
1386d8c388 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-11-19 04:21:29 +01:00
Expresion
cd7a6e6de0
Fix php8 warnings in agenda module (#31834)
* Update index.php

Fix: avoid php8 warnings in the agenda module

* Update index.php

Fix: php8 warnings in agenda module
2024-11-15 14:13:46 +01:00
MDW
56dc321665
Qual: Fix phan notices (in order of appearance) (#31768)
* Qual: Fix phan notices (in order of appearance)

* Qual: Fix phan notices (in order of appearance)/2
2024-11-12 00:35:14 +01:00
MDW
9ec4618199
Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
EnjoyFelix
9d67bc3428
Check if the society module is enabled before limiting the result in the agenda (#31654)
Co-authored-by: Elisée Chemin <elisee.chemin@tetras-libre.fr>
2024-10-31 18:43:18 +01:00
Laurent Destailleur
e149f8ba6c Debug v21 2024-10-27 02:40:58 +01:00
Laurent Destailleur
ff4344d5c8 Clean code 2024-10-24 01:12:58 +02:00
Laurent Destailleur
622a296d0e Look adn feel v21 2024-10-17 22:20:39 +02:00
Laurent Destailleur
08a670a32c Fix filter on type of event 2024-10-01 12:37:03 +02:00
Laurent Destailleur
072b3e7022 Fix empty value on combo to select types 2024-10-01 12:29:59 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Frédéric FRANCE
97392965e1
fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
Frédéric FRANCE
4c51d61fc5
fix ignored phpstan (#30644)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-15 16:55:13 +02:00
Laurent Destailleur
150e162022 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-13 18:22:59 +02:00
Laurent Destailleur
30f9215846 Debug v20 2024-07-13 17:58:47 +02:00
Alexandre SPANGARO
96afcaa476
Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Laurent Destailleur
a8a48c3315 Debug v20 - fix css 2024-06-24 16:20:01 +02:00
Laurent Destailleur
b45a322d25 Debug v20 2024-06-21 19:58:38 +02:00
Laurent Destailleur
a51b2cc766 Fix html 2024-06-07 18:48:45 +02:00
Laurent Destailleur
1e3b2c6a7c Try to fix GETPOSTINT regressions 2024-04-19 13:34:48 +02:00
MDW
bc5e5b67af
Qual: Update phan baseline (#29300)
* Qual: Update phan baseline

* Init variable to ensure it is defined

* Init $module_part to ensure it is defined

* Init $modulepart to ensure it is defined

* phpdoc typing for getNetNeeds and getNetNeedsTree

* Enforce type for phan

* Initialise  $massactionbutton so that it is defined

* phpdoc: improve typing

* Encore character_set value is string (for typing)

* fixup! Qual: Update phan baseline

* Fix duplicate code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-12 01:06:52 +02:00
Laurent Destailleur
fae202a610 Sec Possible html injection by corrupting external ICS links. 2024-04-05 13:26:59 +02:00
Laurent Destailleur
7c5b2dae56 Fix GETPOSTINT 2024-04-05 13:09:32 +02:00
Laurent Destailleur
2947287e3f Look and feel v20 2024-04-03 16:22:16 +02:00
MDW
71f3637a8b
Qual: actioncom - phpdoc typing, activate deprecationhandler for libelle
# Qual: actioncom - phpdoc typing, activate deprecationhandler for libelle

Fix several phan notices, activation deprecationhandler for libelle
2024-04-02 02:34:02 +02:00
MDW
69b64d30f5
Fix arg type to urlencode with cast 2024-03-20 04:10:07 +01:00
Laurent Destailleur
2b93caa7e7 Debug v20 2024-03-20 00:47:24 +01:00
Laurent Destailleur
71c833b3a2 FIX Title of event no visible on calendar 2024-03-20 00:40:58 +01:00
Laurent Destailleur
dad22a455b NEW Show error on ical parse 2024-03-20 00:38:10 +01:00