Commit Graph

648 Commits

Author SHA1 Message Date
Laurent Destailleur
ec42ad7804 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-12 00:46:02 +02:00
Laurent Destailleur
da577e8a24 Debug look and feel v20 2024-06-12 00:45:23 +02:00
Frédéric FRANCE
7d300e0b4b
Token csrf level 3 (#29980)
* add token csrf level 3

* add token csrf level 3
2024-06-11 01:04:33 +02:00
Laurent Destailleur
8971c8efac Exclude phan rule 2024-06-03 21:30:25 +02:00
Laurent Destailleur
ed212d0e84 Fix errormessage 2024-05-31 15:57:03 +02:00
Laurent Destailleur
82908a30eb Clean phan warnings 2024-05-30 13:37:17 +02:00
Frédéric FRANCE
2f16e2347c
fix phan (#29778)
* fix phan

* Update global.inc.php

* Update style.css.php
2024-05-28 23:53:06 +02:00
Laurent Destailleur
b5b87b9811 Increase memory 2024-05-26 15:45:54 +02:00
Laurent Destailleur
44fda7fa68 Optimize image file size 2024-05-22 01:00:51 +02:00
Laurent Destailleur
a8e777993b Rename scripts 2024-05-22 00:39:22 +02:00
Laurent Destailleur
4b5b4c4e1a Clean some expected warnings 2024-05-13 12:49:14 +02:00
Laurent Destailleur
130c2e2a8f Clean code 2024-05-13 11:27:56 +02:00
Frédéric FRANCE
933e87ca81
Update codespell-dict.txt (#29644)
* Update codespell-dict.txt

* WYSIWYG

* phan
2024-05-10 12:34:08 +02:00
Laurent Destailleur
d523cb24e6 Disable useless phan warnings 2024-05-10 11:48:27 +02:00
MDW
2115980560
Qual: Fix Phan notices in CommonObject (#29354)
* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* Correct typing for showInputField to be the same as parent class

* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* fixup! Correct typing for showInputField to be the same as parent class
2024-05-02 19:33:51 +02:00
Laurent Destailleur
95467db0c7 Fix RSS 2024-04-30 21:14:53 +02:00
Laurent Destailleur
eda839a49a Fix RSS 2024-04-30 21:13:53 +02:00
Laurent Destailleur
679e06048c Fix RSS 2024-04-30 21:12:21 +02:00
Laurent Destailleur
5890e715bf Fix RSS 2024-04-30 21:02:02 +02:00
Laurent Destailleur
19afa4bb03 Fix RSS 2024-04-30 20:44:38 +02:00
Laurent Destailleur
bf8e25c41f Fix security rss file 2024-04-30 19:11:30 +02:00
Laurent Destailleur
dbb9ae1667 Log 2024-04-30 19:00:11 +02:00
Laurent Destailleur
26a0732fb9 Use PHPSTan level 4 2024-04-30 08:35:45 +02:00
Laurent Destailleur
1af7ad923c Fix phan 2024-04-28 21:56:41 +02:00
Laurent Destailleur
29b6d6b918 Add phpstan version in report 2024-04-28 16:20:44 +02:00
Frédéric FRANCE
26da44e254
fix phpstan (#29431)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* remove params not used

* add WARNING
2024-04-27 12:45:50 +02:00
Laurent Destailleur
2de1287afd Make CTI less paranoiac to avoid alert at any code change 2024-04-27 00:47:45 +02:00
Laurent Destailleur
ca65e9a333 QUAL the config_extended of phpstan will be kept on apstats only for the
moment: Too many CTI error not related to PR.
2024-04-24 21:44:58 +02:00
Laurent Destailleur
a669c3d3fa Disable PhanUndeclaredGlobalVariable 2024-04-24 20:56:41 +02:00
Laurent Destailleur
85b4077d0d Clean code 2024-04-24 20:35:36 +02:00
Laurent Destailleur
5166eee88c Clean code 2024-04-24 20:29:37 +02:00
Laurent Destailleur
7712a80c55 Fix phpstan 2024-04-24 16:48:05 +02:00
Laurent Destailleur
51c233e2bf Add branch name of security fixes 2024-04-23 12:55:21 +02:00
Laurent Destailleur
caa0004622 Fix report of branches 2024-04-23 12:27:01 +02:00
Laurent Destailleur
d3f4b146b2 NEW Try to add branches into apstats security report 2024-04-23 11:50:10 +02:00
Laurent Destailleur
3aa2875532 Fix url_root param 2024-04-22 15:02:43 +02:00
Laurent Destailleur
bce2575309 Add image to RSS feed 2024-04-22 13:57:12 +02:00
Laurent Destailleur
90201c508a Alert on last 3 month 2024-04-18 17:40:44 +02:00
Laurent Destailleur
9bb1fe6600 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-18 17:39:34 +02:00
Laurent Destailleur
bd3077ce67 Fix for smartphone 2024-04-18 17:38:33 +02:00
MDW
090970ed4f
Fix #29359 Add exception for contributor email (#29394) 2024-04-18 15:43:59 +01:00
MDW
da9fd874bc
Qual: Fix or ignore functions.lib.php phan notices (#29344)
* Fix: LogHandler parent class, implements interface & provides $code

* Fix: functions.lib phan notices

* Fix phan notifications

* Match expected DebugBar signature - rename getRenderer

* Call the correct renderer method for the DebugBar

* Use correct key type to access array

* Ignore notices

* Update functions.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-14 04:46:33 +02:00
MDW
bc5e5b67af
Qual: Update phan baseline (#29300)
* Qual: Update phan baseline

* Init variable to ensure it is defined

* Init $module_part to ensure it is defined

* Init $modulepart to ensure it is defined

* phpdoc typing for getNetNeeds and getNetNeedsTree

* Enforce type for phan

* Initialise  $massactionbutton so that it is defined

* phpdoc: improve typing

* Encore character_set value is string (for typing)

* fixup! Qual: Update phan baseline

* Fix duplicate code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-12 01:06:52 +02:00
Laurent Destailleur
6fcec74fed Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-11 22:58:17 +02:00
Laurent Destailleur
0a3f66c6c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	dev/tools/codespell/codespell-ignore.txt
	htdocs/admin/system/security.php
	htdocs/core/class/commondocgenerator.class.php
	htdocs/core/menus/standard/eldy.lib.php
	htdocs/product/fournisseurs.php
2024-04-11 22:57:43 +02:00
MDW
e171e8e7ef
Qual: Fix all active phan notices in html.form.class.php (#29316) 2024-04-11 19:14:46 +02:00
Laurent Destailleur
efaccbc519 Remove duplicate graph 2024-04-10 01:50:29 +02:00
Laurent Destailleur
89c9651fde Fix example of security options 2024-04-09 15:31:13 +02:00
Laurent Destailleur
345a315b50 Fix example of security options 2024-04-09 15:29:43 +02:00
Laurent Destailleur
39491976e1 Fix title 2024-04-08 19:26:37 +02:00
Laurent Destailleur
b6822272b3 Look and feel 2024-04-08 16:37:33 +02:00
Laurent Destailleur
f1a3df108f Fix thumbs replace by opencollective 2024-04-08 14:59:21 +02:00
Laurent Destailleur
3215fa1184 Try to add stats fro ossinsight 2024-04-08 14:30:44 +02:00
Laurent Destailleur
ea1c9ad11d Fix grouping of security alerts 2024-04-08 14:00:13 +02:00
MDW
4d496209ce
Qual: Phan/apstats should not be using the standard baseline (#29267)
# Qual: Phan/apstats should not be using the standard baseline

Fix to get apstats reporting on the technical debt.  The 'baseline.txt'
is for the ci regression.  The code is changed to allow a
'baseline_extended.txt' which should not be generated, only hand-crafted
2024-04-07 15:02:00 +02:00
MDW
bbde552979
Qual: Enable Phan Rules and update baseline (#29255)
* Fix script generating trailing whitespace

* Add nusoap as a stub for better analysis

* Qual: Return type for fetch_name_optionals_label to fix phan message

* Qual: Enable Phan Rules and update baseline

# Qual: Enable Phan Rules and update baseline

This enables all of the rules that are currently also
enabled for cti, but sets the baseline to ignore the
exceptions already present.
This will help detect exceptions added by code modifications
if the rule is not ignored for the given file.
2024-04-07 11:55:39 +02:00
Laurent Destailleur
fa43938f76 Fix merge same title of security issue 2024-04-07 11:46:12 +02:00
Laurent Destailleur
d0c7c7f2c7 Add CR on RSS feed of apstat 2024-04-05 15:51:41 +02:00
Laurent Destailleur
e9857d5473 Try new line in description of rss 2024-04-05 15:49:52 +02:00
Laurent Destailleur
5702c31110 Typo 2024-04-05 15:47:25 +02:00
Laurent Destailleur
f12826a952 Add link to securities 2024-04-05 15:43:43 +02:00
Laurent Destailleur
0d5b81796f Fix escape 2024-04-05 15:34:30 +02:00
Laurent Destailleur
5d0125870d Add link into rss 2024-04-05 15:32:46 +02:00
Laurent Destailleur
773fcd8f06 Fix rss 2024-04-05 15:04:18 +02:00
Laurent Destailleur
4ef9a2c0f5 Fix rss 2024-04-05 15:01:59 +02:00
Laurent Destailleur
50dfa79a43 Fix warning 2024-04-05 15:00:21 +02:00
Laurent Destailleur
5e24b6ef70 Fix rss 2024-04-05 14:56:59 +02:00
Laurent Destailleur
79deb2bc3a NEW Add a link to add a website category in edit page properties 2024-04-05 14:45:34 +02:00
Laurent Destailleur
4694b4e1b4 Worl on CSS generation 2024-04-05 14:11:34 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
d8d41cefbe Enhance security fixes 2024-04-05 10:59:40 +02:00
Laurent Destailleur
ba25317a97 Exclude PhanDeprecatedProperty for the moment 2024-04-05 10:22:01 +02:00
Laurent Destailleur
bec30610d9 Add link to apstats 2024-04-03 19:23:53 +02:00
MDW
24e48998ce
Add nempty to spelling 2024-03-27 10:18:42 +01:00
MDW
1c9c665b0b
Update baseline (improved) 2024-03-27 10:18:41 +01:00
MDW
6e5841b13d
Add checks on checkVal, price2num and GETPOSTFLOAT arguments 2024-03-27 10:18:41 +01:00
MDW
a703ea1092
Add checks on dol_(mktime|now|print_date) + avoid duplicate phan conf 2024-03-27 10:18:39 +01:00
MDW
88c2d7e34e
Add spelling for shippin 2024-03-27 10:18:24 +01:00
MDW
fc43b5a252
Ignore PhanParamTooMany for adherents/admin/member.php
# Ignore PhanParamTooMany for adherents/admin/member.php

Ignore PhanParamTooMany for adherents/admin/member.php for passing CI;
The problem pre-exists and can be fixed later.
2024-03-27 10:18:14 +01:00
MDW
aba83e9e42
Add function definitions to stub 2024-03-27 10:18:11 +01:00
Laurent Destailleur
8bcfefe42f
Update config_fixer.php 2024-03-24 16:39:25 +01:00
Laurent Destailleur
414c51d631
Update config_extended.php 2024-03-24 16:38:51 +01:00
Laurent Destailleur
d78bafe602
Update config_extended.php 2024-03-24 16:38:21 +01:00
Laurent Destailleur
c43bb3d52c
Update config.php 2024-03-24 16:37:21 +01:00
MDW
a1ae115757
Set cache_codes global type 2024-03-24 15:40:25 +01:00
MDW
34416d9723
Qual: Enable PhanNonClassMethodCall 2024-03-24 15:06:59 +01:00
MDW
02960415cb
Fix global typing of menumanager as MenuManager 2024-03-24 11:03:22 +01:00
MDW
04b3ed0c7e
Fix extrafeild typo 2024-03-24 11:03:03 +01:00
MDW
79a8533f53
Qual: Enable PhanTypeInvalidPropertyName 2024-03-24 11:03:02 +01:00
MDW
2a13f7134c
Qual: Add extra phan stubs fixing PhanUndeclaredClassMethod 2024-03-23 14:29:54 +01:00
MDW
30b7ae336f
Qual: Enable dev/tools/phan/config.php 2024-03-23 13:14:35 +01:00
MDW
09b931e8fc
Qual: Enable PhanUndeclaredClassProperty 2024-03-23 03:19:04 +01:00
MDW
f96819398f
Add stub for multicompany 2024-03-23 03:19:03 +01:00
MDW
27091da3f3
Qual: Enable lidLeftOperandOfNumericOp 2024-03-23 02:06:57 +01:00
MDW
5c073dfb6e
Qual: Enable PhanTypeInvalidRightOperandOfAdd 2024-03-22 09:52:42 +01:00
MDW
b53d322f1b
Add exception for PhanTypeInvalidRightOperandOfAdd to baseline because issue to handle later 2024-03-22 09:52:34 +01:00
MDW
b8c16af0a3
Qual: Enable PhanTypeInvalidLeftOperandOfAdd 2024-03-22 09:51:38 +01:00
MDW
3908b4df9d
Qual: Enable PhanTypeInvalidLeftOperandOfBitwiseOp (all fixed) 2024-03-21 13:44:54 +01:00
MDW
6bfdc4655f
Disable ignores phan's baseline.txt (fixed) 2024-03-20 21:58:43 +01:00
MDW
9b146f3fe1
Fix restler stub ApiMethodInfo typing 2024-03-20 04:10:11 +01:00
MDW
a69dcc9c5a
Qual: Enable PhanTypeMismatchArgumentSuperType 2024-03-20 04:09:19 +01:00
MDW
390d164f82
Qual: Ignore PhanTypeMismatchArgumentNullableInternal 2024-03-20 04:09:18 +01:00
MDW
6413341c96
Qual: Enable PhanTypeMismatchArgumentInternal 2024-03-20 04:09:17 +01:00
MDW
a094ad38fc
Fix spelling (using beta codespell)
# Fix spelling (using beta codespell

New spelling fixes - ignoring thirdparty which should be either third-party
or third party.
2024-03-20 00:35:01 +01:00
MDW
04d7142463
Disable HTML plugin (detects HTML in PHP files)
# Disable HTML plugin (detects HTML in PHP files)

These messages are not really useful for dolibarr.
2024-03-19 18:09:19 +01:00
MDW
c0e8e053b8
Fix port arg to count by adding typing information 2024-03-19 02:59:09 +01:00
MDW
cd3ea72f96
Qual: Disable global variable suggestion for $website 2024-03-19 02:44:07 +01:00
MDW
3c968477cb
Change type of global $website to string 2024-03-19 02:44:04 +01:00
MDW
921431dbdc
Qual: Enable PhanTypeSuspiciousStringExpression 2024-03-19 02:44:03 +01:00
Laurent Destailleur
29a858aa68
Merge pull request #28924 from mdeweerd/fix/whitespace
Fix trailing whitespace + format code + minor spelling + enable checks
2024-03-19 02:14:13 +01:00
Frédéric FRANCE
65fcc53519
Merge branch 'develop' into phpstanphpstan 2024-03-18 23:47:59 +01:00
Frédéric France
eb8014c001 Merge remote-tracking branch 'upstream/develop' into phpstanphpstan 2024-03-18 17:50:42 +01:00
Frédéric FRANCE
a9cabe6fe4
Update codespell-dict.txt 2024-03-18 16:39:49 +01:00
MDW
d2568a0878
Qual: Enable PhanUndeclaredVariableAssignOp 2024-03-18 13:12:53 +01:00
Frédéric France
21d0cc9470 Merge remote-tracking branch 'upstream/develop' into phpstanphpstan 2024-03-17 22:05:01 +01:00
Frédéric France
09a953d18f fix phpstan 2024-03-17 22:04:10 +01:00
MDW
686facd74d
Fix PhanPluginWhitespaceTrailing + format code + minor spelling 2024-03-17 21:35:08 +01:00
MDW
aa6c20bf0d
Qual: Enable PhanPluginWhitespaceTrailing 2024-03-17 21:35:07 +01:00
Laurent Destailleur
bb0e18deae
Merge pull request #28922 from mdeweerd/fix/printf
Fix & enable Phan printf checks
2024-03-17 21:08:26 +01:00
MDW
7a4f5ec4f8
Qual: Enable some low occurence notifications 2024-03-17 20:12:27 +01:00
MDW
aa5aa2bf26
Add one more index to the theme_datacolor 2024-03-17 19:49:10 +01:00
MDW
d73886281c
Qual: Set typing for global 2024-03-17 18:56:44 +01:00
MDW
81d5f30466
Qual: Enable PhanPluginPrintfIncompatibleArgumentType 2024-03-17 18:56:43 +01:00
MDW
4232713e96
Qual: enable PhanPluginPrintfVariableFormatString 2024-03-17 18:21:35 +01:00
Laurent Destailleur
91c5868020
Merge pull request #28909 from mdeweerd/fix/PhanPluginUnknownClosureReturnType
Fix & enable PhanPluginUnknownClosureReturnType
2024-03-17 03:03:35 +01:00
MDW
551eaa115c
Fix & enable PhanPluginUnknownClosureReturnType
# Fix & enable PhanPluginUnknownClosureReturnType

Fix last PhanPluginUnknownClosureReturnType & enable the notice as
all are fixed
2024-03-17 00:10:18 +01:00
MDW
ef6eea3ed2
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-17 00:03:20 +01:00
Laurent Destailleur
7930226c0b
Merge branch 'develop' into qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions 2024-03-16 21:37:43 +01:00
MDW
2460518608
Add exception with latest codespell 2024-03-16 18:13:13 +01:00
MDW
c146f708e3
Qual: Add dolibarrr to dict 2024-03-16 18:06:22 +01:00
Laurent Destailleur
75fae0f27d
Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
MDW
cb55fb0864
Remove PhanTypeMismatchPropertyProbablyReal exceptions in baseline 2024-03-16 14:56:55 +01:00
MDW
ee97747eb6
Qual: Update phan baseline with issue we're not fixing now 2024-03-16 13:52:53 +01:00
MDW
725e419a46
Qual: Enable PhanTypeMismatchReturn 2024-03-16 13:52:19 +01:00
MDW
7b53202f74
Qual: Enable detection of use of DeprecatedFunctions 2024-03-16 13:27:52 +01:00
Laurent Destailleur
a247b474d7
Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence
Fix some phan notifications with low occurrence
2024-03-16 11:48:10 +01:00
MDW
8a83388905
Qual: Enable several phan notifications 2024-03-16 00:00:25 +01:00
MDW
375e4d7ccf
Qual: Enable PhanTypeMismatchArgumentInternalReal 2024-03-15 23:41:17 +01:00
Laurent Destailleur
372c8445fd
Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
0ee6fd6bad
Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
b658beab99
Merge pull request #28872 from mdeweerd/fix/PhanTypeMismatchReturnProbablyReal
Fix & enable PhanTypeMismatchReturnProbablyReal
2024-03-15 15:24:31 +01:00
Laurent Destailleur
1a722fa436
Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
MDW
1af4e90027
Qual: enable PhanTypeMismatchDefault 2024-03-15 14:53:07 +01:00
MDW
c7ad91cfc0
Qual: Enable PhanTypeMismatchReturnProbablyReal 2024-03-15 14:20:58 +01:00
Laurent Destailleur
066565938c
Merge pull request #28812 from mdeweerd/fix/PhanTypeSuspiciousEcho
Fix & enable PhanTypeSuspiciousEcho
2024-03-15 11:02:33 +01:00
Laurent Destailleur
11c77c410b
Merge pull request #28864 from mdeweerd/fix/PhanUndeclaredTypeReturnType
Fix & enable PhanUndeclaredTypeReturnType
2024-03-15 11:01:11 +01:00
MDW
651b5a22eb
Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
ec6786ece3
Detect PhanTypeMismatchPropertyProbablyReal 2024-03-15 10:12:52 +01:00
MDW
3384a0b847
Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
Laurent Destailleur
470e68829d
Merge branch 'develop' into fix/PhanTypeInvalidUnaryOperandNumeric 2024-03-15 10:03:50 +01:00
Laurent Destailleur
80e2e59373
Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e
Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Laurent Destailleur
1a63080e44
Merge branch 'develop' into fix/PhanTypeMismatchPropertyDefault 2024-03-15 08:41:23 +01:00
Laurent Destailleur
ba4e454827
Merge pull request #28829 from rycks/develop_add_projects_linked_by_a_contact_option
NEW Can show the list of projects having at least one contact that is a contact of the third party
2024-03-15 08:29:39 +01:00
Laurent Destailleur
176d8173a6
Merge pull request #28861 from mdeweerd/fix/PhanPluginPHPDocInWrongComment
Fix & enable PhanPluginPHPDocInWrongComment
2024-03-15 08:28:47 +01:00
MDW
9fd8b8c8e8
Qual: Enable PhanTypeMismatchPropertyDefault 2024-03-15 03:55:53 +01:00
Laurent Destailleur
b23e627a05
Merge pull request #28800 from mdeweerd/PhanPluginDuplicateConditionalUnnecessa
Fix & enable PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y"
2024-03-15 00:27:58 +01:00
Laurent Destailleur
0691839c7b
Merge branch 'develop' into develop_add_projects_linked_by_a_contact_option 2024-03-14 23:57:30 +01:00
Laurent Destailleur
c49968bb4b
Merge pull request #28825 from mdeweerd/fix/PhanNoopBinaryOperator
Fix & Enable PhanNoopBinaryOperator
2024-03-14 23:55:33 +01:00
MDW
ab7879c4a2
Fix & enable PhanPluginPHPDocInWrongComment
# Fix & enable PhanPluginPHPDocInWrongComment

Ignore error in file where the notification occurs & enable detection.
2024-03-14 23:36:24 +01:00
Laurent Destailleur
e478fd8cbc
Merge pull request #28859 from mdeweerd/fix/PhanPluginUnknownClosureParamType
Fix & enable PhanPluginUnknownClosureParamType
2024-03-14 23:10:37 +01:00
Laurent Destailleur
2508523f66
Merge pull request #28826 from mdeweerd/fix/PhanNoopProperty
Fix & enable PhanNoopProperty
2024-03-14 23:08:00 +01:00
MDW
0f8b9e73f0
Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
MDW
43342c8978
Qual: Allow PhanNoopBinaryOperator (all fixed) 2024-03-14 22:57:43 +01:00
Laurent Destailleur
ae85f06ed3
Merge pull request #28857 from mdeweerd/phan/extended/disable_PhanPluginDuplicateCatchStatementBody
Qual: Disable PhanPluginDuplicateCatchStatementBody requires PHP7.1
2024-03-14 22:43:55 +01:00
MDW
a408288ba1
Fix & enable PhanPluginUnknownClosureParamType
# Fix & enable PhanPluginUnknownClosureParamType

Typing of anonymous functions to fix this notice.
Optimised some minor things.
2024-03-14 22:42:26 +01:00
MDW
97f4e4f462
Qual: Disable PhanPluginDuplicateCatchStatementBody which requires PHP7.1 for fix
# Qual: Disable PhanPluginDuplicateCatchStatementBody which requires PHP7.1 for fix

To fix this PHP7.1 is required, so skipping the message in the extended
report as well.
2024-03-14 20:05:32 +01:00
MDW
b2cbf7fe3c
Qual: Enable PhanPluginDuplicateConditionalUnnecessary notices (all fixed) 2024-03-14 19:47:27 +01:00
MDW
69be3bbca6
Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions
# Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions

Fix by casting result of date() or by adding typing hints.

(This notification indicates a unary '-' or similar is performed
on a value that may not be a number).
2024-03-14 19:39:49 +01:00
MDW
49416784ce
Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:29 +01:00
MDW
b28f6a2cba
Enable PhanNoopProperty 2024-03-14 19:37:47 +01:00
Eric Seigne
385732c12d codespell and datee 2024-03-14 18:09:04 +01:00
MDW
1e252dd587
Add spelling exception (datee + error in Changelog) 2024-03-14 17:05:27 +01:00
Eric Seigne
da543ac96d codespell and datee 2024-03-14 10:00:48 +01:00
MDW
0127cc76f5
Qual: Enable PhanTypeInvalidUnaryOperandIncOrDec (all fixed) 2024-03-13 17:38:14 +01:00
Laurent Destailleur
cad8f24322
Merge pull request #28799 from mdeweerd/fix/PhanPluginDuplicateExpressionAssignmentOperation
Fix & enable PhanPluginDuplicateExpressionAssignment
2024-03-13 14:49:21 +01:00
Laurent Destailleur
4afadf6dc4
Merge pull request #28804 from mdeweerd/fix/PhanPluginUnknownFunctionParamType
Fix & enable PhanPluginUnknownFunctionParamType
2024-03-13 14:31:18 +01:00
Laurent Destailleur
c3f28b8592
Merge pull request #28802 from mdeweerd/PhanPluginRedundantAssignment
Fix PhanPluginRedundantAssignment
2024-03-13 11:04:02 +01:00
MDW
73eeb69cc8
Qual: Enable PhanPluginUnknownFunctionParamType (all fixed) 2024-03-13 10:51:46 +01:00
MDW
1debf4f538
# Fix & enable PhanPluginPrintfNotPercent
Fix PhanPluginPrintfNotPercent by setting format length to non 0 value.

Example of Notification message:

    'Format string "%0.10F" contains something that is not a percent sign, it will be treated as a format string '%0.10F' with padding of "0" and alignment of '' but no width. Use %% for a literal percent sign, or '%1$.10F' to be less ambiguous' .
2024-03-13 10:42:13 +01:00
MDW
fcca1b6987
Qual: Enable PhanPluginRedundantAssignment (all fixed) 2024-03-13 01:05:05 +01:00
MDW
6170ebe82e
Qual: Enable PhanPluginDuplicateExpressionAssignment, all fixed 2024-03-12 22:27:58 +01:00
MDW
4df31b5664
Qual: Enable PhanPluginMixedKeyNoKey, all cases fixed 2024-03-12 21:35:54 +01:00
MDW
8f7fb3fac9
Qual: No more exception for PhanPluginDuplicateIfCondition 2024-03-12 19:16:44 +01:00
Laurent Destailleur
a6926c29c0
Merge pull request #28778 from fappels/develop_fix_delivery_note
Fix shipping is not a delivery_note (is sub module of shipping)
2024-03-12 14:53:51 +01:00
Laurent Destailleur
367f47428f
Merge pull request #28734 from mdeweerd/fix/PhanTypeMismatchDimAssignment
Qual: Fix and enable PhanTypeMismatchDimAssignment
2024-03-12 14:20:34 +01:00
Laurent Destailleur
d62ef14064
Merge pull request #28768 from mdeweerd/fix/PhanTypeMismatchDeclaredParamNullable
Fix: PhanTypeMismatchDeclaredParamNullable & enable detection
2024-03-12 14:19:41 +01:00
Francis Appels
6f1b184f17 Merge remote-tracking branch 'Dolibarr/develop' into develop_fix_delivery_note 2024-03-12 14:13:41 +01:00
Francis Appels
75e99a6dee Fix phan tool for shipping 2024-03-12 11:21:42 +01:00
Frédéric FRANCE
d7517b5f20 Merge remote-tracking branch 'upstream/develop' into clean_mod_code 2024-03-12 09:25:53 +01:00
Laurent Destailleur
d94d7ef700 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-12 00:41:50 +01:00
Frédéric France
c8c003a437 restore rule 2024-03-11 23:46:48 +01:00
Frédéric France
e60db40fa4 clean code and phpdoc 2024-03-11 22:20:29 +01:00
Frédéric France
7a7d342aaa clean code and phpdoc 2024-03-11 22:14:39 +01:00
MDW
200bc042bd
Qual: Enable PhanTypeMismatchDeclaredParamNullable
# Qual: Enable PhanTypeMismatchDeclaredParamNullable

The few cases for PhanTypeMismatchDeclaredParamNullable were fixed,
so the notification can be enabled
2024-03-11 16:48:55 +01:00
Laurent Destailleur
e236553ea8
Merge branch 'develop' into fix/PhanTypeMismatchDimAssignment 2024-03-11 14:41:04 +01:00
MDW
dbfb1180ee
Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
Laurent Destailleur
5c84032d41
Merge branch 'develop' into fix/PhanTypeMismatchDimAssignment 2024-03-11 12:56:23 +01:00
MDW
9c00a465c9
Qual: phan: Add more global definitions (#28745)
* Qual: phan: Add more global definitions

# Qual: phan: Add more global definitions

Add some more typing information for globals

* Qual: phan: ignore local conf file which may contain exceptions

* Qual: phan: add a few more global typings
2024-03-11 12:55:44 +01:00
Laurent Destailleur
0fb4a44563 Fix nb of lines 2024-03-10 22:13:37 +01:00
Laurent Destailleur
c03b5dc2ec Fix for phan output 2024-03-10 18:50:02 +01:00
MDW
c6fa4e4945
Qual: Enable reporting PhanTypeMismatchDimAssignment 2024-03-10 02:17:20 +01:00
MDW
6d9e7b8144
Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal (#28732)
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal

* Qual: phan: suppress false positive on ssl_set

* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.

* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing

* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
2024-03-10 01:55:56 +01:00
MDW
d524e97137
Qual: Fix & enable PhanPluginRedundantAssignmentInLoop (#28733)
# Qual: Fix & enable PhanPluginRedundantAssignmentInLoop

Fixes the occurences that generated this notice & enable the report
for PhanPluginRedundantAssignmentInLoop
2024-03-10 01:54:34 +01:00
MDW
c95bab2818
Qual: Add check on addExtraField type argument (#28738)
* Qual: Add check on addExtraField type argument

# Qual: Add check on addExtraField type argument

Added a check on the type argument for addExtraField

* Qual: Update phan ignore with more specific name
2024-03-10 01:46:10 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values (#28728)
* Qual: Enable PhanUndeclaredVariableDim

# Qual: Enable PhanUndeclaredVariableDim

The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Qual: Add type hint to array to avoid phan notification

* Qual: Add type hint to array to avoid phan notification

* Qual: Enable PhanParamSpecial1 (all resolved)

* Qual: Ignore false PhanTypeArraySuspiciousNullable

* Qual: Improve typing to fix PhanTypeArraySuspicious

* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array

* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Enable phan messages that no longer appear

* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
Laurent Destailleur
302ea702e6 Add v19 in stats 2024-03-09 02:55:25 +01:00
MDW
3b57795895
Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0) (#28718)
* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* Qual: Update selectDate '' arguments h, m and empty to match PHPdoc (set to 0)

* New: Fixer for selectDate '' arguments h, m and empty

* Qual: Update codespell exceptions
2024-03-09 01:04:15 +01:00
Laurent Destailleur
bb6cf2c6ed Fix warning 2024-03-08 23:00:55 +01:00
Laurent Destailleur
c44f102518 Try to remove phan error 2024-03-08 22:58:15 +01:00
MDW
3d0a85608b
Qual: Fix and enable alias deprecation detection (#28716)
* Qual: Ignore some false positives for deprecated functions

# Qual: Ignore some false positives for deprecated functions

The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that

* Qual: Enable detection and fixing of internal deprecations

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Update codespell lines ignore list after format

# Qual: Update codespell lines ignore list after forma

Done using latest library, so also adds some exceptions that are needed
in the future;

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:34:18 +01:00
MDW
826d72d04b
Qual: Reduce phan baseline (thanks to 'fixes') (#28715)
# Qual: Reduce phan baseline (thanks to 'fixes')

The number of phan exceptions has been reduced, the baseline is updated
accordingly.
2024-03-08 21:25:15 +01:00
MDW
6cce456b8c
Qual: Add fixers for price(ARG2), and urlencode((string)...) (#28701)
# Qual: Add fixers for price(ARG2), and urlencode((string)...)

Register the fixers used to fix phan messages by adjusting arguments and casts.
2024-03-08 12:18:22 +01:00
Laurent Destailleur
ca297a751f Clean internal pahn warnings 2024-03-07 22:08:58 +01:00
Laurent Destailleur
04670b92b3 Fix var_dump 2024-03-04 20:13:08 +01:00
Laurent Destailleur
3bafcf5d00 Fix CLI tools must return a positive value on error for better cross
platform compatibility
2024-03-04 19:41:21 +01:00
Laurent Destailleur
8528b3f363 Clean conf 2024-03-04 18:33:32 +01:00
Laurent Destailleur
61dd78b95e Fix regression. Removed bad fixer. GETPOST(... int) is not GETPOSTINT 2024-03-04 17:49:43 +01:00
Laurent Destailleur
4f3a6d1959 Removed false positive 2024-03-01 01:58:06 +01:00
Laurent Destailleur
dd3415b1ac Fix phan error and remove false alert 2024-02-29 16:41:00 +01:00
Frédéric FRANCE
88fde71187
Update codespell-dict.txt (#28517) 2024-02-29 15:25:38 +01:00
MDW
7391ad42ed
Qual: Enable detection of deprecated modulename & GETPOST(...,'int') (#28457)
* Qual: Enable detection of deprecated modulename & GETPOST(...,'int')

# Qual: Enable detection of deprecated modulename & GETPOST(...,'int')

Enable phan rules to verify deprecated modulename usage and GETPOST(...,'int')
usage in the code.

* Qual: Try type hint on  to help avoid notification

* Qual: Accept 3 parameters for GETPOST to GETPOSTINT conversion

* Qual: Convert GETPOST(...,'int',VALUE) to GETPOSTINT(...,VALUE)

# Qual: Convert GETPOST(...,'int',VALUE) to GETPOSTINT(...,VALUE)

Following the update to the fixer to also convert GETPOST... with 3 parameters.
The files are now converted.
2024-02-28 23:25:16 +01:00
MDW
a351bc05e5
New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT (#28447)
* New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT

# New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT

This detects GETPOST calls with second parameter 'int' and can
convert to GETPOSTINT

* New: Fixer for deprecated module names
2024-02-27 14:08:07 +01:00
MDW
36f890f973
Fix: GETPOST(...,'int') to GETPOSTINT(...) (#28448)
* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: Update spelling exceptions

* Qual: Ignore Phan Notice
2024-02-27 14:05:53 +01:00
MDW
1c3a035ae5
Qual: New Phan plugin for testing that argument matches regex (#28424)
* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Update config.php

* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Report scalar values (see null, etc)

* Qual: Ignore false Phan Notification

* Qual: Ignore false Phan Notification

* Qual: Fix Phan needs specific message keys for coloring.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-26 23:10:16 +01:00
MDW
0d60041d8f
Qual: Add custom phan plugin to detect var_dump (#28420)
# Qual: Add custom phan plugin to detect var_dump

This adds a custom plugin to detect the presence of var_dump.

Also disable a standard plugin in the extended configuration
(avoid reporting suggestions to add typing to the function
definitions (/declarations).
2024-02-25 22:11:25 +01:00
Laurent Destailleur
08a61c542a Restore dolPrintLabel 2024-02-25 20:53:42 +01:00
Laurent Destailleur
87d25869ac Fix lost lines 2024-02-25 18:55:22 +01:00
Laurent Destailleur
2db3dc0eef Fix output for phpphan 2024-02-25 18:36:40 +01:00
MDW
20b740dcc8
Qual: Review pre-commit configure - re-enable no-commit-to-branch (#28385)
# Qual: Review pre-commit configure - re-enable no-commit-to-branch

This reviews some of the documentation inside the pre-commit-config.yaml file.
It also re-enables the no-commit-to-branch hook.

Also enable spelling on hidden files (changes to pyproject.toml +
exceptions file).
2024-02-24 15:38:20 +01:00
MDW
e77cd248f0
Fix: Spelling in "hidden" files (#28391)
* Fix: Spelling in 'hidden' file

* Fix: Spelling in 'hidden' file

* Fix: Spelling in 'hidden' file
2024-02-24 13:04:22 +01:00
MDW
8655d5a86b
QUAL Use phan to help detect new issues (#27706)
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:14:29 +01:00
Laurent Destailleur
f01fa6e098 Fix datatable 2024-02-21 15:00:14 +01:00
Laurent Destailleur
a732e72be0 Fix apstats 2024-02-21 14:41:13 +01:00
MDW
b343181789
Update phpunit.bat sample script and setup_conf.sh (#28307)
# Update phpunit.bat sample script and setup_conf.sh

- setup_conf.sh - Added caching feature;
- phpunit.bat - Example updated based on experience with php web server
2024-02-20 23:02:59 +01:00
Laurent Destailleur
67a23fd57f Add more choices in lenght of list in apstats 2024-02-20 02:26:42 +01:00
MDW
afe17928f2
Qual: Improve test messages to help locate errors + php-cs-fixer on tests (#28272)
* Qual: Apply php-cs-fixer before changes

# Qual: Apply php-cs-fixer before changes

Apply php-cs-fixer before changes to make real changes stand out
in next commit.

* Qual: Improve test messages to help locate errors.

# Qual: Improve test messages to help locate errors.

Included a description of the test in the failing assertions to
help locate the error.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: Update spelling exception

# Qual: Update spelling exception

Formatting the code requires an update in the spelling exception list.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.
2024-02-19 15:28:21 +01:00
Laurent Destailleur
f48ab54513 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 15:16:22 +01:00
Laurent Destailleur
9b4d53638f Fix html 2024-02-18 15:15:10 +01:00
MDW
9387616e7f
Qual: Improve rendering of phpstan technical debt table in apstats. (#28236)
* Qual: Improve rendering of phpstan technical debt table in apstats.

# Qual: Improve rendering of phpstan technical debt table in apstats.

Apply the DataTable rendering to the phpstan technical debt (same as applied to phan).

* Fix spelling

* Qual: Harden apstats output.

# Qual: Harden apstats output.

Escaping output for phpstan, and more escaping for phan.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:13:43 +01:00
Laurent Destailleur
de210ce277 css 2024-02-17 23:47:47 +01:00
Laurent Destailleur
193a3717b4 css 2024-02-17 17:07:13 +01:00
Laurent Destailleur
0b85d9ac81 css 2024-02-17 17:02:14 +01:00
Laurent Destailleur
4bb8f573ea Fix apstats 2024-02-17 16:58:21 +01:00
Laurent Destailleur
750e3270ac Enhance apstats 2024-02-17 16:46:06 +01:00
MDW
e5423d5c59
Qual: Add exceptions for codespell (#28186)
* Dev: Add setup scripts for phpunit/database

# Dev: Add setup scripts for phpunit/database

Some scripts that helped to setup some unit testing.

* NEW Add Windows ci workflow

# NEW Add Windows ci workflow

This adds a workflow to execute ci on a windows platform

* Disable open_basedir for now, to test effect

* Qual: Exclude documents directory from codespell

# Qual: Exclude documents directory from codespell

Documents directory may be present during development (unit tests).
Do not check spelling there

* Qual: Add codespell exceptions

# Qual: Add codespell exceptions

Add new exceptions to codespell (var identified as misspelling).
2024-02-15 14:49:09 +01:00
MDW
1c452bc86e
Qual: Fix apstats & add phan (#28127)
# Qual: Fix apstats & add phan

I fixed several issues that I ran into when running apstats.php
locally to test the phan integration.

So this commit only proposes the updates to apstats.php.

I added a test that disables phan when its configurations is not
found so it should be fine to integration in develop.
2024-02-12 02:01:51 +01:00
Laurent Destailleur
29eb98816e disable bad link 2024-02-11 18:09:20 +01:00
Laurent Destailleur
f26bbb022a Fix delay 2024-02-11 18:07:55 +01:00
Laurent Destailleur
12908df0d6 Work on scan security commits 2024-02-11 16:39:31 +01:00