From fb283fdfe9d050f581eb4ce4814fd650bc9f799a Mon Sep 17 00:00:00 2001
From: Laurent Destailleur <eldy@destailleur.fr>
Date: Sat, 17 Feb 2024 18:39:26 +0100
Subject: [PATCH] Clean code after yogosha reports

---
 htdocs/admin/system/filecheck.php    | 2 +-
 htdocs/api/class/api_setup.class.php | 6 +++---
 htdocs/modulebuilder/index.php       | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/htdocs/admin/system/filecheck.php b/htdocs/admin/system/filecheck.php
index bccdf608e5e..320f032fb19 100644
--- a/htdocs/admin/system/filecheck.php
+++ b/htdocs/admin/system/filecheck.php
@@ -60,7 +60,7 @@ print '<tr class="oddeven"><td width="300">'.$langs->trans("VersionProgram").'</
 // If current version differs from last upgrade
 if (!getDolGlobalString('MAIN_VERSION_LAST_UPGRADE')) {
 	// Compare version with last install database version (upgrades never occurred)
-	if (DOL_VERSION != $conf->global->MAIN_VERSION_LAST_INSTALL) {
+	if (DOL_VERSION != getDolGlobalString('MAIN_VERSION_LAST_INSTALL')) {
 		print ' '.img_warning($langs->trans("RunningUpdateProcessMayBeRequired", DOL_VERSION, getDolGlobalString('MAIN_VERSION_LAST_INSTALL')));
 	}
 } else {
diff --git a/htdocs/api/class/api_setup.class.php b/htdocs/api/class/api_setup.class.php
index c9e22063bff..97c1cb02c57 100644
--- a/htdocs/api/class/api_setup.class.php
+++ b/htdocs/api/class/api_setup.class.php
@@ -2149,9 +2149,9 @@ class Setup extends DolibarrApi
 					$i++;
 					$out .= '<tr class="oddeven">';
 					$out .= '<td>'.$i.'</td>'."\n";
-					$out .= '<td>'.$constname.'</td>'."\n";
-					$out .= '<td class="center">'.$constvalue.'</td>'."\n";
-					$out .= '<td class="center">'.$valueforchecksum.'</td>'."\n";
+					$out .= '<td>'.dol_escape_htmltag($constname).'</td>'."\n";
+					$out .= '<td class="center">'.dol_escape_htmltag($constvalue).'</td>'."\n";
+					$out .= '<td class="center">'.dol_escape_htmltag($valueforchecksum).'</td>'."\n";
 					$out .= "</tr>\n";
 				}
 
diff --git a/htdocs/modulebuilder/index.php b/htdocs/modulebuilder/index.php
index b959001a33f..aa0d49399a4 100644
--- a/htdocs/modulebuilder/index.php
+++ b/htdocs/modulebuilder/index.php
@@ -51,7 +51,7 @@ $confirm = GETPOST('confirm', 'alpha');
 $cancel  = GETPOST('cancel', 'alpha');
 
 $sortfield = GETPOST('sortfield', 'alpha');
-$sortorder = GETPOST('sortorder', 'alpha');
+$sortorder = GETPOST('sortorder', 'aZ09');
 
 $module = GETPOST('module', 'alpha');
 $tab = GETPOST('tab', 'aZ09');