From f6fc93249deef3e36a5072441715597e3c6923f8 Mon Sep 17 00:00:00 2001 From: MDW Date: Fri, 9 Feb 2024 11:38:37 +0100 Subject: [PATCH] Qual: Lower severity on php-cs messages that should not block (#28072) # Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file. --- .pre-commit-config.yaml | 2 +- dev/setup/codesniffer/ruleset.xml | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 95f2b455877..e88b7d2eeca 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -60,7 +60,7 @@ repos: args: [--standard=dev/setup/codesniffer/ruleset.xml] - id: php-cs files: \.(php)$ - args: [--standard=dev/setup/codesniffer/ruleset.xml, --report=emacs] + args: [--standard=dev/setup/codesniffer/ruleset.xml, --report=emacs, --severity=5] - id: php-lint - id: php-stan stages: [manual] diff --git a/dev/setup/codesniffer/ruleset.xml b/dev/setup/codesniffer/ruleset.xml index 4949fda7800..c9d264b5092 100644 --- a/dev/setup/codesniffer/ruleset.xml +++ b/dev/setup/codesniffer/ruleset.xml @@ -68,6 +68,17 @@ 0 + + + 4 + + + 4 + + + 4 + +