Mirrors/dolibarr
1
0
Fork 0
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-02-20 13:46:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Qual: fix ci phpstan by removing useless test (#31772)

Browse Source 
# Qual: fix phpstan by removing useless test

!$error && $champdatefin && ($champdatefin > 0) has useless tests.
- $error is still 0.
- $champdatefin is also not 0 when it is >0
- By casting $champdatefin to int, we ensure that '' (error) is
  converted to 0.
This commit is contained in:
MDW 2024-11-12 00:32:59 +01:00 committed by GitHub
parent 40aca2803f
commit e8c51e8802
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
htdocs/opensurvey/wizard/create_survey.php
View File

@ -3,6 +3,7 @@
* Copyright (C) 2014 Marcos García <marcosgdf@gmail.com>
* Copyright (C) 2015-2016 Alexandre Spangaro <aspangaro@open-dsi.fr>
* Copyright (C) 2018-2024 Frédéric France <frederic.france@free.fr>
* Copyright (C) 2024 MDW <mdeweerd@users.noreply.github.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -90,9 +91,9 @@ if (!empty($creation_sondage_date) || !empty($creation_sondage_autre)) {
}
$testdate = false;
$champdatefin = dol_mktime(23, 59, 59, GETPOSTINT('champdatefinmonth'), GETPOSTINT('champdatefinday'), GETPOSTINT('champdatefinyear'));
$champdatefin = (int) dol_mktime(23, 59, 59, GETPOSTINT('champdatefinmonth'), GETPOSTINT('champdatefinday'), GETPOSTINT('champdatefinyear'));
if (! $error && $champdatefin && ($champdatefin > 0)) { // A date was provided
if ($champdatefin > 0) { // A date was provided, $error still 0 here
// Expire date is not before today
if ($champdatefin >= dol_now()) {
$testdate = true;