From cd2b9538c17c23ef2d2b375f546ac0f539959125 Mon Sep 17 00:00:00 2001
From: daraelmin <daraelmin@gmail.com>
Date: Tue, 15 Nov 2022 11:51:20 +0100
Subject: [PATCH] FIx #18304 No adh create if error on public form

FIX #18304 - Member subscription confirmation email sent even if mandatory fields are missing
---
 htdocs/public/members/new.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/htdocs/public/members/new.php b/htdocs/public/members/new.php
index 7f788a84671..7b0ce31700b 100644
--- a/htdocs/public/members/new.php
+++ b/htdocs/public/members/new.php
@@ -279,7 +279,10 @@ if ($action == 'add')
         $ret = $extrafields->setOptionalsFromPost(null, $adh);
 		if ($ret < 0) $error++;
 
-        $result = $adh->create($user);
+        if (empty($error)) {
+			$result = $adh->create($user);
+		}
+		
         if ($result > 0)
         {
 			require_once DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php';