Mirrors/dolibarr
1
0
Fork 0
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-02-20 13:46:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

FIX: ContratTest: fix create when no societe exists

Browse Source 
The testContratCreate() is using the default value for Contrat::socid,
which is defined by Contrat::initAsSpecimen to `0`. But if no companies
have been created, the test will fail with the following error:

    Failed asserting that 0 is less than -1.

Or with the additional logging:

    UnknownError: ERROR:  23503: insert or update on table "llx_contrat" violates foreign key constraint "fk_contrat_fk_soc"
    DETAIL:  Key (fk_soc)=(1) is not present in table "llx_societe".                                                        
    SCHEMA NAME:  public                                                                                                    
    TABLE NAME:  llx_contrat                                                                                                
    CONSTRAINT NAME:  fk_contrat_fk_soc                                                                                     
    LOCATION:  ri_ReportViolation, ri_triggers.c:2596 -,                                                                    
    Failed asserting that 0 is less than -1.

The test doesn't really depends on specific test data so we can create
the company directly instead.
This commit is contained in:
Alexandre Janniaux 2023-11-19 15:05:32 +01:00
parent d4f61dcf59
commit c2c99ab2b8
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/phpunit/ContratTest.php
View File

@ -139,8 +139,14 @@ class ContratTest extends PHPUnit\Framework\TestCase
$langs=$this->savlangs;
$db=$this->savdb;
$soc = new Societe($db);
$soc->name = "ContratTest Unittest";
$socid = $soc->create($user);
$this->assertLessThan($socid, 0, $soc->errorsToString());
$localobject=new Contrat($db);
$localobject->initAsSpecimen();
$localobject->socid = $socid;
$result=$localobject->create($user);
print __METHOD__." result=".$result."\n";