diff --git a/htdocs/admin/pdf.php b/htdocs/admin/pdf.php index c8567af3c9e..8729fce71d3 100644 --- a/htdocs/admin/pdf.php +++ b/htdocs/admin/pdf.php @@ -570,11 +570,13 @@ print ''; // Show alias in thirdparty name -print ''.$langs->trans("PDF_THIRDPARTY_NAME_TO_SHOW_IS").''; +/* Disabled because not yet completely implemented (does not work when we force a contact on object) +print ''.$langs->trans("PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME").''; if ($conf->use_javascript_ajax) { - $arrval = array('0' => '', '1' => $langs->trans("THIRDPARTY_ALIAS"), '2' => $langs->trans("ALIAS_THIRDPARTY")); - print $form->selectarray("PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME", $arrval, $conf->global->PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME); + $arrval = array('0' => $langs->trans("No"), '1' => $langs->trans("THIRDPARTY_ALIAS"), '2' => $langs->trans("ALIAS_THIRDPARTY")); + print $form->selectarray("PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME", $arrval, getDolGlobalInt('PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME')); } +*/ // Show online payment link on invoices diff --git a/htdocs/core/lib/pdf.lib.php b/htdocs/core/lib/pdf.lib.php index 36f04836a64..ca94353ee19 100644 --- a/htdocs/core/lib/pdf.lib.php +++ b/htdocs/core/lib/pdf.lib.php @@ -391,16 +391,19 @@ function pdfBuildThirdpartyName($thirdparty, Translate $outputlangs, $includeali $socname = ''; if ($thirdparty instanceof Societe) { - $socname .= $thirdparty->name; - if (($includealias || $conf->global->PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME) == 1 && !empty($thirdparty->name_alias)) { - $socname .= " - ".$thirdparty->name_alias; - if ($conf->global->PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME == 2) { - $socname = ''; + $socname = $thirdparty->name; + if (($includealias || getDolGlobalInt('PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME')) && !empty($thirdparty->name_alias)) { + if (getDolGlobalInt('PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME') == 2) { $socname = $thirdparty->name_alias." - ".$thirdparty->name; + } else { + $socname = $thirdparty->name." - ".$thirdparty->name_alias; } } } elseif ($thirdparty instanceof Contact) { $socname = $thirdparty->socname; + if (($includealias || getDolGlobalInt('PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME')) && !empty($thirdparty->name_alias)) { + // TODO PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME not completely implemented + } } else { throw new InvalidArgumentException('Parameter 1 $thirdparty is not a Societe nor Contact'); } diff --git a/htdocs/langs/en_US/admin.lang b/htdocs/langs/en_US/admin.lang index c4cdb5d6d04..d3f62c0dc9d 100644 --- a/htdocs/langs/en_US/admin.lang +++ b/htdocs/langs/en_US/admin.lang @@ -2168,7 +2168,7 @@ EmailTemplate=Template for email EMailsWillHaveMessageID=Emails will have a tag 'References' matching this syntax PDF_SHOW_PROJECT=Show project on document ShowProjectLabel=Project Label -PDF_THIRDPARTY_NAME_TO_SHOW_IS=Include alias in thirdparty name +PDF_INCLUDE_ALIAS_IN_THIRDPARTY_NAME=Include alias in thirdparty name THIRDPARTY_ALIAS=Name thirdparty - Alias thirdparty ALIAS_THIRDPARTY=Alias thirdparty - Name thirdparty PDF_USE_ALSO_LANGUAGE_CODE=If you want to have some texts in your PDF duplicated in 2 different languages in the same generated PDF, you must set here this second language so generated PDF will contains 2 different languages in same page, the one chosen when generating PDF and this one (only few PDF templates support this). Keep empty for 1 language per PDF.