From a8b5cfb23ed38bfbacc90d83fa1b57c92a0bcba0 Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Thu, 24 Aug 2023 14:31:10 +0200 Subject: [PATCH] Clean test files --- .scrutinizer.yml | 236 ----------------------------------------------- .stickler.yml | 14 --- phpstan.neon | 1 + qodana.yaml | 120 ------------------------ 4 files changed, 1 insertion(+), 370 deletions(-) delete mode 100644 .scrutinizer.yml delete mode 100644 .stickler.yml delete mode 100644 qodana.yaml diff --git a/.scrutinizer.yml b/.scrutinizer.yml deleted file mode 100644 index 058a0ba8b48..00000000000 --- a/.scrutinizer.yml +++ /dev/null @@ -1,236 +0,0 @@ -# .scrutinizer.yml -#build: -# - php-scrutinizer-run -build: - nodes: - analysis: - tests: - override: - - command: php-scrutinizer-run - idle_timeout: 8000 - #- php-scrutinizer-run --sub-project-dir=htdocs/admin - -imports: - - php - -filter: - excluded_paths: - - build/ - - dev/ - - doc/ - - documents/ - - node_modules/ - - test/ - - htdocs/custom/ - - htdocs/includes/ - - htdocs/install/doctemplates/ - #dependency_paths: - # - htdocs/includes/ - paths: - - htdocs/* - - scripts/* - -tools: - # php_analyzer. Doc on https://scrutinizer-ci.com/docs/tools/php/php-analyzer/ - php_analyzer: - enabled: true - extensions: - - php - #dependency_paths: - # - htdocs/includes/ - filter: - excluded_paths: - - build/ - - dev/ - - doc/ - - documents/ - - htdocs/custom/ - - htdocs/includes/ - - htdocs/install/doctemplates/ - - htdocs/core/class/lessc.class.php - - node_modules/ - - test/ - paths: - - htdocs/* - - scripts/* - config: - parameter_reference_check: - enabled: true - checkstyle: - enabled: false - no_trailing_whitespace: true - naming: - enabled: true - local_variable: ^[a-z][a-zA-Z0-9]*$ - abstract_class_name: ^Abstract|Factory$ - utility_class_name: Utils?$ - constant_name: ^[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*$ - property_name: ^[a-z][a-zA-Z0-9]*$ - method_name: ^(?:[a-z]|__)[a-zA-Z0-9]*$ - parameter_name: ^[a-z][a-zA-Z0-9]*$ - interface_name: ^[A-Z][a-zA-Z0-9]*Interface$ - type_name: ^[A-Z][a-zA-Z0-9]*$ - exception_name: ^[A-Z][a-zA-Z0-9]*Exception$ - isser_method_name: ^(?:is|has|should|may|supports) - unreachable_code: - enabled: true - check_access_control: - enabled: true - typo_checks: - enabled: true - check_variables: - enabled: true - check_calls: - enabled: true - too_many_arguments: true - missing_argument: true - argument_type_checks: lenient # Allowed Values: "disabled", "lenient", "strict" - suspicious_code: - enabled: true - overriding_parameter: false - overriding_closure_use: true - parameter_closure_use_conflict: true - parameter_multiple_times: true - non_existent_class_in_instanceof_check: true - non_existent_class_in_catch_clause: true - assignment_of_null_return: true - non_commented_switch_fallthrough: true - non_commented_empty_catch_block: true - overriding_private_members: true - use_statement_alias_conflict: true - precedence_in_condition_assignment: true - dead_assignments: - enabled: true - verify_php_doc_comments: - enabled: false - parameters: true - return: true - suggest_more_specific_types: true - ask_for_return_if_not_inferrable: true - ask_for_param_type_annotation: true - loops_must_use_braces: - enabled: true - check_usage_context: - enabled: true - simplify_boolean_return: - enabled: false - phpunit_checks: - enabled: false - reflection_checks: - enabled: true - - # Checks Common Precedence Mistakes - precedence_checks: - enabled: true - assignment_in_condition: true - comparison_of_bit_result: true - basic_semantic_checks: - enabled: true - # Disabled unused code. In most cases, we want to keep it. - unused_code: - enabled: false - deprecation_checks: - enabled: true - useless_function_calls: - enabled: true - metrics_lack_of_cohesion_methods: - enabled: true - metrics_coupling: - enabled: true - stable_code: - namespace_prefixes: [] - classes: [] - doctrine_parameter_binding: - enabled: false - doctrine_entity_manager_injection: - enabled: false - symfony_request_injection: - enabled: false - doc_comment_fixes: - enabled: true - reflection_fixes: - enabled: false - use_statement_fixes: - enabled: true - remove_unused: true - # Whether you would like multiple imports in one USE statement to be preserved, e.g. ``use A, B;``. - preserve_multiple: false - # Whether you would like to preserve blank lines between use statements. - preserve_blanklines: false - order_alphabetically: false - # To use specific config for a specific path, use path_configs: (see example on page https://scrutinizer-ci.com/docs/configuration/tool_config_structure) - - # php_depend - #php_pdepend: - # enabled: false - # configuration_file: null - # suffixes: - # - php - # excluded_dirs: { } - # filter: - # excluded_paths: - # - 'build/*' - # - 'dev/*' - # - 'doc/*' - # - 'test/*' - # - 'htdocs/includes/*' - # paths: { } - - # change tracking - #php_changetracking: - # enabled: false - # bug_patterns: - # - '\bfix(?:es|ed)?\b' - # feature_patterns: - # - '\badd(?:s|ed)?\b' - # - '\bimplement(?:s|ed)?\b' - # filter: - # excluded_paths: - # - 'build/*' - # - 'dev/*' - # - 'doc/*' - # - 'documents/*' - # - 'htdocs/includes/*' - # - 'node_modules/*' - # - 'test/*' - # paths: { } - - # Similar code detection - #php_sim: - # enabled: false - # min_mass: 30 - # filter: - # excluded_paths: - # - 'build/*' - # - 'dev/*' - # - 'doc/*' - # - 'documents/*' - # - 'htdocs/includes/*' - # - 'node_modules/*' - # - 'test/*' - # paths: { } - - # Coding-Style / Bug Detection - #js_hint: - # enabled: false - # use_native_config: true - # extensions: - # - js - # filter: - # excluded_paths: - # - 'build/*' - # - 'dev/*' - # - 'doc/*' - # - 'documents/*' - # - 'htdocs/includes/*' - # - 'node_modules/*' - # - 'test/*' - # paths: { } - # config: { } - # path_configs: { } - - -before_commands: { } -after_commands: { } -artifacts: { } -build_failure_conditions: { } diff --git a/.stickler.yml b/.stickler.yml deleted file mode 100644 index 642dec27412..00000000000 --- a/.stickler.yml +++ /dev/null @@ -1,14 +0,0 @@ ---- -linters: - phpcs: - standard: 'dev/setup/codesniffer/ruleset.xml' - extensions: 'php' - tab_width: 4 - fixer: true - -fixers: - enable: true - -files: - ignore: - - 'htdocs/includes/*' diff --git a/phpstan.neon b/phpstan.neon index 43c8d183543..6f5e133e825 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -14,6 +14,7 @@ parameters: - htdocs/documents/* - htdocs/install/doctemplates/* - htdocs/langs/* + - htdocs/modulebuilder/template/test/* - htdocs/support/* - htdocs/test/* analyse: diff --git a/qodana.yaml b/qodana.yaml deleted file mode 100644 index 4951ba9b5d6..00000000000 --- a/qodana.yaml +++ /dev/null @@ -1,120 +0,0 @@ -version: "1.0" -linter: jetbrains/qodana-php:2023.1-eap -failThreshold: 20000 -profile: - name: qodana.recommended -exclude: - - name: All - paths: - - dev - - build - - doc - - documents - - node_modules - - test - - htdocs/custom - - htdocs/includes - - htdocs/install/doctemplates - - htdocs/modulebuilder/template/test/phpunit/functionnal - - htdocs/theme/common/fontawesome-5 - - name: BadExpressionStatementJS - - name: CommaExpressionJS - - name: DuplicatedCode - - name: HtmlWrongAttributeValue - - name: JSCheckFunctionSignatures - - name: JSDuplicatedDeclaration - - name: JSEqualityComparisonWithCoercion - - name: JSHint - - name: JSIgnoredPromiseFromCall - - name: JSJQueryEfficiency - - name: JSPrimitiveTypeWrapperUsage - - name: JSTypeOfValues - - name: JSUnnecessarySemicolon - - name: JSUnresolvedLibraryURL - - name: JSUnusedAssignment - - name: JSUnusedLocalSymbols - - name: JSValidateTypes - - name: PhpArrayAccessCanBeReplacedWithForeachValueInspection - - name: PhpArrayIndexImmediatelyRewrittenInspection - - name: PhpArrayIsAlwaysEmptyInspection - - name: PhpArrayPushWithOneElementInspection - - name: PhpArraySearchInBooleanContextInspection - - name: PhpArrayUsedOnlyForWriteInspection - - name: PhpArrayWriteIsNotUsedInspection - - name: PhpCastIsUnnecessaryInspection - - name: PhpClassConstantAccessedViaChildClassInspection - - name: PhpConcatenationWithEmptyStringCanBeInlinedInspection - - name: PhpConditionAlreadyCheckedInspection - - name: PhpConditionCanBeReplacedWithMinMaxCallInspection - - name: PhpConditionCheckedByNextConditionInspection - - name: PhpCoveredCharacterInClassInspection - - name: PhpDefineCanBeReplacedWithConstInspection - - name: PhpDeprecationInspection - - name: PhpDocMissingThrowsInspection - - name: PhpDuplicateCatchBodyInspection - - name: PhpDuplicateSwitchCaseBodyInspection - - name: PhpExpressionAlwaysNullInspection - - name: PhpExpressionResultUnusedInspection - - name: PhpExpressionWithSameOperandsInspection - - name: PhpFieldImmediatelyRewrittenInspection - - name: PhpFullyQualifiedNameUsageInspection - - name: PhpIfWithCommonPartsInspection - - name: PhpIllegalStringOffsetInspection - - name: PhpInArrayCanBeReplacedWithComparisonInspection - - name: PhpIncludeInspection - - name: PhpIssetCanBeReplacedWithCoalesceInspection - - name: PhpIssetCanCheckNestedAccessDirectlyInspection - - name: PhpLanguageLevelInspection - - name: PhpLoopCanBeReplacedWithImplodeInspection - - name: PhpLoopCanBeReplacedWithStrRepeatInspection - - name: PhpMissingParamTypeInspection - - name: PhpMissingParentConstructorInspection - - name: PhpMissingReturnTypeInspection - - name: PhpNestedDirNameCallsCanBeReplacedWithLevelParameterInspection - - name: PhpObjectFieldsAreOnlyWrittenInspection - - name: PhpParameterByRefIsNotUsedAsReferenceInspection - - name: PhpParameterNameChangedDuringInheritanceInspection - - name: PhpPointlessBooleanExpressionInConditionInspection - - name: PhpPossiblePolymorphicInvocationInspection - - name: PhpPregMatchReplaceWithComparisonInspection - - name: PhpPregReplaceWithEmptyReplacementInspection - - name: PhpPropertyOnlyWrittenInspection - - name: PhpRedundantCatchClauseInspection - - name: PhpRedundantOptionalArgumentInspection - - name: PhpRedundantVariableDocTypeInspection - - name: PhpRegExpRedundantModifierInspection - - name: PhpReturnDocTypeMismatchInspection - - name: PhpReturnValueOfMethodIsNeverUsedInspection - - name: PhpSameParameterValueInspection - - name: PhpSillyAssignmentInspection - - name: PhpStatementHasEmptyBodyInspection - - name: PhpSuspiciousNameCombinationInspection - - name: PhpSwitchStatementWitSingleBranchInspection - - name: PhpSwitchWithCommonPartsInspection - - name: PhpTernaryExpressionCanBeReducedToShortVersionInspection - - name: PhpTernaryExpressionCanBeReplacedWithConditionInspection - - name: PhpUndefinedClassConstantInspection - - name: PhpUndefinedClassInspection - - name: PhpUndefinedMethodInspection - - name: PhpUndefinedNamespaceInspection - - name: PhpUnhandledExceptionInspection - - name: PhpUnnecessaryLocalVariableInspection - - name: PhpUnusedAliasInspection - - name: PhpUnusedAliasInspection - - name: PhpUnusedLocalVariableInspection - - name: PhpUnusedParameterInspection - - name: PhpUnusedPrivateFieldInspection - - name: PhpUnusedPrivateMethodInspection - - name: PhpWriteAccessToReferencedArrayValueWithoutUnsetInspection - - name: PhpWrongForeachArgumentTypeInspection - - name: PhpWrongStringConcatenationInspection - - name: RegExpRedundantEscape - - name: RegExpSimplifiable - - name: RegExpSingleCharAlternation - - name: RegExpUnnecessaryNonCapturingGroup - - name: ReservedWordUsedAsNameJS - - name: TrivialIfJS - - name: UnnecessaryLabelJS - - name: UnnecessaryReturnJS - - name: UnreachableCodeJS -