Mirrors/dolibarr
1
0
Fork 0
mirror of https://github.com/Dolibarr/dolibarr.git synced 2025-02-20 13:46:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove trigger BILLREC_CREATEBILL that should not exists as it is

Browse Source 
duplicate of BILL_CREATE.
This trigger was not a CRUD event. If you used it, you can already use
the trigger BILL_CREATE and test that ($object->fac_rec > 0) to know if
creation trigger is from a recurring invoice or not. Also this old
trigger was never enabled into table llx_c_action_trigger.
This commit is contained in:
Laurent Destailleur 2024-04-03 02:37:30 +02:00
parent 714236a1ec
commit 50f99a51bb
3 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -7,7 +7,7 @@ English Dolibarr ChangeLog
For users:
----------
NEW: Compatibility with PHP 8.3
NEW: Compatibility with PHP 8.2 (with no need to disable warnings)
...
For developers or integrators:
@ -34,6 +34,10 @@ The following changes may create regressions for some external modules, but were
the deprecated field $fk_user_done in actioncomm table is removed. Please use $fk_user_action instead.
* The table commande_fournisseur_dispatch has been renamed into receptiondet_batch to better match its goal and the field fk_commande
and fk_commandefourndet were renamed into fk_element and fk_elementdet
* Removed trigger BILLREC_CREATEBILL. This trigger was not a CRUD event. If you used it, you can already use the trigger BILL_CREATE and
test that ($object->fac_rec > 0) to know if creation trigger is from a recurring invoice or not. Also this old trigger was never enabled
into table llx_c_action_trigger.
***** ChangeLog for 19.0.1 compared to 19.0.0 *****

10
htdocs/compta/facture/class/facture.class.php
View File

@ -1090,18 +1090,8 @@ class Facture extends CommonInvoice
if ($result < 0) {
$error++;
}
//special case for recurring invoices, moved from facture-rec.class.php
if (!$error && $this->fac_rec > 0) {
$result = $this->call_trigger('BILLREC_CREATEBILL', $user);
if ($result < 0) {
$error++;
}
}
// End call triggers
}
if (!$error) {
$this->db->commit();
return $this->id;

2
htdocs/install/mysql/data/llx_c_action_trigger.sql
View File

@ -192,11 +192,9 @@ insert into llx_c_action_trigger (code,label,description,elementtype,rang) value
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('BILLREC_CREATE','Template invoices created','Executed when a Template invoices is created','facturerec',900);
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('BILLREC_MODIFY','Template invoices update','Executed when a Template invoices is updated','facturerec',901);
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('BILLREC_DELETE','Template invoices deleted','Executed when a Template invoices is deleted','facturerec',902);
--insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('BILLREC_AUTOCREATEBILL','Template invoices use to create invoices with auto batch','Executed when a Template invoices is use to create invoice with auto batch','facturerec',903);
-- partnership module
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('PARTNERSHIP_CREATE','Partnership created','Executed when a partnership is created','partnership',58000);
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('PARTNERSHIP_MODIFY','Partnership modified','Executed when a partnership is modified','partnership',58002);
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('PARTNERSHIP_SENTBYMAIL','Mails sent from partnership file','Executed when you send email from partnership file','partnership',58004);
insert into llx_c_action_trigger (code,label,description,elementtype,rang) values ('PARTNERSHIP_DELETE','Partnership deleted','Executed when a partnership is deleted','partnership',58006);