Merge pull request #33116 from jyhere/patch-22

Fix:  shipping workflow values comparison may fail
This commit is contained in:
Laurent Destailleur 2025-02-18 20:50:08 +01:00 committed by GitHub
commit 4c0918f0ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -207,7 +207,7 @@ class InterfaceWorkflowManager extends DolibarrTriggers
}
}
dol_syslog("Amount of linked shipment = ".$totalonlinkedelements.", of invoice = ".$object->total_ht.", egality is ".json_encode($totalonlinkedelements == $object->total_ht), LOG_DEBUG);
if ($totalonlinkedelements == $object->total_ht) {
if (price2num($totalonlinkedelements, 'MT') == price2num($object->total_ht, 'MT')) {
foreach ($object->linkedObjects['shipping'] as $element) {
$ret = $element->setClosed();
if ($ret < 0) {
@ -228,7 +228,7 @@ class InterfaceWorkflowManager extends DolibarrTriggers
}
}
dol_syslog("Amount of linked shipment = ".$totalonlinkedelements.", of invoice = ".$object->total_ht.", egality is ".json_encode($totalonlinkedelements == $object->total_ht), LOG_DEBUG);
if ($totalonlinkedelements == $object->total_ht) {
if (price2num($totalonlinkedelements, 'MT') == price2num($object->total_ht, 'MT')) {
foreach ($object->linkedObjects['shipping'] as $element) {
$ret = $element->setBilled();
if ($ret < 0) {