dolibarr/test/phpunit/CodingSqlTest.php

261 lines
9.2 KiB
PHP
Raw Normal View History

<?php
/* Copyright (C) 2013 Laurent Destailleur <eldy@users.sourceforge.net>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
2019-09-23 21:55:30 +02:00
* along with this program. If not, see <https://www.gnu.org/licenses/>.
* or see https://www.gnu.org/
*/
/**
* \file test/phpunit/SqlTest.php
2015-01-06 17:54:36 +01:00
* \ingroup test
* \brief PHPUnit test
2015-01-06 17:54:36 +01:00
* \remarks To run this script as CLI: phpunit filename.php
*/
global $conf,$user,$langs,$db;
//define('TEST_DB_FORCE_TYPE','mysql'); // This is to force using mysql driver
//require_once 'PHPUnit/Autoload.php';
require_once dirname(__FILE__).'/../../htdocs/master.inc.php';
require_once dirname(__FILE__).'/../../htdocs/core/lib/security.lib.php';
require_once dirname(__FILE__).'/../../htdocs/core/lib/security2.lib.php';
2019-01-27 13:07:22 +01:00
if (! defined('NOREQUIREUSER')) define('NOREQUIREUSER', '1');
if (! defined('NOREQUIREDB')) define('NOREQUIREDB', '1');
if (! defined('NOREQUIRESOC')) define('NOREQUIRESOC', '1');
if (! defined('NOREQUIRETRAN')) define('NOREQUIRETRAN', '1');
if (! defined('NOCSRFCHECK')) define('NOCSRFCHECK', '1');
if (! defined('NOTOKENRENEWAL')) define('NOTOKENRENEWAL', '1');
if (! defined('NOREQUIREMENU')) define('NOREQUIREMENU', '1'); // If there is no menu to show
if (! defined('NOREQUIREHTML')) define('NOREQUIREHTML', '1'); // If we don't need to load the html.form.class.php
if (! defined('NOREQUIREAJAX')) define('NOREQUIREAJAX', '1');
if (! defined("NOLOGIN")) define("NOLOGIN", '1'); // If this page is public (can be called outside logged session)
if (empty($user->id))
{
print "Load permissions for admin user nb 1\n";
$user->fetch(1);
$user->getrights();
}
$conf->global->MAIN_DISABLE_ALL_MAILS=1;
/**
* Class for PHPUnit tests
*
* @backupGlobals disabled
* @backupStaticAttributes enabled
* @remarks backupGlobals must be disabled to have db,conf,user and lang not erased.
*/
class CodingSqlTest extends PHPUnit\Framework\TestCase
{
2015-01-06 17:54:36 +01:00
protected $savconf;
protected $savuser;
protected $savlangs;
protected $savdb;
/**
* Constructor
* We save global variables into local variables
*
* @return SecurityTest
*/
2019-02-25 00:56:48 +01:00
public function __construct()
2015-01-06 17:54:36 +01:00
{
2018-09-02 14:10:06 +02:00
parent::__construct();
//$this->sharedFixture
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$this->savconf=$conf;
$this->savuser=$user;
$this->savlangs=$langs;
$this->savdb=$db;
print __METHOD__." db->type=".$db->type." user->id=".$user->id;
//print " - db ".$db->db;
print "\n";
}
2020-05-03 22:47:43 +02:00
/**
* setUpBeforeClass
*
* @return void
*/
2015-01-06 17:54:36 +01:00
public static function setUpBeforeClass()
{
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$db->begin(); // This is to have all actions inside a transaction even if test launched without suite.
2015-01-06 17:54:36 +01:00
print __METHOD__."\n";
}
2015-01-06 17:54:36 +01:00
2020-05-03 22:47:43 +02:00
/**
* tearDownAfterClass
*
* @return void
*/
public static function tearDownAfterClass()
{
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$db->rollback();
2015-01-06 17:54:36 +01:00
print __METHOD__."\n";
}
2015-01-06 17:54:36 +01:00
/**
* Init phpunit tests
*
* @return void
*/
protected function setUp()
{
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$conf=$this->savconf;
$user=$this->savuser;
$langs=$this->savlangs;
$db=$this->savdb;
2015-01-06 17:54:36 +01:00
print __METHOD__."\n";
}
2015-01-06 17:54:36 +01:00
/**
* End phpunit tests
*
* @return void
*/
protected function tearDown()
{
2015-01-06 17:54:36 +01:00
print __METHOD__."\n";
}
/**
* testSql
*
* @return string
*/
public function testSql()
{
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$conf=$this->savconf;
$user=$this->savuser;
$langs=$this->savlangs;
$db=$this->savdb;
$listofsqldir = array(DOL_DOCUMENT_ROOT.'/install/mysql/data', DOL_DOCUMENT_ROOT.'/install/mysql/tables', DOL_DOCUMENT_ROOT.'/install/mysql/migration');
2015-01-06 17:54:36 +01:00
foreach ($listofsqldir as $dir)
{
2015-01-06 17:54:36 +01:00
print 'Process dir '.$dir."\n";
$filesarray = scandir($dir);
2020-05-21 00:02:33 +02:00
foreach ($filesarray as $key => $file)
{
2019-01-27 13:07:22 +01:00
if (! preg_match('/\.sql$/', $file))
2015-01-06 17:54:36 +01:00
continue;
2015-01-06 17:54:36 +01:00
print 'Check sql file '.$file."\n";
$filecontent=file_get_contents($dir.'/'.$file);
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, '`');
2015-01-06 17:54:36 +01:00
print __METHOD__." Result for checking we don't have back quote = ".$result."\n";
$this->assertTrue($result===false, 'Found back quote into '.$file.'. Bad.');
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, '"');
if ($result)
{
2019-01-27 13:07:22 +01:00
$result=(! strpos($filecontent, '["') && ! strpos($filecontent, '{"'));
}
print __METHOD__." Result for checking we don't have double quote = ".$result."\n";
2018-03-08 22:40:42 +01:00
$this->assertTrue($result===false, 'Found double quote that is not [" neither {" (used for json content) into '.$file.'. Bad.');
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, 'int(');
2015-01-06 17:54:36 +01:00
print __METHOD__." Result for checking we don't have 'int(' instead of 'integer' = ".$result."\n";
2016-05-17 20:30:04 +02:00
$this->assertTrue($result===false, 'Found int(x) or tinyint(x) instead of integer or tinyint into '.$file.'. Bad.');
2015-01-06 17:54:36 +01:00
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, 'ON DELETE CASCADE');
2015-01-06 17:54:36 +01:00
print __METHOD__." Result for checking we don't have 'ON DELETE CASCADE' = ".$result."\n";
$this->assertTrue($result===false, 'Found ON DELETE CASCADE into '.$file.'. Bad.');
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, 'NUMERIC(');
2017-07-08 20:52:53 +02:00
print __METHOD__." Result for checking we don't have 'NUMERIC(' = ".$result."\n";
$this->assertTrue($result===false, 'Found NUMERIC( into '.$file.'. Bad.');
$result=strpos($filecontent, 'NUMERIC(');
print __METHOD__." Result for checking we don't have 'curdate(' = ".$result."\n";
$this->assertTrue($result===false, 'Found curdate( into '.$file.'. Bad. Current date must be generated with PHP.');
$result=strpos($filecontent, 'integer(');
print __METHOD__." Result for checking we don't have 'integer(' = ".$result."\n";
$this->assertTrue($result===false, 'Found value in parenthesis after the integer. It must be integer not integer(x) into '.$file.'. Bad.');
if ($dir == DOL_DOCUMENT_ROOT.'/install/mysql/migration')
{
// Test for migration files only
2020-05-21 15:13:31 +02:00
} elseif ($dir == DOL_DOCUMENT_ROOT.'/install/mysql/data')
{
// Test for data files only
2020-05-21 15:13:31 +02:00
} else {
2019-01-27 13:07:22 +01:00
if (preg_match('/\.key\.sql$/', $file))
{
// Test for key files only
2020-05-21 15:13:31 +02:00
} else {
// Test for non key files only
2019-01-27 13:07:22 +01:00
$result=(strpos($filecontent, 'KEY ') && strpos($filecontent, 'PRIMARY KEY') == 0);
print __METHOD__." Result for checking we don't have ' KEY ' instead of a sql file to create index = ".$result."\n";
$this->assertTrue($result===false, 'Found KEY into '.$file.'. Bad.');
2019-01-27 13:07:22 +01:00
$result=stripos($filecontent, 'ENGINE=innodb');
print __METHOD__." Result for checking we have the ENGINE=innodb string = ".$result."\n";
$this->assertGreaterThan(0, $result, 'The ENGINE=innodb was not found into '.$file.'. Add it or just fix syntax to match case.');
}
}
2015-01-06 17:54:36 +01:00
}
}
return;
}
/**
* testInitData
*
* @return string
*/
public function testInitData()
{
2015-01-06 17:54:36 +01:00
global $conf,$user,$langs,$db;
$conf=$this->savconf;
$user=$this->savuser;
$langs=$this->savlangs;
$db=$this->savdb;
$filesarray = scandir(DOL_DOCUMENT_ROOT.'/../dev/initdemo');
2020-05-21 00:02:33 +02:00
foreach ($filesarray as $key => $file) {
2019-01-27 13:07:22 +01:00
if (! preg_match('/\.sql$/', $file))
2015-01-06 17:54:36 +01:00
continue;
print 'Check sql file '.$file."\n";
$filecontent=file_get_contents(DOL_DOCUMENT_ROOT.'/../dev/initdemo/'.$file);
2015-01-06 17:54:36 +01:00
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, '@gmail.com');
2015-01-06 17:54:36 +01:00
print __METHOD__." Result for checking we don't have personal data = ".$result."\n";
$this->assertTrue($result===false, 'Found a bad key @gmail into file '.$file);
2015-01-06 17:54:36 +01:00
2019-01-27 13:07:22 +01:00
$result=strpos($filecontent, 'eldy@');
2015-01-06 17:54:36 +01:00
print __METHOD__." Result for checking we don't have personal data = ".$result."\n";
$this->assertTrue($result===false, 'Found a bad key eldy@ into file '.$file);
2015-01-06 17:54:36 +01:00
}
return;
}
}