Scott Taylor
|
9ce58d9d86
|
Site Icon: There is no good reason for class-wp-site-icon.php to drop a global instance of itself whenever the file is loaded. The lone use of the global instance of WP_Site_Icon is in an AJAX action that provides virtually no way to override - the file is loaded immediately before the global is used.
Let us remove the `$wp_site_icon` global. I will fall on the sword if this comes back to bite us (waiting with bated breath).
See #37699.
Built from https://develop.svn.wordpress.org/trunk@38355
git-svn-id: http://core.svn.wordpress.org/trunk@38296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 19:09:35 +00:00 |
|
Scott Taylor
|
ed0da659bc
|
Feed: move 'WP_Feed_Cache', 'WP_Feed_Cache_Transient', WP_SimplePie_File and WP_SimplePie_Sanitize_KSES into their own files via svn cp. If we move forard with autoloading, class-feed.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem. class-feed.php is an interesting name: there is no Feed or WP_Feed class.
See #37827.
Built from https://develop.svn.wordpress.org/trunk@38354
git-svn-id: http://core.svn.wordpress.org/trunk@38295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 18:18:39 +00:00 |
|
Scott Taylor
|
3d26e3513e
|
Session: move WP_Session_Tokens and WP_User_Meta_Session_Tokens into their own files via svn cp. If we move forard with autoloading, session.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem.
See #37827.
Built from https://develop.svn.wordpress.org/trunk@38353
git-svn-id: http://core.svn.wordpress.org/trunk@38294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 17:44:31 +00:00 |
|
Scott Taylor
|
6620e0b3cc
|
Diff: move WP_Text_Diff_Renderer_inline (behold that lowercase "i") and WP_Text_Diff_Renderer_Table into their own files via svn cp.
See #37827.
Built from https://develop.svn.wordpress.org/trunk@38352
git-svn-id: http://core.svn.wordpress.org/trunk@38293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 17:37:30 +00:00 |
|
Scott Taylor
|
d5f28fdad8
|
Query: move WP_Query into its own file via svn cp.
See #37827.
Built from https://develop.svn.wordpress.org/trunk@38351
git-svn-id: http://core.svn.wordpress.org/trunk@38292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 17:20:38 +00:00 |
|
Drew Jaynes
|
f07f1b126e
|
Docs: Add a missing parenthesis in an example in the DocBlock for wp_redirect().
Props shayanys.
See #37770.
Built from https://develop.svn.wordpress.org/trunk@38350
git-svn-id: http://core.svn.wordpress.org/trunk@38291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 07:36:31 +00:00 |
|
Andrew Ozz
|
15edc78f6f
|
TinyMCE: fix toolbars alignment in RTL.
Fixes #37760 for trunk.
Built from https://develop.svn.wordpress.org/trunk@38349
git-svn-id: http://core.svn.wordpress.org/trunk@38290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-25 01:20:30 +00:00 |
|
Sergey Biryukov
|
2cc42e5dbb
|
Docs: Improve the docs for the_title() and make them more consistent with the_title_attribute().
Props ixkaito, swissspidy.
Fixes #37732.
Built from https://develop.svn.wordpress.org/trunk@38348
git-svn-id: http://core.svn.wordpress.org/trunk@38289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-24 15:59:29 +00:00 |
|
Sergey Biryukov
|
b79713c1b0
|
Administration: Underline links in the admin footer for better accessibility.
Props Presskopp.
Fixes #37529.
Built from https://develop.svn.wordpress.org/trunk@38347
git-svn-id: http://core.svn.wordpress.org/trunk@38288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-24 15:43:31 +00:00 |
|
Sergey Biryukov
|
d611efe5b1
|
I18N: Add translator comments for strings in wp-includes/functions.wp-scripts.php.
Props ramiy.
Fixes #37803.
Built from https://develop.svn.wordpress.org/trunk@38345
git-svn-id: http://core.svn.wordpress.org/trunk@38286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:53:27 +00:00 |
|
Sergey Biryukov
|
d64e4beb67
|
I18N: Add translator comments for strings in wp-includes/functions.php.
Props ramiy.
Fixes #37802.
Built from https://develop.svn.wordpress.org/trunk@38344
git-svn-id: http://core.svn.wordpress.org/trunk@38285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:48:28 +00:00 |
|
Sergey Biryukov
|
51e1539ab7
|
I18N: Add translator comments for strings in wp-includes/deprecated.php.
Props ramiy.
Fixes #37797.
Built from https://develop.svn.wordpress.org/trunk@38343
git-svn-id: http://core.svn.wordpress.org/trunk@38284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:36:28 +00:00 |
|
Sergey Biryukov
|
eb9cc0c13e
|
I18N: Add translator comments for strings in wp-includes/class-walker-comment.php.
Merge two similar strings.
Props ramiy.
Fixes #37796.
Built from https://develop.svn.wordpress.org/trunk@38342
git-svn-id: http://core.svn.wordpress.org/trunk@38283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:33:28 +00:00 |
|
Sergey Biryukov
|
420b733958
|
I18N: Add translator comments for strings in wp-includes/author-template.php.
Props ramiy.
Fixes #37795.
Built from https://develop.svn.wordpress.org/trunk@38341
git-svn-id: http://core.svn.wordpress.org/trunk@38282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:18:29 +00:00 |
|
Sergey Biryukov
|
ce4c0d67dc
|
I18N: Add translator comments for strings in wp-includes/admin-bar.php.
Props ramiy.
Fixes #37794.
Built from https://develop.svn.wordpress.org/trunk@38340
git-svn-id: http://core.svn.wordpress.org/trunk@38281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 23:05:31 +00:00 |
|
Scott Taylor
|
bd816e5182
|
Taxonomy: in get_terms(), do not assume that legacy args are being passed when the only params are top-level meta_* values. Add keys in WP_Term_Query::__construct().
Adds unit tests.
Props flixos90, boonebgorges.
Fixes #37568.
Built from https://develop.svn.wordpress.org/trunk@38337
git-svn-id: http://core.svn.wordpress.org/trunk@38278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:45:28 +00:00 |
|
Scott Taylor
|
af1fb6b8d2
|
Query: use correct description in the docblock for $number in WP_Comment_Query, WP_Network_Query, and WP_Site_Query.
Props flixos90.
Fixes #37621.
Built from https://develop.svn.wordpress.org/trunk@38336
git-svn-id: http://core.svn.wordpress.org/trunk@38277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:41:29 +00:00 |
|
Scott Taylor
|
d6145020ae
|
Cache: in WP_Object_Cache, $cache_misses is public, but $cache_hits is private. They should both be public, because they're useful for debugging purposes.
Props danielbachhuber.
Fixes #37726.
Built from https://develop.svn.wordpress.org/trunk@38335
git-svn-id: http://core.svn.wordpress.org/trunk@38276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:38:29 +00:00 |
|
Scott Taylor
|
b7812bd416
|
AJAX: add a new function, wp_doing_ajax(), which can replace... (wait for it...) DOING_AJAX checks via the constant.
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.
Built from https://develop.svn.wordpress.org/trunk@38334
git-svn-id: http://core.svn.wordpress.org/trunk@38275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:33:30 +00:00 |
|
Scott Taylor
|
6f9f3b0c56
|
Media: remove function_exists() call for ini_get() in _load_image_to_edit_path().
Props dd32.
Fixes #37681.
Built from https://develop.svn.wordpress.org/trunk@38333
git-svn-id: http://core.svn.wordpress.org/trunk@38274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:24:30 +00:00 |
|
Sergey Biryukov
|
0955ea66da
|
WP Mail: If post-by-email functionality is disabled, wp-mail.php should return a 403 Forbidden status code instead if 500 Internal Server Error.
Props Presskopp, tomdxw.
Fixes #37572.
Built from https://develop.svn.wordpress.org/trunk@38332
git-svn-id: http://core.svn.wordpress.org/trunk@38273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 14:02:39 +00:00 |
|
Boone Gorges
|
6ccd3f4795
|
Tests: Fix incorrect variable name from [38330].
See #37630.
Built from https://develop.svn.wordpress.org/trunk@38331
git-svn-id: http://core.svn.wordpress.org/trunk@38272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 13:49:33 +00:00 |
|
Boone Gorges
|
70077ce076
|
Tests: Attachment create() method should match signature of other create() methods.
Legacy argument format continues to be accepted.
Props bcole808.
See #37630.
Built from https://develop.svn.wordpress.org/trunk@38330
git-svn-id: http://core.svn.wordpress.org/trunk@38271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 13:43:41 +00:00 |
|
Sergey Biryukov
|
ec8f0281fa
|
I18N: Remove unnecessary context for two strings on "Add New User" screen.
Props ramiy.
Fixes #37784.
Built from https://develop.svn.wordpress.org/trunk@38329
git-svn-id: http://core.svn.wordpress.org/trunk@38270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 12:54:31 +00:00 |
|
Andrew Ozz
|
08d59c211c
|
TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image.
Props fomenkoandrey for reporting and testing.
Fixes #37467.
Built from https://develop.svn.wordpress.org/trunk@38328
git-svn-id: http://core.svn.wordpress.org/trunk@38269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 04:43:31 +00:00 |
|
Sergey Biryukov
|
35e3d7e37f
|
I18N: Remove unnecessary context in wp_post_revision_title_expanded().
Props ramiy.
Fixes #37781.
Built from https://develop.svn.wordpress.org/trunk@38327
git-svn-id: http://core.svn.wordpress.org/trunk@38268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 01:46:31 +00:00 |
|
Sergey Biryukov
|
64dac53d70
|
I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar).
Props ramiy.
Fixes #37780.
Built from https://develop.svn.wordpress.org/trunk@38326
git-svn-id: http://core.svn.wordpress.org/trunk@38267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 01:42:32 +00:00 |
|
Sergey Biryukov
|
92343be1f4
|
I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized.
Props ramiy.
Fixes #37501.
Built from https://develop.svn.wordpress.org/trunk@38325
git-svn-id: http://core.svn.wordpress.org/trunk@38266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 01:19:39 +00:00 |
|
Sergey Biryukov
|
372a19a435
|
I18N: Replace unnecessary context with translator comments in wp_post_revision_title() and wp_post_revision_title_expanded().
Props ramiy.
Fixes #37778.
Built from https://develop.svn.wordpress.org/trunk@38324
git-svn-id: http://core.svn.wordpress.org/trunk@38265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 00:35:28 +00:00 |
|
Sergey Biryukov
|
fee26cf741
|
I18N: Replace unnecessary context with a translator comment for %s Sites string in network_step1().
Props ramiy.
Fixes #37777.
Built from https://develop.svn.wordpress.org/trunk@38323
git-svn-id: http://core.svn.wordpress.org/trunk@38264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 00:17:27 +00:00 |
|
Sergey Biryukov
|
96bdd4737c
|
I18N: Replace unnecessary context with a translator comment for %s KB string on Network Settings screen.
Props ramiy.
Fixes #37496.
Built from https://develop.svn.wordpress.org/trunk@38322
git-svn-id: http://core.svn.wordpress.org/trunk@38263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 00:11:28 +00:00 |
|
Sergey Biryukov
|
c86199ddb2
|
Embeds: In get_oembed_endpoint_url(), avoid inadvertent stomping of the $format parameter passed to oembed_endpoint_url filter.
Props danhgilmore.
Fixes #37751.
Built from https://develop.svn.wordpress.org/trunk@38321
git-svn-id: http://core.svn.wordpress.org/trunk@38262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-23 00:05:30 +00:00 |
|
Sergey Biryukov
|
44aac380f4
|
I18N: Add translator comments for Edit Site: %s string in network admin.
Props ramiy.
Fixes #37776.
Built from https://develop.svn.wordpress.org/trunk@38320
git-svn-id: http://core.svn.wordpress.org/trunk@38261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 23:53:31 +00:00 |
|
Scott Taylor
|
b55b6a03f4
|
Users: after [38317], use a @property annotation, instead of a public field.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38319
git-svn-id: http://core.svn.wordpress.org/trunk@38260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 22:15:29 +00:00 |
|
Scott Taylor
|
1119536085
|
Widgets: $option_name and $alt_option_name have been used as members ever since WP_Widget became an object in 2.8, but never declared.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38318
git-svn-id: http://core.svn.wordpress.org/trunk@38259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:51:28 +00:00 |
|
Scott Taylor
|
7466118616
|
Users: $user_level has been publicly-accessed on instances of WP_User since version 2.0, but is has never been declared.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38317
git-svn-id: http://core.svn.wordpress.org/trunk@38258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:41:28 +00:00 |
|
Scott Taylor
|
d3312bc278
|
Locale: declare the $month_genitive field on WP_Locale.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38316
git-svn-id: http://core.svn.wordpress.org/trunk@38257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:33:28 +00:00 |
|
Scott Taylor
|
b0fa9aac6b
|
HTTP: in WP_HTTP_Response, the @param declarations for $status and $headers were swapped. Let us correct this.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38315
git-svn-id: http://core.svn.wordpress.org/trunk@38256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:28:27 +00:00 |
|
Scott Taylor
|
ca70683001
|
Database: WP_Network, WP_Network_Query, and WP_Site_Query call wpdb::_escape(), thus requiring it to be public. It previously had no access modifier. _ at the beginning of a method, believe it or not, does not enforce visibility constraints.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38314
git-svn-id: http://core.svn.wordpress.org/trunk@38255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:10:28 +00:00 |
|
Scott Taylor
|
dcb0261664
|
Comments: in wp_handle_comment_submission(), $_wp_unfiltered_html_comment is passed as part of $comment_data, but is not used locally.
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38313
git-svn-id: http://core.svn.wordpress.org/trunk@38254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:04:28 +00:00 |
|
Scott Taylor
|
3755823702
|
Taxonomy: remove unnecessary break in WP_Term::__get().
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38312
git-svn-id: http://core.svn.wordpress.org/trunk@38253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 21:00:30 +00:00 |
|
Scott Taylor
|
5025f72fd3
|
Nav Menus: remove unnecessary variable assignment in wp_nav_menu_item_post_type_meta_box().
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38311
git-svn-id: http://core.svn.wordpress.org/trunk@38252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 20:58:28 +00:00 |
|
Scott Taylor
|
778d794e4f
|
REST API: remove unnecessary variable assignments in rest_handle_options_request().
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38310
git-svn-id: http://core.svn.wordpress.org/trunk@38251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 20:56:28 +00:00 |
|
Scott Taylor
|
a017516291
|
Media: remove unnecessary variable assignment in gallery_shortcode().
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38309
git-svn-id: http://core.svn.wordpress.org/trunk@38250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 20:53:29 +00:00 |
|
Scott Taylor
|
7b30193bb7
|
General: remove variable set needlessly in wp_check_jsonp_callback().
See #37771.
Built from https://develop.svn.wordpress.org/trunk@38308
git-svn-id: http://core.svn.wordpress.org/trunk@38249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 20:51:30 +00:00 |
|
Drew Jaynes
|
22adda2aa0
|
Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.
Props ramiy.
See #37748.
Built from https://develop.svn.wordpress.org/trunk@38307
git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 18:25:31 +00:00 |
|
Sergey Biryukov
|
02939c03e5
|
Common CSS: Allow for .nav-tab-wrapper class to be used on elements other than h3 to increase flexibility for custom settings pages.
Props ramiy, afercia.
Fixes #37257.
Built from https://develop.svn.wordpress.org/trunk@38306
git-svn-id: http://core.svn.wordpress.org/trunk@38247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 16:33:30 +00:00 |
|
Sergey Biryukov
|
26d7a5607b
|
Multisite: Fix copy/paste issue in id attribute for a dismissible message on Sites screen.
Props imath.
Fixes #37764.
Built from https://develop.svn.wordpress.org/trunk@38305
git-svn-id: http://core.svn.wordpress.org/trunk@38246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 14:22:31 +00:00 |
|
Scott Taylor
|
cd6d2bae92
|
Login: retrieve_password() does not need to import 2 globals that it does not use.
See #37699.
Built from https://develop.svn.wordpress.org/trunk@38304
git-svn-id: http://core.svn.wordpress.org/trunk@38245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 04:48:28 +00:00 |
|
Scott Taylor
|
d31456b615
|
Media: add a function, wp_get_additional_image_sizes(), that wraps the retrieval of the global $_wp_additional_image_sizes. Removes 6 global imports.
See #37699.
Built from https://develop.svn.wordpress.org/trunk@38303
git-svn-id: http://core.svn.wordpress.org/trunk@38244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2016-08-22 04:37:28 +00:00 |
|