Adam Silverstein
0e5e765a1b
Revisions: improve display responsiveness, especially on smaller screen sizes.
...
* Fix an overlap issue with the "Restore this Revision" button that made it difficult to use on phone sized devices.
Props ryan, PranaliPatel, karinedo.
Fixes #33830 .
Built from https://develop.svn.wordpress.org/trunk@44781
git-svn-id: http://core.svn.wordpress.org/trunk@44613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 20:11:50 +00:00
Sergey Biryukov
43324cec8b
Users: Replace raw SQL query in check_password_reset_key() with get_user_by().
...
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845 .
Built from https://develop.svn.wordpress.org/trunk@44780
git-svn-id: http://core.svn.wordpress.org/trunk@44612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 14:39:50 +00:00
Sergey Biryukov
e57fcaeeee
Privacy: Escape Privacy Policy guide URL in in Privacy Policy edit page notice.
...
Props itowhid06, garrett-eclipse.
Fixes #44761 .
Built from https://develop.svn.wordpress.org/trunk@44779
git-svn-id: http://core.svn.wordpress.org/trunk@44611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 12:08:49 +00:00
Sergey Biryukov
cfc9a60243
Privacy: Improve translator comments for Privacy Policy page links in Privacy Settings; escape URLs.
...
Props birgire, garrett-eclipse.
Fixes #46369 .
Built from https://develop.svn.wordpress.org/trunk@44778
git-svn-id: http://core.svn.wordpress.org/trunk@44610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 12:01:50 +00:00
Sergey Biryukov
abf27c3b62
Privacy: Return a more accurate error message when the user cannot perform the requested action.
...
Props mmuhsin, jplojohn, garrett-eclipse, desrosj.
Fixes #44833 .
Built from https://develop.svn.wordpress.org/trunk@44777
git-svn-id: http://core.svn.wordpress.org/trunk@44609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 11:49:51 +00:00
Sergey Biryukov
c78d28d9f1
Login and Registration: Update URLs for browser cookie documentation.
...
Props joostdevalk.
Fixes #46254 .
Built from https://develop.svn.wordpress.org/trunk@44776
git-svn-id: http://core.svn.wordpress.org/trunk@44608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 11:44:52 +00:00
Sergey Biryukov
acaa0422f1
Privacy: Change "Email Data" link text on "Export Personal Data" screen to "Send Export Link" for clarity.
...
Previously: [43172], accidentally reverted in [43212].
Props birgire, ianbelanger.
Fixes #44822 . See #43964 .
Built from https://develop.svn.wordpress.org/trunk@44775
git-svn-id: http://core.svn.wordpress.org/trunk@44607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 11:37:51 +00:00
Sergey Biryukov
60c217f531
Twenty Nineteen: Remove stray ÷ character in print.css.
...
Props mukesh27, laurelfulford.
Fixes #46083 .
Built from https://develop.svn.wordpress.org/trunk@44774
git-svn-id: http://core.svn.wordpress.org/trunk@44606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 02:47:51 +00:00
Sergey Biryukov
f7f806b5ef
Twenty Nineteen: Update style-rtl.css after [44657].
...
See #45731 .
Built from https://develop.svn.wordpress.org/trunk@44773
git-svn-id: http://core.svn.wordpress.org/trunk@44605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 02:44:49 +00:00
Sergey Biryukov
d68f13cbc8
Docs: Add missing WP_Customize_Control reference to WP_Customize_Nav_Menu_Control and WP_Customize_Nav_Menu_Item_Control DocBlocks.
...
Props aniketpatel.
Fixes #46077 .
Built from https://develop.svn.wordpress.org/trunk@44772
git-svn-id: http://core.svn.wordpress.org/trunk@44604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 02:07:51 +00:00
Sergey Biryukov
f0a9df1aa2
Twenty Nineteen: Avoid nested comment author links in TwentyNineteen_Walker_Comment::html5_comment().
...
Props iamdmitrymayorov, mukesh27.
Fixes #46291 .
Built from https://develop.svn.wordpress.org/trunk@44771
git-svn-id: http://core.svn.wordpress.org/trunk@44603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-28 01:55:50 +00:00
desrosj
e37950c0dc
Help/About: Fix mismatched opening/closing tags.
...
The 5.1 About page contains some invalid HTML markup.
Props bulletdigital.
Fixes #46319 .
Built from https://develop.svn.wordpress.org/trunk@44769
git-svn-id: http://core.svn.wordpress.org/trunk@44601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-26 15:39:55 +00:00
desrosj
67e811c15e
Build: Minify images
...
After `grunt-contrib-imagemin` was upgraded in WordPress 5.0, the `grunt precommit:image` task results in further minifications to `loading.gif`.
Fixes #46295 .
Built from https://develop.svn.wordpress.org/trunk@44768
git-svn-id: http://core.svn.wordpress.org/trunk@44600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-25 15:21:52 +00:00
Andrea Fercia
adc7f9fe54
Accessibility: Improve the image and gallery widgets preview accessibility.
...
In an authoring context, the image `alt` attribute purpose is different from the one for the front end. For example, screen reader users need to know what the selected image is, even when the original `alt` value is empty.
This change introduces a new pattern for the `alt` text in an authoring context:
- uses the `alt` text if not empty
- when there's no `alt` text, informs users the image has no alternative text and provides a reference to the image filename
Also, makes the gallery media widget preview an unordered list to make screen readers announce the number of images automatically.
Fixes #43137 .
Built from https://develop.svn.wordpress.org/trunk@44767
git-svn-id: http://core.svn.wordpress.org/trunk@44599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-23 18:32:53 +00:00
Aaron Jorbin
029fcf7791
Script Loader: Load fakejshint as jshint due to "good and evil".
...
Originally fixed in [42547]. Broken in [44163]. We've been here before. I recognize that tree.
Fixes #46299
Built from https://develop.svn.wordpress.org/trunk@44762
git-svn-id: http://core.svn.wordpress.org/trunk@44594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-21 21:19:50 +00:00
Gary Pendergast
3825e94d43
Upgrades: Update $_old_files for WordPress 5.1.
...
`wp-includes/random_compat/random_bytes_openssl.php` was removed in [43130], this commit updates `$_old_files` to match.
Fixes #46284 .
Built from https://develop.svn.wordpress.org/trunk@44760
git-svn-id: http://core.svn.wordpress.org/trunk@44592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-21 04:35:50 +00:00
Andrea Fercia
6fe48278ea
Accessibility: Comments: Improve links and buttons semantics and interaction.
...
With the exception of the "Edit" link, the "row actions" controls in the Comments table behave differently depending if JavaScript support is on or off.
When JavaScript support is off, they behave like links. When JavaScript support is on, they behave like buttons and they need to be buttons or have an ARIA `role="button"` added via JavaScript.
Lastly, the buttons in the Reply/Quick Edit form and the "Add Comment" in the edit post page meta box need to be buttons.
Fixes #43412 .
Built from https://develop.svn.wordpress.org/trunk@44759
git-svn-id: http://core.svn.wordpress.org/trunk@44591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-20 23:37:50 +00:00
Andrea Fercia
2cbb1bd95e
Accessibility: General Settings: Update custom date/time format previews while typing.
...
The custom date/time format previews in General Settings were updated only when blurring the related input fields. With this change, they're now updated when users finish typing a custom format, properly debouncing the `input` event callback.
Props dilipbheda, Girishpanchal.
Fixes #43364 .
Built from https://develop.svn.wordpress.org/trunk@44758
git-svn-id: http://core.svn.wordpress.org/trunk@44590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-20 22:56:50 +00:00
Andrea Fercia
7f977760a1
Accessibility: Improve buttons placement in the Comments Quick edit/Reply form.
...
Proximity of related information is an inclusive design principle that benefits everyone and it's particularly important for users with reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close to each other.
Also, this change makes the buttons visual order and the DOM order match.
Fixes #45972 .
Built from https://develop.svn.wordpress.org/trunk@44757
git-svn-id: http://core.svn.wordpress.org/trunk@44589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-20 22:09:50 +00:00
Andrea Fercia
34b3b388fd
Accessibility: Remove unnecessary fieldset and legend elements from the User Profile page.
...
Also fixes a CSS margin issue in the mobile view.
Props punit5658.
Fixes #46093 .
Built from https://develop.svn.wordpress.org/trunk@44756
git-svn-id: http://core.svn.wordpress.org/trunk@44588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-20 19:03:51 +00:00
Boone Gorges
b44877f0da
Taxonomy: Remove @ignore annotation on _get_term_hierarchy().
...
Originally introduced in [32453], the `@ignore` annotation caused the
function to be improperly ignored by the Code Reference parser.
The `@access private` annotation is the correct way to mark a
function for internal use only.
Props coffee2code.
Fixes #45997 .
Built from https://develop.svn.wordpress.org/trunk@44755
git-svn-id: http://core.svn.wordpress.org/trunk@44587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-19 20:24:50 +00:00
Gary Pendergast
a7ef0feac0
Admin: Update the About page design to match mockups.
...
This commit also moves the images to s.w.org, removes the old "Gutenberg has been deactivated" warning, as well as removing some old JS from About pages of years gone past.
Props melchoyce, ryelle, paaljoachim, karmatosed, pento.
Fixes #46161 .
Built from https://develop.svn.wordpress.org/trunk@44749
git-svn-id: http://core.svn.wordpress.org/trunk@44581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-19 01:57:52 +00:00
Peter Wilson
1b2f7d862c
Comments: Fix backward compatibility regressions in comment reply JavaScript.
...
Adds a `MutationObserver` to `comment-reply.js` to allow for lazy-loaded comments to continue working without the need to re-initialize the comment form.
Props Pento.
Fixes #46260 .
Built from https://develop.svn.wordpress.org/trunk@44748
git-svn-id: http://core.svn.wordpress.org/trunk@44580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-18 04:27:50 +00:00
Gary Pendergast
82859e2641
Accessibility: Fix a regression in the old media modal pagination links.
...
[43019] improved the table pagination link styling, but introduced a regression in the old media dialog.
Props afercia, joneiseman.
Fixes #41858 .
Built from https://develop.svn.wordpress.org/trunk@44747
git-svn-id: http://core.svn.wordpress.org/trunk@44579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-17 22:24:52 +00:00
Peter Wilson
97cb237548
Trunk is now 5.2-alpha.
...
Update package.json missed in [44742].
Built from https://develop.svn.wordpress.org/trunk@44746
git-svn-id: http://core.svn.wordpress.org/trunk@44578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-14 00:54:51 +00:00
Peter Wilson
408908979c
Build: Fix formatting issues introduced in [44740].
...
See #46218 .
Built from https://develop.svn.wordpress.org/trunk@44744
git-svn-id: http://core.svn.wordpress.org/trunk@44576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-14 00:42:48 +00:00
Peter Wilson
2317cd8398
Trunk is now 5.2-alpha.
...
Built from https://develop.svn.wordpress.org/trunk@44742
git-svn-id: http://core.svn.wordpress.org/trunk@44574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-14 00:13:50 +00:00
Peter Wilson
a51ca641ec
Build: Remove source map from jquery.form.min.js.
...
Minimize jquery.form.js as part of build process to remove the source map reference.
Modify source map tests to include all JavaScript files rather than testing Backbone and jQuery only.
Props pento.
Fixes #46218 .
Built from https://develop.svn.wordpress.org/trunk@44740
git-svn-id: http://core.svn.wordpress.org/trunk@44572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-14 00:07:49 +00:00
laurelfulford
fd8a3db97b
Twenty Nineteen: Update the quote block styles.
...
Update the theme's quote block border styles, so they will work better with the updated styles for the quote block, coming in Gutenberg 5.2.
Props @kjellr.
Fixes #46239 .
Built from https://develop.svn.wordpress.org/trunk@44739
git-svn-id: http://core.svn.wordpress.org/trunk@44571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-13 18:40:49 +00:00
Dominik Schilling
dc8e9c6de0
Upgrade/Install: Update character count for the $table_prefix config line after [43650] and [42343].
...
Fixes #46220 .
Built from https://develop.svn.wordpress.org/trunk@44738
git-svn-id: http://core.svn.wordpress.org/trunk@44570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-12 16:52:53 +00:00
Gary Pendergast
0fa4a52255
Post WordPress 5.1 RC1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@44737
git-svn-id: http://core.svn.wordpress.org/trunk@44569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 02:23:49 +00:00
Gary Pendergast
3d4a251a0e
WordPress 5.1 RC1.
...
Built from https://develop.svn.wordpress.org/trunk@44736
git-svn-id: http://core.svn.wordpress.org/trunk@44568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 02:14:48 +00:00
Peter Wilson
729c8e875f
Admin: Improve logic of PHP version check on about page.
...
Props noisysocks, peterwilsoncc.
See #46161 .
Built from https://develop.svn.wordpress.org/trunk@44735
git-svn-id: http://core.svn.wordpress.org/trunk@44567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 01:53:51 +00:00
Gary Pendergast
e24bf1c278
Admin: Fix code formatting issues in the About page.
...
See #46161 .
Built from https://develop.svn.wordpress.org/trunk@44734
git-svn-id: http://core.svn.wordpress.org/trunk@44566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 01:28:50 +00:00
Gary Pendergast
7370de8023
Admin: Initial version of the WordPress 5.1 About page.
...
This includes the final strings, the design will continue to iterate.
Props mcsf, noisysocks, melchoyce, azaozz, afragen, JeffPaul, peterwilsoncc, andreamiddleton.
See #46161 .
Built from https://develop.svn.wordpress.org/trunk@44733
git-svn-id: http://core.svn.wordpress.org/trunk@44565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 01:25:51 +00:00
Peter Wilson
c4505be534
Install/upgrade: Remove Gutenberg plugin deactivation from upgrade process.
...
The Gutenberg plugin will not be deactivated on sites upgrading to WordPress 5.1. This deprecates the `upgrade_500_was_gutenberg_active` option and the `upgrade_500()` function as they are no longer required.
Props peterwilsoncc.
Fixes #46029 .
Built from https://develop.svn.wordpress.org/trunk@44732
git-svn-id: http://core.svn.wordpress.org/trunk@44563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-08 00:16:50 +00:00
Gary Pendergast
cddee8b72e
Formatting: Loosen the type checking in _sanitize_text_fields().
...
[44618] added strict type checking to `_sanitize_text_fields()`, which has caused some compat issues with plugins.
We can loosen the type checking to only reject objects and arrays, and cast other types to string.
Props Nick_theGeek, pento.
Fixes #41450 .
Built from https://develop.svn.wordpress.org/trunk@44731
git-svn-id: http://core.svn.wordpress.org/trunk@44562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 23:35:49 +00:00
laurelfulford
a1eceec5bd
Default Themes: Bump the version numbers and release dates.
...
Update the theme versions and release dates for the default themes, in time for WordPress 5.1.
The POT files for Twenty Eleven and Twenty Ten have also been updated.
Fixes #46070 .
Built from https://develop.svn.wordpress.org/trunk@44730
git-svn-id: http://core.svn.wordpress.org/trunk@44561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 23:23:50 +00:00
youknowriad
a89b6c042d
Block Editor: Update WordPress Packages to solve PHP 5.2.2 parser incompatibility.
...
Updated:
- @wordpress/block-library@2.2.16
- @wordpress/block-serialization-default-parser@2.0.5
- @wordpress/blocks@6.0.7
- @wordpress/edit-post@3.1.11
- @wordpress/editor@9.0.11
- @wordpress/format-library@1.2.14
Props pento.
Fixes #46200 .
Built from https://develop.svn.wordpress.org/trunk@44729
git-svn-id: http://core.svn.wordpress.org/trunk@44560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 09:02:49 +00:00
Gary Pendergast
95d5aa0e97
Build: Update package.json dependencies to match Gutenberg.
...
Props wpscholar, azaozz, gziolo.
Fixes #46039 .
Built from https://develop.svn.wordpress.org/trunk@44728
git-svn-id: http://core.svn.wordpress.org/trunk@44559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 06:28:03 +00:00
Gary Pendergast
c2c021baf1
Multisite: After creating a new blog, ensure the blog cache is correctly cleaned up.
...
Props david.binda, spacedmonkey.
Fixes #46125 .
Built from https://develop.svn.wordpress.org/trunk@44727
git-svn-id: http://core.svn.wordpress.org/trunk@44558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 06:04:51 +00:00
Gary Pendergast
bbbf0ee62e
Admin: Re-add some validation from [44048] that was accidentally removed in [44165].
...
Props david.binda.
See #45037 .
Built from https://develop.svn.wordpress.org/trunk@44726
git-svn-id: http://core.svn.wordpress.org/trunk@44557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 04:12:51 +00:00
desrosj
2d1d80f4c5
Themes: Revert returning the value of locate_template() in functions that call it.
...
Because the names of the `get_header()`, `get_footer()`, `get_sidebar()`, and `get_template_part()` functions indicate that a value is returned, some plugins and themes already have `echo get_template_part()` in their codebase. Adding a return value to these functions using the approach in [44678] will cause the two unintended side effects of unexpected content being sent to the browser, and accidental path disclosure.
Reverts [44678].
Props davidbinda.
See #40969 .
Built from https://develop.svn.wordpress.org/trunk@44725
git-svn-id: http://core.svn.wordpress.org/trunk@44556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-06 18:37:51 +00:00
Andrew Ozz
5b6a1ad3b2
TinyMCE: fix color of highlighted drop-down menu items in Classic Block.
...
Fixes #46164 .
Built from https://develop.svn.wordpress.org/trunk@44724
git-svn-id: http://core.svn.wordpress.org/trunk@44555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-05 17:47:55 +00:00
Sergey Biryukov
ee8c3deaa5
Build/Test Tools: Display a message about currently supported PHPUnit branch to avoid fatal errors on later versions.
...
See #46149 .
Built from https://develop.svn.wordpress.org/trunk@44723
git-svn-id: http://core.svn.wordpress.org/trunk@44554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-03 22:41:53 +00:00
Peter Wilson
f5cab6780f
Administration: Save column visibility on small screens.
...
Modifies the jQuery selector for determining hidden columns to ensure they are detected when the expanded columns details are closed.
Adds high-specificity selectors specifically for setting screen options in the comments and plugins lists.
Props afercia.
Fixes #46005 .
Built from https://develop.svn.wordpress.org/trunk@44722
git-svn-id: http://core.svn.wordpress.org/trunk@44553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-01 02:14:51 +00:00
Gary Pendergast
60ddb6012e
Post WordPress 5.1 Beta 3 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@44721
git-svn-id: http://core.svn.wordpress.org/trunk@44552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-31 03:32:51 +00:00
Gary Pendergast
60d36c140a
WordPress 5.1 Beta 3.
...
Built from https://develop.svn.wordpress.org/trunk@44720
git-svn-id: http://core.svn.wordpress.org/trunk@44551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-31 03:17:51 +00:00
Sergey Biryukov
61a7dc1277
Build/Test Tools: Move WP_UnitTestCase_Base::assertPostConditions() to a more appropriate place.
...
See #43218 .
Built from https://develop.svn.wordpress.org/trunk@44719
git-svn-id: http://core.svn.wordpress.org/trunk@44550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 14:31:51 +00:00
Andrew Ozz
02adaaf90c
TinyMCE: fix external references in wpview and wpemoji plugins in the Classic Block instance when running from /build.
...
Fixes #46147 .
Built from https://develop.svn.wordpress.org/trunk@44718
git-svn-id: http://core.svn.wordpress.org/trunk@44549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 14:12:52 +00:00