From f5f05eb2ccfd15481d5cbf8eef6a46d8e8d8798f Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Tue, 26 Apr 2022 11:25:08 +0000 Subject: [PATCH] Code Modernization: Rename parameters that use reserved keywords in `wp-includes/class-wp-image-editor-gd.php`. While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names. This commit renames the `$function` parameter to `$callback` in `WP_Image_Editor_GD::make_image()`. Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269]. Props jrf, aristath, poena, justinahinon, SergeyBiryukov. See #55327. Built from https://develop.svn.wordpress.org/trunk@53270 git-svn-id: http://core.svn.wordpress.org/trunk@52859 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/class-wp-image-editor-gd.php | 6 +++--- wp-includes/version.php | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/wp-includes/class-wp-image-editor-gd.php b/wp-includes/class-wp-image-editor-gd.php index 80e58f77cf..a6dcf1ca12 100644 --- a/wp-includes/class-wp-image-editor-gd.php +++ b/wp-includes/class-wp-image-editor-gd.php @@ -537,15 +537,15 @@ class WP_Image_Editor_GD extends WP_Image_Editor { * @since 3.5.0 * * @param string $filename - * @param callable $function + * @param callable $callback * @param array $arguments * @return bool */ - protected function make_image( $filename, $function, $arguments ) { + protected function make_image( $filename, $callback, $arguments ) { if ( wp_is_stream( $filename ) ) { $arguments[1] = null; } - return parent::make_image( $filename, $function, $arguments ); + return parent::make_image( $filename, $callback, $arguments ); } } diff --git a/wp-includes/version.php b/wp-includes/version.php index f1aa1112f5..6a03ebb24f 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.0-beta2-53269'; +$wp_version = '6.0-beta2-53270'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.