From effd0cc28e290ac22c1ff5829d394b410046458a Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Tue, 1 Dec 2020 17:06:05 +0000 Subject: [PATCH] Editor: Don't unnecessarily split a translatable string in block templates. As a best practice, strings available for translation should contain entire sentences whenever possible. Splitting a sentence in two parts and putting them back together after translation should be avoided, as the word order in other languages can be different from English. Props tobifjellner, kebbet, audrasjb, mukesh27, hellofromTonya, azaozz, SergeyBiryukov. Reviewed by azaozz, SergeyBiryukov. Merges [49722] to the 5.6 branch. Fixes #51893. Built from https://develop.svn.wordpress.org/branches/5.6@49723 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49446 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/block-patterns/large-header-button.php | 2 +- wp-includes/version.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wp-includes/block-patterns/large-header-button.php b/wp-includes/block-patterns/large-header-button.php index 21decac432..313dc26b47 100644 --- a/wp-includes/block-patterns/large-header-button.php +++ b/wp-includes/block-patterns/large-header-button.php @@ -7,7 +7,7 @@ return array( 'title' => __( 'Large header with a heading and a button ' ), - 'content' => "\n
\n
\n
\n
\n
\n\n\n\n
\n
\n\n\n\n

" . __( 'Thou hast seen' ) . '
' . __( 'nothing yet' ) . "

\n\n\n\n\n\n\n\n
\n
\n\n\n\n
\n
\n
\n
\n
\n", + 'content' => "\n
\n
\n
\n
\n
\n\n\n\n
\n
\n\n\n\n

" . __( 'Thou hast seen
nothing yet' ) . "

\n\n\n\n\n\n\n\n
\n
\n\n\n\n
\n
\n
\n
\n
\n", 'viewportWidth' => 1000, 'categories' => array( 'header' ), 'description' => _x( 'A large hero section with a bright gradient background, a big heading and a filled button.', 'Block pattern description' ), diff --git a/wp-includes/version.php b/wp-includes/version.php index 36ed04b858..91327d94ff 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.6-RC1-49721'; +$wp_version = '5.6-RC1-49723'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.