From c06ffe745fbf732fe769fe989697759b5c46b3f7 Mon Sep 17 00:00:00 2001
From: Ryan Boren <ryan@boren.nu>
Date: Mon, 3 Dec 2012 06:37:49 +0000
Subject: [PATCH] Show a spinner when attachment details are saved.

Props koopersmith
see #22613


git-svn-id: http://core.svn.wordpress.org/trunk@22991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-includes/css/media-views.css | 35 ++++++++++++++++++++++-
 wp-includes/js/media-views.js   | 49 +++++++++++++++++++++++++++++++--
 wp-includes/media.php           |  9 +++++-
 3 files changed, 89 insertions(+), 4 deletions(-)

diff --git a/wp-includes/css/media-views.css b/wp-includes/css/media-views.css
index 209d41620a..2cdfcf19d5 100644
--- a/wp-includes/css/media-views.css
+++ b/wp-includes/css/media-views.css
@@ -693,7 +693,7 @@
 	background-position: -60px 0;
 }
 
-.media-frame .describe {
+.media-frame .attachment .describe {
 	position: relative;
 	display: block;
 	width: 100%;
@@ -1160,10 +1160,43 @@
 	line-height: 60px;
 }
 
+/**
+ * Spinner
+ */
+.media-sidebar .settings-save-status {
+	background: #f5f5f5;
+	float: right;
+	text-transform: none;
+	z-index: 10;
+}
+
+.media-sidebar .settings-save-status .spinner {
+	background: url(../../wp-admin/images/wpspin_light.gif) no-repeat;
+	background-size: 16px 16px;
+	display: none;
+	float: right;
+	opacity: 0.7;
+	filter: alpha(opacity=70);
+	width: 16px;
+	height: 16px;
+	margin: 0 5px 0;
+}
+
+.media-sidebar .settings-save-status .saved {
+	float: right;
+	display: none;
+}
+
+.media-sidebar .save-waiting .settings-save-status .spinner,
+.media-sidebar .save-complete .settings-save-status .saved {
+	display: block;
+}
+
 /**
  * Attachment Details
  */
 .attachment-details {
+	position: relative;
 	overflow: auto;
 }
 
diff --git a/wp-includes/js/media-views.js b/wp-includes/js/media-views.js
index 4e3efa2352..4136901608 100644
--- a/wp-includes/js/media-views.js
+++ b/wp-includes/js/media-views.js
@@ -2589,6 +2589,9 @@
 			// Check if the model is selected.
 			this.updateSelect();
 
+			// Update the save status.
+			this.updateSave();
+
 			this.views.render();
 			return this;
 		},
@@ -2693,7 +2696,49 @@
 			value   = event.target.value;
 
 			if ( this.model.get( setting ) !== value )
-				this.model.save( setting, value );
+				this.save( setting, value );
+		},
+
+		// Pass all the arguments to the model's save method.
+		//
+		// Records the aggregate status of all save requests and updates the
+		// view's classes accordingly.
+		save: function() {
+			var view = this,
+				save = this._save = this._save || { status: 'ready' },
+				request = this.model.save.apply( this.model, arguments ),
+				requests = save.requests ? $.when( request, save.requests ) : request;
+
+			// If we're waiting to remove 'Saved.', stop.
+			if ( save.savedTimer )
+				clearTimeout( save.savedTimer );
+
+			this.updateSave('waiting');
+			save.requests = requests;
+			requests.done( function() {
+				// If we've performed another request since this one, bail.
+				if ( save.requests !== requests )
+					return;
+
+				view.updateSave('complete');
+				save.savedTimer = setTimeout( function() {
+					view.updateSave('ready');
+					delete save.savedTimer;
+				}, 2000 );
+			});
+
+		},
+
+		updateSave: function( status ) {
+			var save = this._save = this._save || { status: 'ready' };
+
+			if ( status && status !== save.status ) {
+				this.$el.removeClass( 'save-' + save.status );
+				save.status = status;
+			}
+
+			this.$el.addClass( 'save-' + save.status );
+			return this;
 		},
 
 		updateAll: function() {
@@ -3840,4 +3885,4 @@
 			this.$('img').attr( 'src', this.model.get('url') );
 		}
 	});
-}(jQuery));
\ No newline at end of file
+}(jQuery));
diff --git a/wp-includes/media.php b/wp-includes/media.php
index 1e0ee12d34..c9d3509302 100644
--- a/wp-includes/media.php
+++ b/wp-includes/media.php
@@ -1665,7 +1665,14 @@ function wp_print_media_templates() {
 	</script>
 
 	<script type="text/html" id="tmpl-attachment-details">
-		<h3><?php _e('Attachment Details'); ?></h3>
+		<h3>
+			<?php _e('Attachment Details'); ?>
+
+			<span class="settings-save-status">
+				<span class="spinner"></span>
+				<span class="saved"><?php esc_html_e('Saved.'); ?></span>
+			</span>
+		</h3>
 		<div class="attachment-info">
 			<div class="thumbnail">
 				<# if ( data.uploading ) { #>