From b3e64f0947bca5f1cf20bb4a8f62e388aeededbc Mon Sep 17 00:00:00 2001 From: Adam Silverstein Date: Tue, 10 Sep 2019 18:42:56 +0000 Subject: [PATCH] Comments: add a new `comments_pre_query` filter to short circuit WP_Comment_Query 'get_comments' queries. Return a non-null value to bypass WordPress's default comment queries. Props felipeelia, spacedmonkey. Fixes #45800. Built from https://develop.svn.wordpress.org/trunk@46086 git-svn-id: http://core.svn.wordpress.org/trunk@45898 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/class-wp-comment-query.php | 24 ++++++++++++++++++++++++ wp-includes/version.php | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/wp-includes/class-wp-comment-query.php b/wp-includes/class-wp-comment-query.php index eba9ddf54e..28ac6082e3 100644 --- a/wp-includes/class-wp-comment-query.php +++ b/wp-includes/class-wp-comment-query.php @@ -379,6 +379,30 @@ class WP_Comment_Query { $this->meta_query_clauses = $this->meta_query->get_sql( 'comment', $wpdb->comments, 'comment_ID', $this ); } + $comment_data = null; + + /** + * Filter the comments data before the query takes place. + * + * Return a non-null value to bypass WordPress's default comment queries. + * + * The expected return type from this filter depends on the value passed in the request query_vars: + * When $this->query_vars['count'] is set, the filter should return the comment count as an int. + * When `'ids' == $this->query_vars['fields']`, the filter should return an array of comment ids. + * Otherwise the filter should return an array of WP_Comment objects. + * + * @since 5.3.0 + * + * @param array|int|null $comment_data Return an array of comment data to short-circuit WP's comment query, + * or null to allow WP to run its normal queries. + * @param WP_Comment_Query $this The WP_Comment_Query instance, passed by reference. + */ + $comment_data = apply_filters_ref_array( 'comments_pre_query', array( $comment_data, &$this ) ); + + if ( null !== $comment_data ) { + return $comment_data; + } + /* * Only use the args defined in the query_var_defaults to compute the key, * but ignore 'fields', which does not affect query results. diff --git a/wp-includes/version.php b/wp-includes/version.php index b94a9b3a07..6354c88b19 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.3-alpha-46085'; +$wp_version = '5.3-alpha-46086'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.