From 6e3516b1b65b0210eff7e15dd4fd334aa3e03cc0 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov.ru@gmail.com>
Date: Tue, 11 Jun 2024 12:38:14 +0000
Subject: [PATCH] Administration: Remove redundant type casting in
 `WP_List_Table::search_box()`.

Scalar values passed to `esc_attr()` are already converted internally to a string via both `wp_check_invalid_utf8()` and `_wp_specialchars()`.

Includes adding `@covers` tags for unit tests.

Follow-up to [58379].

See #58379.
Built from https://develop.svn.wordpress.org/trunk@58389


git-svn-id: http://core.svn.wordpress.org/trunk@57838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-admin/includes/class-wp-list-table.php | 5 -----
 wp-includes/version.php                   | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/wp-admin/includes/class-wp-list-table.php b/wp-admin/includes/class-wp-list-table.php
index 971ea7e224..820fc5e840 100644
--- a/wp-admin/includes/class-wp-list-table.php
+++ b/wp-admin/includes/class-wp-list-table.php
@@ -390,11 +390,6 @@ class WP_List_Table {
 		if ( ! empty( $_REQUEST['orderby'] ) ) {
 			if ( is_array( $_REQUEST['orderby'] ) ) {
 				foreach ( $_REQUEST['orderby'] as $key => $value ) {
-					/*
-					 * Orderby can be either an associative array or non-associative array.
-					 * In the latter case, this makes sure the key is a string before calling esc_attr().
-					 */
-					$key = (string) $key;
 					echo '<input type="hidden" name="orderby[' . esc_attr( $key ) . ']" value="' . esc_attr( $value ) . '" />';
 				}
 			} else {
diff --git a/wp-includes/version.php b/wp-includes/version.php
index d2142da940..4b32e3041b 100644
--- a/wp-includes/version.php
+++ b/wp-includes/version.php
@@ -16,7 +16,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '6.6-beta1-58388';
+$wp_version = '6.6-beta1-58389';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.