From 225fe28e9fd7ee7380901aa7e77e3f0e671cab2a Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 28 Apr 2023 15:06:21 +0000 Subject: [PATCH] Coding Standards: Bring some consistency to REST API revisions initialization. The autosaves and revisions controllers used to set the same class properties in a slightly different order. This commit makes the `::__construct()` methods of both classes more consistent to simplify future maintenance. Follow-up to [46272], [51962]. See #57839. Built from https://develop.svn.wordpress.org/trunk@55697 git-svn-id: http://core.svn.wordpress.org/trunk@55209 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../class-wp-rest-autosaves-controller.php | 2 +- .../class-wp-rest-revisions-controller.php | 16 +++++++++------- wp-includes/version.php | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php b/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php index e5409e7329..e74c328ee8 100644 --- a/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php +++ b/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php @@ -68,8 +68,8 @@ class WP_REST_Autosaves_Controller extends WP_REST_Revisions_Controller { $this->parent_controller = $parent_controller; $this->revisions_controller = new WP_REST_Revisions_Controller( $parent_post_type ); $this->rest_base = 'autosaves'; - $this->namespace = ! empty( $post_type_object->rest_namespace ) ? $post_type_object->rest_namespace : 'wp/v2'; $this->parent_base = ! empty( $post_type_object->rest_base ) ? $post_type_object->rest_base : $post_type_object->name; + $this->namespace = ! empty( $post_type_object->rest_namespace ) ? $post_type_object->rest_namespace : 'wp/v2'; } /** diff --git a/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php b/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php index 0f1cc81723..6fde5f13f5 100644 --- a/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php +++ b/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php @@ -48,16 +48,18 @@ class WP_REST_Revisions_Controller extends WP_REST_Controller { * @param string $parent_post_type Post type of the parent. */ public function __construct( $parent_post_type ) { - $this->parent_post_type = $parent_post_type; + $this->parent_post_type = $parent_post_type; + $post_type_object = get_post_type_object( $parent_post_type ); + $parent_controller = $post_type_object->get_rest_controller(); + + if ( ! $parent_controller ) { + $parent_controller = new WP_REST_Posts_Controller( $parent_post_type ); + } + + $this->parent_controller = $parent_controller; $this->rest_base = 'revisions'; - $post_type_object = get_post_type_object( $parent_post_type ); $this->parent_base = ! empty( $post_type_object->rest_base ) ? $post_type_object->rest_base : $post_type_object->name; $this->namespace = ! empty( $post_type_object->rest_namespace ) ? $post_type_object->rest_namespace : 'wp/v2'; - $this->parent_controller = $post_type_object->get_rest_controller(); - - if ( ! $this->parent_controller ) { - $this->parent_controller = new WP_REST_Posts_Controller( $parent_post_type ); - } } /** diff --git a/wp-includes/version.php b/wp-includes/version.php index c319906504..c874179153 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.3-alpha-55696'; +$wp_version = '6.3-alpha-55697'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.