From 090dfae53eaec04781eaded650f66be9e55846f0 Mon Sep 17 00:00:00 2001 From: John Blackbourn Date: Wed, 4 Oct 2017 15:38:49 +0000 Subject: [PATCH] REST API: Avoid counting an uncountable type when checking read permissions for comment posts. This avoids deprecated notices from showing in PHP 7.2 and above. Props ayeshrajans Fixes #41457 Built from https://develop.svn.wordpress.org/trunk@41735 git-svn-id: http://core.svn.wordpress.org/trunk@41569 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../rest-api/endpoints/class-wp-rest-comments-controller.php | 2 +- wp-includes/version.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php b/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php index 4eced8f8ae..23b1262c3c 100644 --- a/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php +++ b/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php @@ -1513,7 +1513,7 @@ class WP_REST_Comments_Controller extends WP_REST_Controller { $has_password_filter = false; // Only check password if a specific post was queried for or a single comment - $requested_post = ! empty( $request['post'] ) && 1 === count( $request['post'] ); + $requested_post = ! empty( $request['post'] ) && ( !is_array( $request['post'] ) || 1 === count( $request['post'] ) ); $requested_comment = ! empty( $request['id'] ); if ( ( $requested_post || $requested_comment ) && $posts_controller->can_access_password_content( $post, $request ) ) { add_filter( 'post_password_required', '__return_false' ); diff --git a/wp-includes/version.php b/wp-includes/version.php index 32323dce23..ff68437a15 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.9-alpha-41734'; +$wp_version = '4.9-alpha-41735'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.